[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 407967. zixuw added a comment. Fix a test failure on Windows where the ':' delimiter for sed was taken by the Windows path convention. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.ll

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

MaskRay added a comment. It may not be worth changing now, but I want to mention: it's more conventional to have a `BoolOption` which adds `-[no-]noundef-analysis`. Since both positive and negative forms exist. When we make the default switch, existing users don't need to change the option. Aft

[PATCH] D119367: [HWASan] Allow no_sanitize(..) and change metadata passing.

pcc added a comment. In addition to the .bc support we will also need support for reading/writing .ll files. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1721 -static DenseSet getExcludedGlobals(Module &M) { - NamedMDNode *Globals = M.getNamedMetadat

[PATCH] D119226: [clang][lex][minimizer] Avoid treating path separators as comments

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Cheers, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119226/new/ https://reviews.llvm.org/D119226 ___

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

xbolva00 added a comment. @void It would be cool to mention this new feature in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 ___ cfe-commits m

[PATCH] D119574: [clang] Expose -fprofile-use in clang-cl

thakis created this revision. thakis added a reviewer: hans. Herald added a subscriber: dang. thakis requested review of this revision. Less typing than `-fprofile-instr-use`, and means the same thing. https://reviews.llvm.org/D119574 Files: clang/include/clang/Driver/Options.td clang/test/

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

urnathan added inline comments. Comment at: clang/test/CodeGenCXX/static-variable-in-module.cpp:2-8 +// RUN: mkdir %t +// RUN: echo "struct S { S(); };" >> %t/foo.h +// RUN: echo "static S s = S();" >> %t/foo.h +// RUN: %clang -std=c++20 -I%t %s -S -emit-llvm -o - | FileCheck %s

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

urnathan added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG: @inline_var_e

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4605 + TryEmitAsCallSiteAttribute(const llvm::AttributeList &Attrs) { +llvm::AttributeList NewAttrs = Attrs; +if (AA) jyknight wrote: > We do need to fallback to an assume for > "if

[PATCH] D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization

NeHuang updated this revision to Diff 407877. NeHuang marked an inline comment as done. NeHuang added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117355/new/ https://reviews.llvm.org/D117355 Files: llvm/lib/

[clang] d5c314c - [Clang][OpaquePtr] Remove deprecated Address constructor calls

Author: Weverything Date: 2022-02-11T13:02:09-08:00 New Revision: d5c314cdf43aeab2e7eda2b8a40afae4d01b030f URL: https://github.com/llvm/llvm-project/commit/d5c314cdf43aeab2e7eda2b8a40afae4d01b030f DIFF: https://github.com/llvm/llvm-project/commit/d5c314cdf43aeab2e7eda2b8a40afae4d01b030f.diff L

[PATCH] D119496: [Clang][OpaquePtr] Remove calls to deprecated Address constructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5c314cdf43a: [Clang][OpaquePtr] Remove deprecated Address constructor calls (authored by rtrieu). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D118070: Make lld-link work in a non-MSVC shell

aprantl added a comment. Unfortunately this seems to break the modular build. Would you mind taking a look? I'm going to revert the patch to get the bots going again. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41306/console Comment at: llvm/include/llvm/Support

[clang] baac665 - Revert "[lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot:"

Author: Adrian Prantl Date: 2022-02-11T13:07:23-08:00 New Revision: baac665adf324672802dcc7037a25468e9569c95 URL: https://github.com/llvm/llvm-project/commit/baac665adf324672802dcc7037a25468e9569c95 DIFF: https://github.com/llvm/llvm-project/commit/baac665adf324672802dcc7037a25468e9569c95.diff

[PATCH] D119574: [clang] Expose -fprofile-use in clang-cl

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119574/new/ https://reviews.llvm.org/D119574 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D119509: [analyzer] Fix a crash in NoStateChangeVisitor with body-farmed stack frames.

NoQ updated this revision to Diff 408012. NoQ added a comment. Oh, great point. Added tests that were crashing the other way round so that to demonstrate that this fix is still justified. But I agree that the visitor can totally terminate early so that to make the original tests pass for two rea

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 edited the summary of this revision. durin42 updated this revision to Diff 408019. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-al

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. Thanks for the revert! Is there any documentation for that LLVM_ENABLE_MODULES build config anywhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 _

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 408027. zixuw added a comment. Fix a test failure on Windows where diff doesn't recognize the "-a" option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 Files: clan

[clang] 6f1147f - [clang] Expose -fprofile-use in clang-cl

Author: Nico Weber Date: 2022-02-11T16:16:02-05:00 New Revision: 6f1147f825d087f8486a685024078fe08dba755c URL: https://github.com/llvm/llvm-project/commit/6f1147f825d087f8486a685024078fe08dba755c DIFF: https://github.com/llvm/llvm-project/commit/6f1147f825d087f8486a685024078fe08dba755c.diff LO

[PATCH] D119574: [clang] Expose -fprofile-use in clang-cl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f1147f825d0: [clang] Expose -fprofile-use in clang-cl (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo C

[PATCH] D119138: [clang-format] Further improve support for requires expressions

HazardyKnusperkeks updated this revision to Diff 408028. HazardyKnusperkeks marked 6 inline comments as done. HazardyKnusperkeks added a comment. Rebased and updated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119138/new/ https://reviews.llvm.org/D119138 Files: clang/lib/Format/Unw

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added inline comments. Comment at: llvm/include/llvm/Support/MSVCPaths.h:15 +#include "llvm/Option/ArgList.h" +#include "llvm/Support/VirtualFileSystem.h" +#include aprantl wrote: > This introduces a cyclic dependency that breaks the `-DLLVM_ENABLE_MODULE

[PATCH] D119590: exclude openembedded distributions from setting rpath on openmp executables

raj.khem created this revision. raj.khem added reviewers: jhuber6, JonChesterfield. Herald added subscribers: guansong, yaxunl. raj.khem requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. OpenEmbedd

[PATCH] D119138: [clang-format] Further improve support for requires expressions

Quuxplusone added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2798-2802 +// This one is really tricky, since most tokens doesn't have a type yet. +// The & or && can be binary operators, then we have a requires +// expression. But they also c

[clang] 9aab0db - [clang-format] Improve require and concept handling

Author: Björn Schäpers Date: 2022-02-11T22:42:37+01:00 New Revision: 9aab0db13fb6d21d1b70247a9b5e4cf916ee1c3a URL: https://github.com/llvm/llvm-project/commit/9aab0db13fb6d21d1b70247a9b5e4cf916ee1c3a DIFF: https://github.com/llvm/llvm-project/commit/9aab0db13fb6d21d1b70247a9b5e4cf916ee1c3a.diff

[PATCH] D113319: [clang-format] Improve require and concept handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG9aab0db13fb6: [clang-format] Improve require and concept handling (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D113319?vs=406444&id=408039#toc Repository: rG LL

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, mgorny. vtjnash requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The clang-analyzer plugins are not

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. In D119051#3314138 , @Bhramar.vatsa wrote: > Sorry, but I can only add a bit more confusion: > https://godbolt.org/z/fT19KTh34 > There are two cases, only differing in terms of user-defined constructor. > > Gcc and clang differ

[PATCH] D119592: Insert a blurb about the -fzero-call-used-regs feature

void created this revision. void added reviewers: nickdesaulniers, kees. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119592 Files: clang/docs/ReleaseNotes.rst In

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3315135 , @xbolva00 wrote: > @void It would be cool to mention this new feature in release notes. Good idea! https://reviews.llvm.org/D119592 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3298391 , @MaskRay wrote: > Ping @phosek Ping @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 __

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added a comment. A friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org/D113369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] 73e585e - Reland "[lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot:"

Author: Nico Weber Date: 2022-02-11T17:07:33-05:00 New Revision: 73e585e44d68cf77e2e3274e98c9615156a7d909 URL: https://github.com/llvm/llvm-project/commit/73e585e44d68cf77e2e3274e98c9615156a7d909 DIFF: https://github.com/llvm/llvm-project/commit/73e585e44d68cf77e2e3274e98c9615156a7d909.diff LO

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. Relanded in 73e585e44d68cf77e2e3274e98c9615156a7d909 , with the new files in a new WindowsDriver library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rjmccall added a comment. Changing the C++03 POD definition is going to be substantially ABI-breaking at this point. Any logic to change it needs to be platform-specific. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.l

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rjmccall added a comment. And this should be raised as an Itanium issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commit

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc5bf040d810: fix check-clang-tools tests that fail due to Windows CRLF line endings (authored by poelmanc, committed by LegalizeAdulthood). Herald added a project: LLVM. Herald added a subscriber: llvm-c

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. In D117522#3299423 , @carlosgalvezp wrote: > I'm mostly interested on the warning message, [...] I'm open to changes in the wording of the warning message. > I get an error when downloading, do you happen to know what

[PATCH] D119597: [clang-format][NFC] Give State.Stack.back() a meaningful name

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without th

[clang] a730b6a - [NFC] clang-format one function.

Author: Evgenii Stepanov Date: 2022-02-11T15:00:29-08:00 New Revision: a730b6a41ad7e57a015c4a310850b14513ecb70c URL: https://github.com/llvm/llvm-project/commit/a730b6a41ad7e57a015c4a310850b14513ecb70c DIFF: https://github.com/llvm/llvm-project/commit/a730b6a41ad7e57a015c4a310850b14513ecb70c.di

[PATCH] D119299: [NFC] clang-format one function.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa730b6a41ad7: [NFC] clang-format one function. (authored by eugenis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119299/new/ https://reviews.llvm.org/D11

[clang] 0d9b915 - [Preprocessor] Reduce the memory overhead of `#define` directives

Author: Alex Lorenz Date: 2022-02-11T15:01:10-08:00 New Revision: 0d9b91524ea4db3760791bba15773c386a26d8ec URL: https://github.com/llvm/llvm-project/commit/0d9b91524ea4db3760791bba15773c386a26d8ec DIFF: https://github.com/llvm/llvm-project/commit/0d9b91524ea4db3760791bba15773c386a26d8ec.diff L

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d9b91524ea4: [Preprocessor] Reduce the memory overhead of `#define` directives (authored by arphaman). Herald added a project: clang. Repository:

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

eugenis updated this revision to Diff 408071. eugenis added a comment. Fix handling of empty base classes and suppress tail calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119300/new/ https://reviews.llvm.org/D119300 Files: clang/lib/CodeGe

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw created this revision. sstwcw added reviewers: curdeius, HazardyKnusperkeks. sstwcw added projects: clang-format, clang-tools-extra. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. About the column limit option in the test Ali

[PATCH] D119600: Stricter use-after-dtor detection for trivial members.

eugenis created this revision. eugenis added reviewers: vitalybuka, kda. eugenis requested review of this revision. Herald added a project: clang. Poison trivial class members one-by-one in the reverse order of their construction, instead of all-at-once at the very end. For example, in the follow

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Thanks for chiming in! In D119051#3315741 , @rjmccall wrote: > Changing the C++03 POD definition is going to be substantially ABI-breaking > at this point. Any logic to change it needs to be platform-specific. Even if it's on

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 408079. lichray added a comment. - Rephrase a warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D118986: [clang][deps] Return the whole TU command line

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. This does require build systems to be able to totally replace a command line rather than just add to it, but it seems like that's a requirement unless we add a way to modify the command

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers created this revision. vabridgers added reviewers: NoQ, martong. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. vabridgers requested review of this revision. Herald ad

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. In D119051#3315747 , @rjmccall wrote: > And this should be raised as an Itanium issue. Ah, looks like this is the existing https://github.com/itanium-cxx-abi/cxx-abi/issues/66 Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

thakis added a comment. Very cool! Looks like it broke lldb builds though: http://45.33.8.238/linux/68321/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 __

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman added a comment. Yep, I just noticed. Reverting for now and will fix LLDB before recommitting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-

[clang] 3f05192 - Revert "[Preprocessor] Reduce the memory overhead of `#define` directives"

Author: Alex Lorenz Date: 2022-02-11T15:53:16-08:00 New Revision: 3f05192c4c40bc79b1db431a7a36baaa9491eebb URL: https://github.com/llvm/llvm-project/commit/3f05192c4c40bc79b1db431a7a36baaa9491eebb DIFF: https://github.com/llvm/llvm-project/commit/3f05192c4c40bc79b1db431a7a36baaa9491eebb.diff L

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman added a comment. Revert: To github.com:llvm/llvm-project.git bdf573652138..3f05192c4c40 main -> main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 _

[PATCH] D119590: exclude openembedded distributions from setting rpath on openmp executables

JonChesterfield added a comment. Cross compilers are a hazard here. I'd expect there to be a fairly long list of magic flags you need to pass to clang to get it to find the right libraries. Can you add fno-openmp-implicit-rpath to that list instead? A better solution might be a cmake flag to sp

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 updated this revision to Diff 408097. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-align-attr.c clang/test/CodeGen/alloc-fns-ali

[PATCH] D118070: Make lld-link work in a non-MSVC shell

dyung added a comment. I'm not exactly sure why, but this change seems to be causing the Driver/cl-options.c test to fail on the PS4 Windows bot: https://lab.llvm.org/staging/#/builders/204/builds/1343 It was also failing previously after the original commit until it was reverted at which poin

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray marked 2 inline comments as done. lichray added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2396 +def ext_decltype_auto_expr : ExtWarn< + "ISO C++23 DIS does not allow functional-style cast to 'decltype(auto)'">, + InGroup>; ---

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers updated this revision to Diff 408104. vabridgers added a comment. Update after makeNull fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.org/D118050 Files: clang/lib/StaticAnalyzer/Checkers/CStringC

[PATCH] D119574: [clang] Expose -fprofile-use in clang-cl

paulkirth added a comment. Hi, I think we hit a test failure due to this patch in Fuchsia's Clang canary for Windows. We've had a lot of breakages on Windows today, so this was hidden until 0574b5fc landed. The failing test

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 updated this revision to Diff 408116. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-align-attr.c clang/test/CodeGen/alloc-fns-ali

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

junaire created this revision. junaire added reviewers: aaron.ballman, rsmith. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang will try to act on ReturnStmt when parsing the lambda declarator, which is not desirable. LambdaSco

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. Mmm... just realized that this check should invalidate any macro that is used in a conditional compilation expression, because enums can't be used there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 __

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408129. junaire added a comment. Add tests for long double. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c Index: cla

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire added a comment. > I think we should probably have test coverage for `long double` as well, but > I also wonder whether it makes sense to add coverage for the small > floating-point types (like `_Float16`) as well, or whether we already have > coverage for those elsewhere. Test long do

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408133. junaire added a comment. long double should use `L` as literal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408134. junaire added a comment. Add missing blank. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c Index: clang/test/

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 408137. lichray added a comment. Rerun pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h clang/includ

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tahonermann added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3462 - case 'u': // Identifier (uber) or C11/C++11 UTF-8 or UTF-16 string literal + case 'u': // Identifier (uber) or C11/C2x/C++11 UTF-8 or UTF-16 string literal // Notify MIOpt that we read a non

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis created this revision. thakis added a reviewer: lld-macho. Herald added subscribers: ormris, steven_wu, hiraditya. thakis requested review of this revision. - ld64.lld now completely supports -export_dynamic (D119372 ), so map -rdynamic to -export_dynamic

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. jhuber6 added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. This patch adds support for linking CPU

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:242 } else if (D.getLTOMode() == LTOK_Thin) // If we are using thin LTO, then create a directory instead. TmpPathName = D.GetTemporaryDirectory("thinlto"); lgrey:

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. It fails on this: // Validate that the default triple is used when run an empty tools dir is specified // RUN: %clang_cl -vctoolsdir "" -### -- %s 2>&1 | FileCheck %s --check-prefix VCTOOLSDIR // VCTOOLSDIR: "-triple" "{{[a-zA-Z0-9_-]*}}-pc-windows-msvc19.20.0" Wi

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:645-646 - auto ValueToUpdate = C.getSValBuilder().makeNull(); + auto ValueToUpdate = C.getSValBuilder().makeNullWithType( + IC->getCXXThisVal().getType(C.getASTContext())); S

[PATCH] D119615: [CUDA][HIP] Do not promote constexpr var with non-constant initializer

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. constexpr var may be initialized with address of non-const variable. In this case the initializer is not constant in device compilation. This has been handled for const vars but not for constexpr

[PATCH] D119621: [SanitizerCoverage] Add instrumentation callbacks for FP cmp instructions

shouc created this revision. shouc added reviewers: morehouse, rnk, vitalybuka. Herald added subscribers: abrachet, hiraditya. shouc requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Fuzzers need to a

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

phyBrackets added a comment. In D119364#3310170 , @rjmccall wrote: > Sure, LGTM Yeah, will keep in mind. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119364/new/ https://reviews.llvm.org/D119364

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

phyBrackets added a comment. In D119364#3310170 , @rjmccall wrote: > Sure, LGTM Hey Thanks, would you please help to land this patch . I don't have commit access . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D119621: [SanitizerCoverage] Add instrumentation callbacks for FP cmp instructions

shouc updated this revision to Diff 408164. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119621/new/ https://reviews.llvm.org/D119621 Files: clang/docs/SanitizerCoverage.rst compiler-rt/lib/dfsan/done_abilist.txt compiler-rt/lib/sanitizer_common/sanitizer_coverage_fuchsia.cpp co

[clang] 437d4e0 - Revert "try to fix windows build after 73e585e44d" and

Author: Douglas Yung Date: 2022-02-11T23:47:53-08:00 New Revision: 437d4e01fe4c057509dff30efd560049ad07bc99 URL: https://github.com/llvm/llvm-project/commit/437d4e01fe4c057509dff30efd560049ad07bc99 DIFF: https://github.com/llvm/llvm-project/commit/437d4e01fe4c057509dff30efd560049ad07bc99.diff

[PATCH] D119462: [analyzer][NFCi] Use the correct BugType in CStringChecker.

phyBrackets added a comment. In D119462#3312482 , @steakhal wrote: > I would recommend not touching the unrelated lines, unless you have a clear > motive. Other than that I think its fair to say that this must have been a > bug. Ill check the report dif

[PATCH] D118070: Make lld-link work in a non-MSVC shell

dyung added a comment. I've reverted this and the follow-up change to fix the build in 437d4e01fe4c057509dff30efd560049ad07bc99 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

<    1   2