aprantl added a comment. Unfortunately this seems to break the modular build. Would you mind taking a look? I'm going to revert the patch to get the bots going again.
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41306/console ================ Comment at: llvm/include/llvm/Support/MSVCPaths.h:15 +#include "llvm/Option/ArgList.h" +#include "llvm/Support/VirtualFileSystem.h" +#include <string> ---------------- This introduces a cyclic dependency that breaks the `-DLLVM_ENABLE_MODULES=1` build. ``` /Volumes/Data/llvm-project/llvm/include/llvm/Option/Arg.h:17:10: fatal error: cyclic dependency in module 'LLVM_Utils': LLVM_Utils -> LLVM_Option -> LLVM_Utils #include "llvm/ADT/SmallVector.h" ^ While building module 'LLVM_Utils' imported from /Volumes/Data/llvm-project/llvm/lib/Support/ARMBuildAttrs.cpp:9: In file included from <module-includes>:195: /Volumes/Data/llvm-project/llvm/include/llvm/Support/MSVCPaths.h:14:10: fatal error: could not build module 'LLVM_Option' #include "llvm/Option/ArgList.h" ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ /Volumes/Data/llvm-project/llvm/lib/Support/ARMBuildAttrs.cpp:9:10: fatal error: could not build module 'LLVM_Utils' #include "llvm/Support/ARMBuildAttributes.h" ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 3 errors generated. ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
