thakis added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:242
     } else if (D.getLTOMode() == LTOK_Thin)
       // If we are using thin LTO, then create a directory instead.
       TmpPathName = D.GetTemporaryDirectory("thinlto");
----------------
lgrey: Do you think this should interact with 
134275d994d5fb38edfeb587ba45c8f495c8bf66 in any way, or should have any other 
interesting side effects?

From what I understand, it tells the linker to put temporary files created for 
LTO in the given directory, but then the clang driver cleans up that directory 
when it exits (potentially after running dsymutil). But most people run 
dsymutil later, separately, so I think there should be no interactions there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119612/new/

https://reviews.llvm.org/D119612

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to