[PATCH] D117647: [RISCV] Add passthru operand for RVV nomask load intrinsics.

khchen updated this revision to Diff 402776. khchen added a comment. Herald added a subscriber: pcwang-thead. rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117647/new/ https://reviews.llvm.org/D117647 Files: clang/include/clang/

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Last nits, apart from this clean up, I'm OK. Comment at: clang/lib/Format/FormatToken.h:125 +/// Operators that can follow a C variable. +static const std::set

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

salman-javed-nz updated this revision to Diff 402774. salman-javed-nz added a comment. `ClangTidyContext::shouldSuppressDiagnostic()`: - Hook up `AllowIO` and `EnableNoLintBlocks` to `NoLintDirectiveHandler::shouldSuppress()` `NoLintToken`: -Remove copy ctor and assignment operator. Class is no

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402780. cor3ntin added a comment. Address Erich's feedback: A source range was only constructed from the first element Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117994/new/ https://reviews.llvm.org/D117994

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402781. cor3ntin marked an inline comment as done. cor3ntin added a comment. Address Erich's feedback: A source range was only constructed from the first element Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaAccess.cpp:1799 +R = SourceRange(ArgExprs.front()->getBeginLoc(), +ArgExprs.front()->getEndLoc()); + } erichkeane wrote: > So should the 'end' be `ArgExprs.back()->getEndLoc()

[PATCH] D117929: [XRay] Add support for RISCV

dberris requested changes to this revision. dberris added a comment. This revision now requires changes to proceed. It looks like you'll need to address the lint issues (using clang-format). I'm not an expert on RISCV assembly so you might need to get someone familiar with the ISA reviewing this

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added a comment. There is an old solution in https://reviews.llvm.org/D117423. The concern over there is that AVR specific checks should be implemented in AVR toolchain specific files. And this patch obeys that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D118106: [clang-format] Fix regression in parsing pointers to arrays.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/53293. After commit 5c2e7c9

[clang] 2a14bc5 - [NFC] [C++20] [Modules] Update comments for handling friend

Author: Chuanqi Xu Date: 2022-01-25T16:39:47+08:00 New Revision: 2a14bc55c547f0fc7285b783b5320338c3ffdc42 URL: https://github.com/llvm/llvm-project/commit/2a14bc55c547f0fc7285b783b5320338c3ffdc42 DIFF: https://github.com/llvm/llvm-project/commit/2a14bc55c547f0fc7285b783b5320338c3ffdc42.diff LO

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

JackAKirk added a comment. In D118023#3267271 , @tra wrote: > The patch uses a `@gmail.com` email. Should I change it to `JackAKirk > ` to match the sign-off email? Ah yes thanks for catching that. Please use `JackAKirk `. Repository: rG LLVM Gith

[clang] aa97bc1 - [NFC] Remove uses of PointerType::getElementType()

Author: Nikita Popov Date: 2022-01-25T09:44:52+01:00 New Revision: aa97bc116d343f7b6f222d7229668de5d361b312 URL: https://github.com/llvm/llvm-project/commit/aa97bc116d343f7b6f222d7229668de5d361b312 DIFF: https://github.com/llvm/llvm-project/commit/aa97bc116d343f7b6f222d7229668de5d361b312.diff

[PATCH] D117137: [Driver] Add CUDA support for --offload param

linjamaki added a comment. SPIR-V target requires that the OS and the environment type is unknown (see TargetInfo::AllocateTarget and BaseSPIRTargetInfo). The clang would fail to create a SPIR-V target if there is an OS or environment component in the target string known by the Triple. This cou

[PATCH] D118109: [clang] Replace `std::vector` use in Syntax

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM Programmer’s Manual strongly discourages the use of `std::vector` and suggests `llvm::BitVecto

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, shchenz, PowerPC. Herald added subscribers: steven.zhang, kbarton, mgorny. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This method introduces new CMake variable `

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clang-tidy/NoLintDirectiveHandler.cpp:187 +static SmallVector +formNoLintBlocks(SmallVector &NoLints, + SmallV

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

steakhal added a subscriber: NoQ. steakhal added a comment. I'm wondering if we should have an assertion within the `SValBuilder::evalBinOpLL()` asserting that the pointers should have the same bitwidths. That's better than having nothing, waiting for a bugreport containing such a constraint on

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

DavidSpickett added a comment. I may have missed this in the many test changes but are we left with a test that demonstrates that the codegen restriction still works? I see some that set one or the other, any with both that would catch us breaking this feature later? Repository: rG LLVM Gith

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

DavidSpickett added inline comments. Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:10977 -Warning(IDLoc, "deprecated instruction in IT block"); - } } MarkMurrayARM wrote: > DavidSpickett wrote: > > Is this warning something you'd st

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

frasercrmck added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vscale-range.ll:162 + +attributes #0 = { vscale_range(2,1024) } +attributes #1 = { vscale_range(4,1024) } khchen wrote: > I'm thinking do we need to test zvl and vscale_range

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGen/aarch64-mops.c:3 + +// RUN: %clang_cc1 -triple aarch64-arm-unknown-eabi -target-feature +mops -S -emit-llvm -o - %s | FileCheck %s + I forgot if we add negative tests for these things, i.e. chec

[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

tbaeder updated this revision to Diff 402813. tbaeder added a comment. Limited the change to c++2b CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117295/new/ https://reviews.llvm.org/D117295 Files: clang/lib/Sema/SemaModule.cpp clang/test/CXX/module/module.interface/p3.cpp clang/t

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers added a comment. Good thoughts, I will try those things and get back to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.org/D118050 ___ cfe-commits mailing

[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:650-652 +if (S.getLangOpts().CPlusPlus2b) { + if (BlockStart.isInvalid()) +diagExportedUnnamedDecl(S, *UDK, D, BlockStart); Should we add a cite to P1766R1 here? ===

[clang] 99adacb - [clang] Remove some getPointerElementType() uses

Author: Nikita Popov Date: 2022-01-25T12:09:06+01:00 New Revision: 99adacbcb7895114a62266c8a15e794bacd2380c URL: https://github.com/llvm/llvm-project/commit/99adacbcb7895114a62266c8a15e794bacd2380c DIFF: https://github.com/llvm/llvm-project/commit/99adacbcb7895114a62266c8a15e794bacd2380c.diff

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

salman-javed-nz updated this revision to Diff 402818. salman-javed-nz added a comment. Review comment: `formNoLintBlocks()` - drop the `&` so the vector must be std::moved in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116085/new/ https://review

[PATCH] D118119: [clang][dataflow] Add a transfer function for InitListExpr

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A

[PATCH] D118120: [C++20] [Modules] Only check decls under namespace scope in CheckRedeclarationExported

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, aaron.ballman, urnathan, erichkeane, tbaeder. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. Since only the decls inhabit in a namespace scope could be export

[PATCH] D118120: [C++20] [Modules] Only check decls under namespace scope in CheckRedeclarationExported

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1643-1648 + if (!New->getLexicalDeclContext() + ->getNonTransparentContext() + ->isFileContext() || + !Old->getLexicalDeclContext() + ->getNonTransparentContext() +

[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:650-652 +if (S.getLangOpts().CPlusPlus2b) { + if (BlockStart.isInvalid()) +diagExportedUnnamedDecl(S, *UDK, D, BlockStart); Chuanqi

[clang] caff859 - [OpenMP] Simplify pointer comparison

Author: Nikita Popov Date: 2022-01-25T12:38:37+01:00 New Revision: caff8591eff211c41d8de8505f89754d09ca6fa7 URL: https://github.com/llvm/llvm-project/commit/caff8591eff211c41d8de8505f89754d09ca6fa7 DIFF: https://github.com/llvm/llvm-project/commit/caff8591eff211c41d8de8505f89754d09ca6fa7.diff

[PATCH] D118016: [clang-tidy] Change code of SignalHandlerCheck (NFC).

balazske updated this revision to Diff 402832. balazske added a comment. Added tests to check more specific behavior. Removed AST matcher of TU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118016/new/ https://reviews.llvm.org/D118016 Files: cl

[clang] 91a0b46 - [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins

Author: Sven van Haastregt Date: 2022-01-25T11:40:31Z New Revision: 91a0b464a853821734db8b1c521df03f8e2e56e7 URL: https://github.com/llvm/llvm-project/commit/91a0b464a853821734db8b1c521df03f8e2e56e7 DIFF: https://github.com/llvm/llvm-project/commit/91a0b464a853821734db8b1c521df03f8e2e56e7.diff

[PATCH] D117899: [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG91a0b464a853: [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1178

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

paulwalker-arm added a comment. Does this mean `RISCVTTIImpl::getMaxVScale()` can be removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107290/new/ https://reviews.llvm.org/D107290 ___ cfe-commits ma

[clang] 30d4a7e - [IRBuilder] Require explicit element type in CreatePtrDiff()

Author: Nikita Popov Date: 2022-01-25T12:43:57+01:00 New Revision: 30d4a7e2955356c69ae412bfe2de46b92a2202c1 URL: https://github.com/llvm/llvm-project/commit/30d4a7e2955356c69ae412bfe2de46b92a2202c1 DIFF: https://github.com/llvm/llvm-project/commit/30d4a7e2955356c69ae412bfe2de46b92a2202c1.diff

[PATCH] D118016: [clang-tidy] Change code of SignalHandlerCheck (NFC).

balazske marked 2 inline comments as done. balazske added a comment. The `CallGraph` just scans for `FunctionDecl` and `CallExpr`, no check for unreachable code is there. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:131 + if (const auto *TU = Resul

[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:650-652 +if (S.getLangOpts().CPlusPlus2b) { + if (BlockStart.isInvalid()) +diagExportedUnnamedDecl(S, *UDK, D, BlockStart); tbaeder wrote: > ChuanqiXu wrote: > > Should we

[PATCH] D118119: [clang][dataflow] Add a transfer function for InitListExpr

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:421 +QualType Type = S->getType(); +assert(Type->isStructureOrClassType()); + Why do we expect this assertion to be true? Aren't `InitListExpr`s also used to initi

[PATCH] D118119: [clang][dataflow] Add a transfer function for InitListExpr

sgatev updated this revision to Diff 402840. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118119/new/ https://reviews.llvm.org/D118119 Files: clang/in

[PATCH] D118119: [clang][dataflow] Add a transfer function for InitListExpr

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:421 +QualType Type = S->getType(); +assert(Type->isStructureOrClassType()); + xazax.hun wrote: > Why do we expect this assertion to be true? Aren't `InitListExpr`s als

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 402850. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h clan

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

carlosgalvezp accepted this revision. carlosgalvezp added a comment. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116085/new/ https://reviews.llvm.org/D116085 ___ cfe-commits mailing list c

[clang-tools-extra] c0e3c89 - [NFC][clangd] cleaning up llvm-qualified-auto

Author: Christian Kühnel Date: 2022-01-25T13:26:33Z New Revision: c0e3c893aa095c78156900ef11f68042aff83839 URL: https://github.com/llvm/llvm-project/commit/c0e3c893aa095c78156900ef11f68042aff83839 DIFF: https://github.com/llvm/llvm-project/commit/c0e3c893aa095c78156900ef11f68042aff83839.diff L

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc0e3c893aa09: [NFC][clangd] cleaning up llvm-qualified-auto (authored by kuhnel). Changed prior to commit: https://revi

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov updated this revision to Diff 402873. azabaznov added a comment. Add expected-no-diagnostics, fix misprint in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115640/new/ https://reviews.llvm.org/D115640 Files: clang/include/clang/B

[PATCH] D118016: [clang-tidy] Change code of SignalHandlerCheck (NFC).

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a commenting nit. Thanks! Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:136 + if (CG.size() <= 1) { +// Call gra

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov marked an inline comment as done. azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/storageclass.cl:2 // RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only -cl-std=CL1.2 -// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only -cl-std=CL3.0 -cl-ext=-__o

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

urnathan added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2681-2697 +// Variable used to not diagnose redundant default arguments +// from modules. +// +// [basic.def.odr]/13: +// There can be more than one definition of a +// ...

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

urnathan added a comment. Seems good to me, @iains you've been looking at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 ___ cfe-commits mailing list cfe

[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

tbaeder updated this revision to Diff 402874. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117295/new/ https://reviews.llvm.org/D117295 Files: clang/lib/Sema/SemaModule.cpp clang/test/Modules/cxx20-export.cpp Index: clang/test/Modules/cxx2

[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:650-652 +if (S.getLangOpts().CPlusPlus2b) { + if (BlockStart.isInvalid()) +diagExportedUnnamedDecl(S, *UDK, D, BlockStart); Chuanqi

[PATCH] D118120: [C++20] [Modules] Only check decls under namespace scope in CheckRedeclarationExported

urnathan accepted this revision. urnathan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:1643-1648 + if (!New->getLexicalDeclContext() + ->getNonTransparentContext() + ->isFileContext() || +

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

tbaeder added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2217 + /// The gloabl module fragment of the current tranlation unit. + clang::Module *GlobalModuleFragmentCache = nullptr; Typos in "gloabl" and "tranlation" in the comment. Any reaso

[PATCH] D118016: [clang-tidy] Change code of SignalHandlerCheck (NFC).

balazske updated this revision to Diff 402881. balazske marked an inline comment as done. balazske added a comment. Corrected a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118016/new/ https://reviews.llvm.org/D118016 Files: clang-tool

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

MarkMurrayARM added a comment. In D118044#3266521 , @DavidSpickett wrote: > Please define what "complex" is, in the commit message and (if it doesn't > make the description a whole paragraph) the command line help. > > Given that we're flipping a defaul

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

tyb0807 marked an inline comment as done. tyb0807 added inline comments. Comment at: clang/test/CodeGen/aarch64-mops.c:3 + +// RUN: %clang_cc1 -triple aarch64-arm-unknown-eabi -target-feature +mops -S -emit-llvm -o - %s | FileCheck %s + SjoerdMeijer wrote: > I

[PATCH] D117137: [Driver] Add CUDA support for --offload param

yaxunl added a comment. In D117137#3268548 , @linjamaki wrote: > SPIR-V target requires that the OS and the environment type is unknown (see > TargetInfo::AllocateTarget and BaseSPIRTargetInfo). The clang would fail to > create a SPIR-V target if there

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some small nits. Comment at: clang/include/clang/Basic/AttrDocs.td:415 + let Content = [{ +SYCL defines some special classes (accessor, sampler and stream) which require +specific handling dur

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

khchen added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vscale-range.ll:162 + +attributes #0 = { vscale_range(2,1024) } +attributes #1 = { vscale_range(4,1024) } frasercrmck wrote: > khchen wrote: > > I'm thinking do we need to test zv

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

Naghasan accepted this revision. Naghasan added a comment. LGTM, thanks for the work CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang-tools-extra] f3314e3 - [clang-tidy] Pop Files only if FileChangeReason is ExitFile

Author: Jim Lin Date: 2022-01-25T22:46:12+08:00 New Revision: f3314e3747873fdf026a28742a30f372503baf32 URL: https://github.com/llvm/llvm-project/commit/f3314e3747873fdf026a28742a30f372503baf32 DIFF: https://github.com/llvm/llvm-project/commit/f3314e3747873fdf026a28742a30f372503baf32.diff LOG:

[PATCH] D116478: [clang-tidy] A semicolon-separated list of the names of functions or methods to be considered as not having side-effects

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit in the documentation. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:161 + check now supports an ``IgnoredFunctions`` option to expl

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

nemanjai added a comment. It is probably not worth the effort since there won't be that many test cases that test the front end's IR generation for `long double`, but there should be a way to set up lit to know the default through its configuration files. Repository: rG LLVM Github Monorepo

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

nemanjai added inline comments. Comment at: clang/CMakeLists.txt:240 +set(ENABLE_PPC_IEEELONGDOUBLE OFF CACHE BOOL +"Enable IEEE binary128 as default long double format on PowerPC.") Do we need any error checking here? What happens if someone erroneously se

[clang-tools-extra] 9d8c3ad - [clang-tidy] Change code of SignalHandlerCheck (NFC).

Author: Balázs Kéri Date: 2022-01-25T15:52:38+01:00 New Revision: 9d8c3ad94fad5dd5fb511af89c9e7c3679922ce0 URL: https://github.com/llvm/llvm-project/commit/9d8c3ad94fad5dd5fb511af89c9e7c3679922ce0 DIFF: https://github.com/llvm/llvm-project/commit/9d8c3ad94fad5dd5fb511af89c9e7c3679922ce0.diff L

[PATCH] D118016: [clang-tidy] Change code of SignalHandlerCheck (NFC).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d8c3ad94fad: [clang-tidy] Change code of SignalHandlerCheck (NFC). (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:432 if (EnableTrapOptimization && TrapOpt) { +bool IsVReg = +(MI.getNumOperands() && MI.getOperand(0).isReg()) Might be good to pull out `MI.getOperand(0)

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 402900. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h clan

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam added a comment. Thanks for the reviews. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

ro added a comment. One test `FAILs` on Solaris/sparcv9: LLVM :: CodeGen/Generic/ForceStackAlign.ll with LLVM ERROR: Function "g" required stack re-alignment, but LLVM couldn't handle it (probably because it has a dynamic alloca). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel updated this revision to Diff 402910. ymandel added a comment. extended list of pointer-like types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116377/new/ https://reviews.llvm.org/D116377 Files: clang/include/clang/Tooling/Transformer/

[PATCH] D118150: [clang] Fix serialized diagnostics edge-cases

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Clang frontend sometimes fails on the following assertion when launched wit

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (PR53360)

xbolva00 added a comment. Aiming this fix for LLVM 14.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117965/new/ https://reviews.llvm.org/D117965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118150: [clang] Fix serialized diagnostics edge-cases

jansvoboda11 added inline comments. Comment at: clang/test/Misc/serialized-diags-emit-header-module-misconfig.c:2 +// RUN: rm -rf %t && mkdir %t +// RUN: not %clang_cc1 -emit-header-module %s -o %t/out.pcm -serialize-diagnostic-file %t/diag 2>&1 | FileCheck %s +

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:257-265 invocation = [args.clang_tidy_binary, '-list-checks'] if args.allow_enabling_alpha_checkers: invocation.append('-allow-enabling-analyzer-alpha-checkers')

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118152 Files: clang/test/ClangScanDeps/headerwithdirname.cpp clang/test/ClangSc

[PATCH] D118153: [CUDA][HIP] Do not treat host var address as constant in device compilation

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently clang treats host var address as constant in device compilation, which causes const vars initialized with host var address promoted to device variables incorrectly and results in undefin

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

jhuber6 updated this revision to Diff 402925. jhuber6 added a comment. Squash other uncommitted changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117048/new/ https://reviews.llvm.org/D117048 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.c

[PATCH] D118153: [CUDA][HIP] Do not treat host var address as constant in device compilation

yaxunl updated this revision to Diff 402924. yaxunl added a comment. fix test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118153/new/ https://reviews.llvm.org/D118153 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCUDA/const-var.cu clang/test/SemaCUDA/const-var.cu Ind

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

jhuber6 updated this revision to Diff 402926. jhuber6 added a comment. Rework commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117049/new/ https://reviews.llvm.org/D117049 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/i

[PATCH] D117156: [OpenMP] Add extra flag handling to linker wrapper

jhuber6 updated this revision to Diff 402928. jhuber6 added a comment. Rework commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117156/new/ https://reviews.llvm.org/D117156 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tools/clang-lin

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

jhuber6 updated this revision to Diff 402929. jhuber6 added a comment. Update commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117246/new/ https://reviews.llvm.org/D117246 Files: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp In

[clang] 0e5ea40 - Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT

Author: Ben Langmuir Date: 2022-01-25T08:27:40-08:00 New Revision: 0e5ea403e8deeb5374a9072aaa12292b9c0bed30 URL: https://github.com/llvm/llvm-project/commit/0e5ea403e8deeb5374a9072aaa12292b9c0bed30 DIFF: https://github.com/llvm/llvm-project/commit/0e5ea403e8deeb5374a9072aaa12292b9c0bed30.diff

[PATCH] D118087: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e5ea403e8de: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D118155: [OpenMP] Improve symbol resolution for OpenMP Offloading LTO

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, saiislam. Herald added subscribers: guansong, inglorion, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch improv

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

bwyma added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:812-814 + // CodeView types with C++ mangling need a type identifier. + if (CGM.getCodeGenOpts().EmitCodeView) +return true; dblaikie wrote: > rnk wrote: > > rnk wrote: > > > dblaikie wrot

[clang] 64ba462 - [clang][dataflow] Add a transfer function for InitListExpr

Author: Stanislav Gatev Date: 2022-01-25T16:28:15Z New Revision: 64ba462b6e398bdb33464963f7d6274320f84370 URL: https://github.com/llvm/llvm-project/commit/64ba462b6e398bdb33464963f7d6274320f84370 DIFF: https://github.com/llvm/llvm-project/commit/64ba462b6e398bdb33464963f7d6274320f84370.diff LO

[PATCH] D118119: [clang][dataflow] Add a transfer function for InitListExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64ba462b6e39: [clang][dataflow] Add a transfer function for InitListExpr (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

jsji added a comment. In D118110#3269450 , @nemanjai wrote: > It is probably not worth the effort since there won't be that many test cases > that test the front end's IR generation for `long double`, but there should > be a way to set up lit to know th

[PATCH] D117647: [RISCV] Add passthru operand for RVV nomask load intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117647/new/ https://reviews.llvm.org/D117647 ___

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/headerwithdirname.cpp:16 -// CHECK: headerwithdirname_input.o +// CHECK: headerwithdirname_input{{.*}}{{.o|.s}} // CHECK-NEXT: headerwithdirname_input.cpp Why is `{{.*}}` necessary? Rep

[PATCH] D117681: [RISCV] Add the policy operand for some masked RVV ternary IR intrinsics.

craig.topper added inline comments. Herald added a subscriber: pcwang-thead. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2342 defm _VS : VPseudoTernary, - Sched<[WriteVIRedV, ReadVIRedV, ReadVIRedV, ReadVIRedV, ReadVMask]>; + Sche

[PATCH] D118158: [OpenCL] opencl-c.h: refactor named addrspace builtins

svenvh created this revision. svenvh added a reviewer: clang. Herald added subscribers: Naghasan, ldrumm, Anastasia, yaxunl. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The named address space overloads of builtins that take a po

[PATCH] D117913: [Clang][RISCV] Guard vmulh, vsmul correctly

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117913/new/ https://reviews.llvm.org/D117913 ___ cfe-commits mailing list cfe-commits

[PATCH] D118109: [clang] Replace `std::vector` use in Syntax

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118109/new/ https://reviews.llvm.org/D118109

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

dblaikie added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:812-814 + // CodeView types with C++ mangling need a type identifier. + if (CGM.getCodeGenOpts().EmitCodeView) +return true; bwyma wrote: > dblaikie wrote: > > rnk wrote: > > > rnk wrot

[clang] bd1fac2 - Add assert on End iteration distance to Rewriter::getRewrittenText.

Author: Ashley Hedberg Date: 2022-01-25T17:26:13Z New Revision: bd1fac2fafd7a1afacce05cd53a3741a2214f5f1 URL: https://github.com/llvm/llvm-project/commit/bd1fac2fafd7a1afacce05cd53a3741a2214f5f1 DIFF: https://github.com/llvm/llvm-project/commit/bd1fac2fafd7a1afacce05cd53a3741a2214f5f1.diff LOG

[PATCH] D117579: Add assert on End iteration distance to Rewriter::getRewrittenText.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1fac2fafd7: Add assert on End iteration distance to Rewriter::getRewrittenText. (authored by ahedberg, committed by ymandel). Repository: rG LLV

[PATCH] D118161: [CMake] Set sanitizer test C++ library on Linux

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added subscribers: abrachet, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We always want to use the in-tree libc++ for tests. Repository:

  1   2   3   >