tbaeder marked 2 inline comments as done.
tbaeder added inline comments.
================
Comment at: clang/lib/Sema/SemaModule.cpp:650-652
+ if (S.getLangOpts().CPlusPlus2b) {
+ if (BlockStart.isInvalid())
+ diagExportedUnnamedDecl(S, *UDK, D, BlockStart);
----------------
ChuanqiXu wrote:
> tbaeder wrote:
> > ChuanqiXu wrote:
> > > Should we add a cite to P1766R1 here?
> > I wanted to do that, but I'm not 100% sure how. P1766R1 doesn't seem to
> > change any wording for this change. What exactly do I cite?
> I am not sure about the standard method. But I guess it might not be bad to
> write something like:
> ```
> // P1766R1 removed the rule that a declaration in an export block introduces
> at least one name. The rule for the single-declaration form of export is
> retained.
> // FIXME: Cite for labels when it shows in the draft.
> ```
>
> BTW, you could send a pull request or an issue at:
> https://github.com/cplusplus/draft to do the change. Since P1766R1 is
> adopted, so this change should be editorial.
Thanks, I added a comment and opened
https://github.com/cplusplus/draft/issues/5237
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117295/new/
https://reviews.llvm.org/D117295
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
