amyk added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:432
if (EnableTrapOptimization && TrapOpt) {
+ bool IsVReg =
+ (MI.getNumOperands() && MI.getOperand(0).isReg())
----------------
Might be good to pull out `MI.getOperand(0).isReg()` into a separate variable
since you're using it three times here.
================
Comment at: llvm/test/CodeGen/PowerPC/mi-peephole-trap-opt-dominated-block.mir:1
+# RUN: llc -mtriple powerpc64le-unknown-linux-gnu -mcpu=pwr8 -x mir < %s \
+# RUN: -verify-machineinstrs -start-before=ppc-mi-peepholes \
----------------
Question: are AIX run lines necessary, too?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117355/new/
https://reviews.llvm.org/D117355
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
