dberris requested changes to this revision. dberris added a comment. This revision now requires changes to proceed.
It looks like you'll need to address the lint issues (using clang-format). I'm not an expert on RISCV assembly so you might need to get someone familiar with the ISA reviewing this too. For tests, I recommend also adding some for the tooling that consumes the sections of the binary where we expect metadata that XRay expects to be present. You should be able to re-use/extend some of the tests we already have for those to see the end-to-end result (compiling and linking a binary which has Xray instrumentation sleds and associated maps). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117929/new/ https://reviews.llvm.org/D117929 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
