[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: alexfh. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, arphaman, kbarton, xazax.hun, mgorny, nemanjai. LegalizeAdulthood requested review of this revision. IncluderClangTid

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

ymandel added a comment. Thanks for looping me in. I'll try to take a detailed look later today. In the meantime, I'll note that we have something similar internally which I never got around to upstreaming. However, we chose to support arbitrarily many matchers, with this interface: const cl

[PATCH] D114823: Filter string_view from the nullptr diagnosis of bugprone-string-constructor to prevent duplicate warnings with bugprone-stringview-nullptr

CJ-Johnson updated this revision to Diff 399370. CJ-Johnson added a comment. Only filter out basic_string_view when bugprone-stringview-nullptr is enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114823/new/ https://reviews.llvm.org/D114823 F

[PATCH] D114823: Filter string_view from the nullptr diagnosis of bugprone-string-constructor to prevent duplicate warnings with bugprone-stringview-nullptr

CJ-Johnson added a comment. In D114823#3229990 , @njames93 wrote: > I'm in 2 minds about this. This diagnostic is a good fit for this warning and > shouldn't be removed. Likewise duplicate diagnostics from different checks is > annoying. Maybe a better

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

jhuber6 updated this revision to Diff 399373. jhuber6 added a comment. Update approach, improve LTO file handling for multiple outputs and don't change the LTO config. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117049/new/ https://reviews.llvm.

[clang] 6e77ad1 - Add an assert in cpudispatch emit to try to track down an error.

Author: Erich Keane Date: 2022-01-12T10:31:28-08:00 New Revision: 6e77ad11ffab71fa71629fe4df0af1ecefcfa649 URL: https://github.com/llvm/llvm-project/commit/6e77ad11ffab71fa71629fe4df0af1ecefcfa649 DIFF: https://github.com/llvm/llvm-project/commit/6e77ad11ffab71fa71629fe4df0af1ecefcfa649.diff L

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson updated this revision to Diff 399376. CJ-Johnson added a comment. Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.llvm.org/D115121 Files: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp

[PATCH] D117130: [RISCV] Move Zba/Zbb/Zbc/Zbs out of experimental since they have been ratified.

craig.topper created this revision. craig.topper added reviewers: asb, luismarques, jrtc27, evandro. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, StephenFan, vkmr, frasercrmck, jdoerfert, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman updated this revision to Diff 399383. aaron.ballman added a comment. Reworked a different way -- expose the signed versions of the width macros rather than the unsigned versions or both versions. Note, `__UINTPTR_WIDTH__` and `__UINTMAX_WIDTH__` were both preexisting macros, so I d

[PATCH] D117131: [RISCV] Update recently ratified Zb{a,b,c,s} extensions to no longer be experimental

asb created this revision. asb added reviewers: craig.topper, luismarques. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, StephenFan, vkmr, frasercrmck, jdoerfert, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Marti

[PATCH] D117130: [RISCV] Move Zba/Zbb/Zbc/Zbs out of experimental since they have been ratified.

asb added a comment. Doh - looks like we had the same idea at the same time :) D117131 . I've not done a full diff, but one thing I spotted was that the RISCVInstrInfoZb.td header needs updating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117130: [RISCV] Move Zba/Zbb/Zbc/Zbs out of experimental since they have been ratified.

craig.topper abandoned this revision. craig.topper added a comment. Abandoning in favor of D117131 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117130/new/ https://reviews.llvm.org/D117130 __

[PATCH] D117131: [RISCV] Update recently ratified Zb{a,b,c,s} extensions to no longer be experimental

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117131/new/ https://reviews.llvm.org/D117131 ___

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added a comment. Sorry for the delay. > This change seems like it's done in the wrong layer -- why do we add a > special-case in Clang to emit "={r11},{r11}", instead of fixing LLVM to not > break when given the previously-output "={r11},0"? We were starting out with a test case that was

[PATCH] D117123: [clang][dataflow] Add transfer functions for initializers

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:171 + +Value *InitExprVal = Env.getValue(*InitExpr, SkipPast::None); +if (InitExprVal == nullptr)

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

efriedma added a comment. Not sure I agree with the "fix" to the lld tests. If the linker is crashing, clearly there's a bug, not just an incorrect test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

rnk added a comment. Right, the auto-upgrade should upgrade and prevent the need to change the bitcode data layout. LTO is the main use case for auto-upgrading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D11

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

tyb0807 marked 2 inline comments as done. tyb0807 added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:666-675 + HasHBC |= ArchKind == llvm::AArch64::ArchKind::ARMV8_8A || +ArchKind == llvm::AArch64::ArchKind::ARMV9_3A; + + // Check features that a

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

futuarmo updated this revision to Diff 399394. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859 Files: clang/lib/Format/ContinuationIndenter.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unitt

[clang] 33d008b - [RISCV] Update recently ratified Zb{a,b,c,s} extensions to no longer be experimental

Author: Alex Bradbury Date: 2022-01-12T19:33:44Z New Revision: 33d008b169f3c813a4a45da220d0952f795ac477 URL: https://github.com/llvm/llvm-project/commit/33d008b169f3c813a4a45da220d0952f795ac477 DIFF: https://github.com/llvm/llvm-project/commit/33d008b169f3c813a4a45da220d0952f795ac477.diff LOG:

[PATCH] D117131: [RISCV] Update recently ratified Zb{a,b,c,s} extensions to no longer be experimental

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33d008b169f3: [RISCV] Update recently ratified Zb{a,b,c,s} extensions to no longer be… (authored by asb). Repository: rG LLVM Github Monorepo CHA

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. If the pre merge checks pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859 ___

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

futuarmo added a comment. Yes. Looks like I understood wrong how pre-merge clang-format check works, thanks everyone for help Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859 _

[PATCH] D117137: [Driver] Add a flag cuda-device-triple

dcastagna created this revision. Herald added subscribers: dang, yaxunl. dcastagna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This CL adds a flag "cuda-device-triple" to clang driver that can be used to override the triple passed to th

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3059 + /// and ``while``) in C++ according to the LLVM coding style. + /// \warning + /// This option will be renamed and expanded to support other styles! This should b

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 399415. lichray added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/

[PATCH] D117137: [Driver] Add a flag cuda-device-triple

tra added a comment. I think instead of setting the triple directly from the command line, we should start with adding another `--cuda-gpu-arch` (AKA --offload-arch) variant and derive the triple and other parameters from it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/24784. With config: AllowS

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:687 // TODO: This has been removed in later specs, which specify that D implies F if (HasD && !HasF) return createStringError(errc::invalid_argument, Do we need the equiv

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius added a comment. Still WIP but I'd like to have some feedback. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:283 + + // FIXME: Use IndentTracker to avoid loop? + // Find the last line with lower level. Because of thi

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:278 +// Just checking TheLine->Level != 0 is not enough, because it +// provokes treating functions inside intended namespaces as short. +if ((*I)->Level !=

[PATCH] D116425: [clang-tidy] Improve modernize-redundant-void-arg to recognize macro uses

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116425/new/ https://reviews.llvm.org/D116425 ___ cfe-commits mai

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

curdeius accepted this revision. curdeius added a comment. LGTM. Thanks for working on this! But before landing, please retest the original misformatted code from the bug report with a freshly built clang-format. Also, do you have commit rights? If not, do you want someone to land it on your be

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

LegalizeAdulthood added a comment. In D116518#3237927 , @ymandel wrote: > [...] In the meantime, I'll note that we have something similar internally > which I never got around to upstreaming. That's very interesting and is certainly more general than wha

[clang-tools-extra] fff59f4 - [clang-tidy] Improve modernize-redundant-void-arg to recognize macro uses

Author: Richard Date: 2022-01-12T13:51:50-07:00 New Revision: fff59f48173dc2f2a3ce867fa0c7836b23214110 URL: https://github.com/llvm/llvm-project/commit/fff59f48173dc2f2a3ce867fa0c7836b23214110 DIFF: https://github.com/llvm/llvm-project/commit/fff59f48173dc2f2a3ce867fa0c7836b23214110.diff LOG:

[PATCH] D116425: [clang-tidy] Improve modernize-redundant-void-arg to recognize macro uses

This revision was automatically updated to reflect the committed changes. Closed by commit rGfff59f48173d: [clang-tidy] Improve modernize-redundant-void-arg to recognize macro uses (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D117093: [C++20] [Modules] Exit early if export decl is invalid

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:530-531 + CurContext->addDecl(D); + PushDeclContext(S, D); + Am I understanding properly that this moved up here so that the for loop on line 553 can traverse the new context? If

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

futuarmo added a comment. I will build fresh main branch tomorrow (it tooks 1+ hour) and will comment here about test results I don't have commit rights, so it will be great if someone commit it with user "Armen Khachkinaev" and email "armen...@yandex.ru" Thanks Repository: rG LLVM Github Mo

[PATCH] D117078: Minor adjustment in order of noundef analysis to be a bit more optimal (when disabled).

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. my editor recommends me to keep git titles <50 chars Maybe something shorter with exactly the same meaning "[NFC] Optimize noundef analysis condition" Comment at: cla

[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

ymandel added a comment. Overall, this change looks good and makes sense. But, it doesn't scale past 1 feature, which makes me a bit hesitant. I don't have another example offhand, but include-inserter is an arbitrary feature and I don't love conflating feature addition with the class hierarchy

[clang] d102197 - Omit "clang" from CHECK lines.

Author: James Y Knight Date: 2022-01-12T21:18:52Z New Revision: d1021978b8e7e35dcc30201ca1731d64b5a602a8 URL: https://github.com/llvm/llvm-project/commit/d1021978b8e7e35dcc30201ca1731d64b5a602a8 DIFF: https://github.com/llvm/llvm-project/commit/d1021978b8e7e35dcc30201ca1731d64b5a602a8.diff LOG

[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

LegalizeAdulthood added a comment. In D117129#3238433 , @ymandel wrote: > Overall, this change looks good and makes sense. But, it doesn't scale past 1 > feature > [...] Might there be some other way to get the benefits of saving > implementers the > cu

[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

LegalizeAdulthood added a comment. Another option would be to migrate this to `ClangTidyCheck` itself and add a flag/option passed to the ClangTidyCheck c'tor to opt-in to the feature? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117129/new/ https

[PATCH] D117078: [NFC] Minimize noundef analysis when disabled

kda updated this revision to Diff 399432. kda marked an inline comment as done. kda added a comment. reduce nesting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117078/new/ https://reviews.llvm.org/D117078 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D117078: [NFC] Minimize noundef analysis when disabled

kda added a comment. In D117078#3238422 , @vitalybuka wrote: > my editor recommends me to keep git titles <50 chars > Maybe something shorter with exactly the same meaning > "[NFC] Optimize noundef analysis condition" Done! Repository: rG LLVM Githu

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 399433. lichray added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/Pr

[PATCH] D117123: [clang][dataflow] Add transfer functions for initializers

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:171 + +Value *InitExprVal = Env.getValue(*InitExpr, SkipPast::None); +if (InitExprVal == nullptr) ymandel wrote: > why `None`?

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Bravo! This is an impressively thorough job. Thanks for pushing through to completion! Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:263 +

[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

ymandel added a comment. In D117129#3238441 , @LegalizeAdulthood wrote: > Another option would be to migrate this to `ClangTidyCheck` itself > and add a flag/option passed to the ClangTidyCheck c'tor to opt-in > to the feature? Right, I was wondering ab

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson updated this revision to Diff 399436. CJ-Johnson marked an inline comment as done. CJ-Johnson added a comment. Add code comment about the choice of hasAnyArgument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

CJ-Johnson added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:263 + auto HandleConstructorInvocation = + makeRule(cxxConstructExpr(hasAnyArgument(ignoringImpCasts( +BasicStringViewConstruct

[clang] 963f400 - [clang][dataflow] Add transfer functions for initializers

Author: Stanislav Gatev Date: 2022-01-12T21:51:39Z New Revision: 963f40051a4216936b47dad56765d60b64b7840d URL: https://github.com/llvm/llvm-project/commit/963f40051a4216936b47dad56765d60b64b7840d DIFF: https://github.com/llvm/llvm-project/commit/963f40051a4216936b47dad56765d60b64b7840d.diff LO

[PATCH] D117123: [clang][dataflow] Add transfer functions for initializers

This revision was automatically updated to reflect the committed changes. sgatev marked an inline comment as done. Closed by commit rG963f40051a42: [clang][dataflow] Add transfer functions for initializers (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:263 + auto HandleConstructorInvocation = + makeRule(cxxConstructExpr(hasAnyArgument(ignoringImpCasts( +BasicStringViewConstructing

[clang-tools-extra] 7e29da8 - Add support for return values in bugprone-stringview-nullptr

Author: CJ Johnson Date: 2022-01-12T16:53:13-05:00 New Revision: 7e29da875ca95cd916e7ce6668fa85b638c3bd5f URL: https://github.com/llvm/llvm-project/commit/7e29da875ca95cd916e7ce6668fa85b638c3bd5f DIFF: https://github.com/llvm/llvm-project/commit/7e29da875ca95cd916e7ce6668fa85b638c3bd5f.diff LO

[PATCH] D115121: Update bugprone-stringview-nullptr to support return statements and constructors for any T which accepts basic_string_view

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e29da875ca9: Add support for return values in bugprone-stringview-nullptr (authored by CJ-Johnson). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 81c330e - Filter string_view from the nullptr diagnosis of bugprone-string-constructor to prevent duplicate warnings with bugprone-stringview-nullptr

Author: CJ Johnson Date: 2022-01-12T17:04:44-05:00 New Revision: 81c330e23dd4a14736b977e246bdca25be9b5770 URL: https://github.com/llvm/llvm-project/commit/81c330e23dd4a14736b977e246bdca25be9b5770 DIFF: https://github.com/llvm/llvm-project/commit/81c330e23dd4a14736b977e246bdca25be9b5770.diff LO

[PATCH] D114823: Filter string_view from the nullptr diagnosis of bugprone-string-constructor to prevent duplicate warnings with bugprone-stringview-nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit rG81c330e23dd4: Filter string_view from the nullptr diagnosis of bugprone-string-constructor to… (authored by CJ-Johnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 2db4cf5 - clang support for Armv8.8/9.3 HBC

Author: Tomas Matheson Date: 2022-01-12T22:07:35Z New Revision: 2db4cf5962ded48c7a5c3ec3c6051f64c8e7e376 URL: https://github.com/llvm/llvm-project/commit/2db4cf5962ded48c7a5c3ec3c6051f64c8e7e376 DIFF: https://github.com/llvm/llvm-project/commit/2db4cf5962ded48c7a5c3ec3c6051f64c8e7e376.diff LOG

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tyb0807 marked an inline comment as done. Closed by commit rG2db4cf5962de: clang support for Armv8.8/9.3 HBC (authored by tmatheson, committed by tyb0807). Repository:

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

jhuber6 updated this revision to Diff 399460. jhuber6 added a comment. Forgot to use hook. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117049/new/ https://reviews.llvm.org/D117049 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td cla

[PATCH] D117156: [OpenMP] Add extra flag handling to linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds support for a few extr

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

rsmith added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:288 + /// template parameters, no matter how many elements there are. + unsigned EntireContentsOfLargeArray : 1; + lichray wrote: > rsmith wrote: > > It looks like nothing is sett

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews updated this revision to Diff 399484. eandrews added a comment. Herald added a subscriber: Jim. Implemented review comments - Remove unnecessary set method and set default value during construction instead - Changed default address space for function pointer for avr target to 1. CHANG

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 ___

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added inline comments. Comment at: clang/test/CodeGen/avr/functionptr-addrspace.c:3 + +int main() { + int (*p)(); When writing the test I noticed an existing crash in the compiler. I am not sure if I am doing something wrong but if you try to assign to

[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

njames93 added a comment. In D117129#3238441 , @LegalizeAdulthood wrote: > Another option would be to migrate this to `ClangTidyCheck` itself > and add a flag/option passed to the ClangTidyCheck c'tor to opt-in > to the feature? I feel that this directi

[PATCH] D117137: [Driver] Add a flag cuda-device-triple

jlebar added a comment. I defer to Art. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117137/new/ https://reviews.llvm.org/D117137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D116983: Clone constructor template parameters when creating deduction guide

aeubanks created this revision. rsmith added inline comments. aeubanks published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comment at: clang/lib/Sema/SemaTemplate.cpp:2174 + Args.addOuterTemplateArguments(SubstArgs); +

[PATCH] D116983: Clone constructor template parameters when creating deduction guide

aeubanks updated this revision to Diff 399514. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116983/new/ https://reviews.llvm.org/D116983 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/Modules/Inputs/ctad/a.

[PATCH] D116983: Clone constructor template parameters when creating deduction guide

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2174 + Args.addOuterTemplateArguments(SubstArgs); + Args.addOuterRetainedLevel(); + NamedDecl *NewParam = transformTemplateParameter(Param, Args); rsmith wrote: > This oute

[clang] a141e47 - [NFC] Minimize noundef analysis when disabled

Author: Kevin Athey Date: 2022-01-12T17:21:19-08:00 New Revision: a141e47138505f4ba1d3e716c7ce2d59767d8cf7 URL: https://github.com/llvm/llvm-project/commit/a141e47138505f4ba1d3e716c7ce2d59767d8cf7 DIFF: https://github.com/llvm/llvm-project/commit/a141e47138505f4ba1d3e716c7ce2d59767d8cf7.diff L

[PATCH] D117078: [NFC] Minimize noundef analysis when disabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa141e4713850: [NFC] Minimize noundef analysis when disabled (authored by kda). Changed prior to commit: https://reviews.llvm.org/D117078?vs=399432

[PATCH] D114966: [clang][deps] Split stat and file content caches

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Okay, I think this is the last round. Everything looks correct, except a few out-of-date comments. Two things, one small, one bigger (but not too big I think). Smaller one i

[PATCH] D117177: [NFC][DFSan] Update DataFlowSanitizer user docs for -dfsan-conditional-callbacks, added in https://reviews.llvm.org/D116207

browneee created this revision. browneee added a reviewer: morehouse. browneee requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117177 Files: clang/docs/DataFlowSanitizer.rs

[PATCH] D111566: [SYCL] Fix function pointer address space

rjmccall accepted this revision. rjmccall added a comment. LGTM, thanks! Comment at: clang/test/CodeGen/avr/functionptr-addrspace.c:3 + +int main() { + int (*p)(); eandrews wrote: > When writing the test I noticed an existing crash in the compiler. I am not >

[PATCH] D117093: [C++20] [Modules] Exit early if export decl is invalid

ChuanqiXu updated this revision to Diff 399526. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117093/new/ https://reviews.llvm.org/D117093 Files: clang/lib/Sema/SemaModule.cpp clang/test/Modules/export-in-non-modules.cpp Index: clang/t

[PATCH] D117093: [C++20] [Modules] Exit early if export decl is invalid

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:530-531 + CurContext->addDecl(D); + PushDeclContext(S, D); + aaron.ballman wrote: > Am I understanding properly that this moved up here so that the for loop on > line 553 can traverse

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei added a comment. I see, I will investigate the reason and do a follow up. Thanks @efriedma and @rnk ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942 _

[PATCH] D116983: Clone constructor template parameters when creating deduction guide

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2174 + Args.addOuterTemplateArguments(SubstArgs); + Args.addOuterRetainedLevel(); + NamedDecl *NewParam = transformTemplateParameter(Param, Args); aeubanks wrote: > rsmith wr

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 399527. achieveartificialintelligence marked 3 inline comments as done. achieveartificialintelligence added a comment. Address @craig.topper's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 16877c5 - [RISCV] Add bfp and bfpw intrinsic in zbf extension

Author: Lian Wang Date: 2022-01-13T02:53:00Z New Revision: 16877c5d2cd3f5c45642c9dc546c376ac87aa54d URL: https://github.com/llvm/llvm-project/commit/16877c5d2cd3f5c45642c9dc546c376ac87aa54d DIFF: https://github.com/llvm/llvm-project/commit/16877c5d2cd3f5c45642c9dc546c376ac87aa54d.diff LOG: [RI

[PATCH] D116994: [RISCV] Add bfp and bfpw intrinsic in zbf extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16877c5d2cd3: [RISCV] Add bfp and bfpw intrinsic in zbf extension (authored by Lian Wang , committed by benshi001).

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu added a comment. Here is my thought: - Should we warn for this situation? Yes, on the on hand, it behaves differently with normal users imaged. A assistant reason would be that GCC would warn for the case too. - Is the warning message good? I think it at least not worse than what GCC

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf updated this revision to Diff 399536. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/PPCLinux.cpp clang/lib

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

qiucf created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In toolchains with proper support for IEEE float128, we can switch default long double semantics to it

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:3059 + /// and ``while``) in C++ according to the LLVM coding style. + /// \warning + /// This option will be renamed and expanded to support other styles! HazardyKnusperkeks wrote

[PATCH] D116843: [Driver][Gnu] -r: imply -nostdlib like GCC

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. Looks good, although the documentation for `-r` and other driver options could be better (not your fault though). From https://gcc.gnu.org/onlinedocs/gcc/Link-Options.html: -r

[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

LegalizeAdulthood added a comment. In D117129#3239143 , @njames93 wrote: > My proposed idea was putting the `IncludeInserter` instance > inside the `ClangTidyContext`, but then only registering it if > any checks actually want to use it. Use of the `Incl

[clang] 728c77d - [Sema] Fix a bugprone argument comment (NFC)

Author: Kazu Hirata Date: 2022-01-12T22:11:59-08:00 New Revision: 728c77dbb352aa66fede50b41c24cb4e0a44e52e URL: https://github.com/llvm/llvm-project/commit/728c77dbb352aa66fede50b41c24cb4e0a44e52e DIFF: https://github.com/llvm/llvm-project/commit/728c77dbb352aa66fede50b41c24cb4e0a44e52e.diff L

[clang] cb7f806 - [clang] Remove redundant member initialization (NFC)

Author: Kazu Hirata Date: 2022-01-12T22:12:01-08:00 New Revision: cb7f806a3a74578afbb808aa71a19ec66d687c9f URL: https://github.com/llvm/llvm-project/commit/cb7f806a3a74578afbb808aa71a19ec66d687c9f DIFF: https://github.com/llvm/llvm-project/commit/cb7f806a3a74578afbb808aa71a19ec66d687c9f.diff L

[PATCH] D116736: [Clang] Add __builtin_reduce_or and __builtin_reduce_and

junaire added a comment. In D116736#3230040 , @fhahn wrote: > LGTM, thanks! > >> The last __builtin_reduce_add will be separated into another one. > > Are you planning on putting up a patch for this one as well? What makes add a > bit different is that `

[PATCH] D117185: [clangd] Ignore cvr-qualifiers in selection.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The AST doesn't track

[PATCH] D117185: [clangd] Ignore cvr-qualifiers in selection.

sammccall updated this revision to Diff 399551. sammccall added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117185/new/ https://reviews.llvm.org/D117185 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra/cla

[PATCH] D117107: [clangd] Elide even more checks in SelectionTree.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:206 + R"cpp( +#define TARGET void foo() +[[TAR^GET{ return; }]] This test isn't strictly related, but it failed with a buggy versio

[clang-tools-extra] d8716cd - [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers.

Author: Sam McCall Date: 2022-01-13T08:06:35+01:00 New Revision: d8716cd7d31c64a6aaa25d43569f1c00e553ab43 URL: https://github.com/llvm/llvm-project/commit/d8716cd7d31c64a6aaa25d43569f1c00e553ab43 DIFF: https://github.com/llvm/llvm-project/commit/d8716cd7d31c64a6aaa25d43569f1c00e553ab43.diff LO

[PATCH] D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8716cd7d31c: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] 9c9119a - [clangd] Extend SymbolOrigin, stop serializing it

Author: Sam McCall Date: 2022-01-13T08:26:12+01:00 New Revision: 9c9119ab364b0179af4a96a764f806d51878b37f URL: https://github.com/llvm/llvm-project/commit/9c9119ab364b0179af4a96a764f806d51878b37f DIFF: https://github.com/llvm/llvm-project/commit/9c9119ab364b0179af4a96a764f806d51878b37f.diff LO

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c9119ab364b: [clangd] Extend SymbolOrigin, stop serializing it (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D115243?vs=394538&id=399555#toc Repository: rG LLVM Github M

[PATCH] D117036: [clangd] Remove --inlay-hints flag

sammccall updated this revision to Diff 399556. sammccall retitled this revision from "[clangd] Retire --inlay-hints flag" to "[clangd] Remove --inlay-hints flag". sammccall added a comment. rename patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

<    1   2   3   >