[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 ___ cfe-commits mailing list cfe-commi

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377755. cor3ntin marked an inline comment as done. cor3ntin added a comment. - Modify ParseUsingDeclaration to only parse an alias in init statememts - Make the c++23 extebsion warning clearer - Nitpicks. The error is now 'expected '=', which seems good enou

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377756. cor3ntin added a comment. Update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75/new/ https://reviews.llvm.org/D75 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Bas

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:677 + SwapOpts(Res); + bool Success2 = Parse(Res, GeneratedArgs1, Diags); + saudi wrote: > jansvoboda11 wrote: > > saudi wrote: > > > Hello, > > > > > > I encountered cra

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

lebedev.ri added a comment. Question: should this really diagnose classes that are marked as `final`? Surely such a class can never be a base class? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102325/new/ https://reviews.llvm.org/D102325 ___

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm created this revision. hsmhsm added reviewers: rjmccall, tra, yaxunl, jdoerfert. hsmhsm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CodeGenFunction::InitTempAlloca() inits the static alloca within the entry block which may *not*

[clang] b7ac68d - [clang][ASTImporter] Simplify code of attribute import [NFC].

Author: Balázs Kéri Date: 2021-10-07T13:07:21+02:00 New Revision: b7ac68d01ef9a126ea0eb26b3526a78c9d39533a URL: https://github.com/llvm/llvm-project/commit/b7ac68d01ef9a126ea0eb26b3526a78c9d39533a DIFF: https://github.com/llvm/llvm-project/commit/b7ac68d01ef9a126ea0eb26b3526a78c9d39533a.diff L

[PATCH] D110810: [clang][ASTImporter] Simplify code of attribute import [NFC].

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7ac68d01ef9: [clang][ASTImporter] Simplify code of attribute import [NFC]. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/mac/36543/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.o

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

aaron.ballman added a comment. CI is currently broken, so there's a test here that needs updating: https://reviews.llvm.org/harbormaster/unit/view/1389113/ Also, this should have at least one SemaObjC test to demonstrate that we no longer diagnose this as an unknown attribute in that case. CH

[PATCH] D110934: [NFC] Update return type of vec_popcnt to vector unsigned.

kamaub added a comment. Yeah this LTGM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110934/new/ https://reviews.llvm.org/D110934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D110934: [NFC] Update return type of vec_popcnt to vector unsigned.

kamaub accepted this revision. kamaub added a comment. This revision is now accepted and ready to land. Yeah this LGTM as well, accidentally commented without accepting a moment before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110934/new/ htt

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam added a comment. In D105191#3047596 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/mac/36543/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for reporting. Taking a look. Repo

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

hans added a comment. Are there no tests for clang-format-diff.py? That seems unfortunate. Will this handle more nested cases, for example if the first line here is deleted, will we fix the indent of both "if (b)" and "c"? if (a) if (b) c; I worry that this might be a tricky proble

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

shchenz added a comment. Thanks for working on this. Could you please help to rerun the affected cases after applying D97184 ? That patch is approved and I will deliver it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D93543: clang-tidy: Add `-use-color` for `run-clang-tidy.py` in order to make it sane with `clang-tidy` coloring argument

simon.giesecke added a comment. I think this would be a useful change. In the current state, one needs to modify the script to run this in a context where coloring is not supported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93543/new/ https://

[PATCH] D111134: Add basic aarch64-none-elf bare metal driver.

kristof.beyls updated this revision to Diff 377816. kristof.beyls added a comment. Updated test based on feedback from @MaskRay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34/new/ https://reviews.llvm.org/D34 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/test/Dri

[PATCH] D111134: Add basic aarch64-none-elf bare metal driver.

kristof.beyls added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:133 + + if (Triple.getVendor() != llvm::Triple::UnknownVendor) +return false; MaskRay wrote: > Is vendor check necessary? I'm guessing that without the vendor check, t

[PATCH] D111134: Add basic aarch64-none-elf bare metal driver.

kristof.beyls updated this revision to Diff 377818. kristof.beyls added a comment. run clang-format on the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34/new/ https://reviews.llvm.org/D34 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/test/Driver/baremetal.

[PATCH] D106191: [clang] Option control afn flag

erichkeane added a comment. In D106191#3046757 , @lebedev.ri wrote: > Looks reasonable to me. > @aaron.ballman @erichkeane does it seem complete or are we missing some infra > piece? At least from the CFE's side I think this is complete as far as I can

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. It's been broken for a while now. Should we revert this for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 ___ cfe-commits mailing

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. Looks like the test is failing on Windows too: http://45.33.8.238/win/46512/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. Here's a failure on an official LLVM buildbot: https://lab.llvm.org/buildbot/#/builders/123/builds/6536 https://lab.llvm.org/buildbot/#/builders/123 has been red for over 8 hours now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

JonChesterfield added a comment. Blocking windows + osx for a couple of hours is bad, let's revert it. Will do so myself when I get to a desktop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 __

[PATCH] D111311: [Clang][OpenMP] Fix fat archive tests for Mac and Windows

saiislam created this revision. saiislam added reviewers: thakis, ye-luo. Herald added subscribers: kerbowa, guansong, yaxunl, nhaehnle, jvesely. saiislam requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam added a comment. In D105191#3047903 , @JonChesterfield wrote: > Blocking windows + osx for a couple of hours is bad, let's revert it. Will do > so myself when I get to a desktop Here is the fix: D111311 Pleas

[PATCH] D111311: [Clang][OpenMP] Fix fat archive tests for Mac and Windows

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111311/new/ https://reviews.llvm.org/D111311 ___

[PATCH] D111311: [Clang][OpenMP] Fix fat archive tests for Mac and Windows

JonChesterfield accepted this revision. JonChesterfield added a comment. Looks plausible to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111311/new/ https://reviews.llvm.org/D111311 ___ cfe-commits m

[PATCH] D111311: [Clang][OpenMP] Fix fat archive tests for Mac and Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2baf7ad6d27f: [Clang][OpenMP] Fix fat archive tests for Mac and Windows (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 2baf7ad - [Clang][OpenMP] Fix fat archive tests for Mac and Windows

Author: Saiyedul Islam Date: 2021-10-07T13:38:46Z New Revision: 2baf7ad6d27fc9c08dd6eb9f8581d7e1353d4ece URL: https://github.com/llvm/llvm-project/commit/2baf7ad6d27fc9c08dd6eb9f8581d7e1353d4ece DIFF: https://github.com/llvm/llvm-project/commit/2baf7ad6d27fc9c08dd6eb9f8581d7e1353d4ece.diff LOG

[PATCH] D110286: [WIP][Clang][OpenMP] Add new clang argument `-fopenmp-target-simd`

JonChesterfield added a comment. I'm excited about the thread to warp mapping but unclear why this needs to be a compile time flag. Can we use this mapping when pragma simd is present and otherwise stay with the current one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. Fix didn't help, still broken at least on Windows: http://45.33.8.238/win/46515/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam added a comment. In D105191#3047954 , @thakis wrote: > Fix didn't help, still broken at least on Windows: > http://45.33.8.238/win/46515/step_7.txt Ohk. Reverting this patch in a few minutes. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. Looks like the test looks for "ld" but Windows prints "\link.exe" -- maybe you need to pass an explicit triple to the compiler? Or relax the check line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://revi

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 _

[PATCH] D111250: [clang] Set max allowed alignment to 2^32

hans added a comment. Is there any codegen test we could update to check that a high alignment value makes it all the way through to the IR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111250/new/ https://reviews.llvm.org/D111250 __

[clang] 3eb44f4 - Revert "[Clang][OpenMP] Fix windows buildbot failure for D105191"

Author: Saiyedul Islam Date: 2021-10-07T14:13:24Z New Revision: 3eb44f4d28df3d9e9528b8b9f8f6b93ab4c2af67 URL: https://github.com/llvm/llvm-project/commit/3eb44f4d28df3d9e9528b8b9f8f6b93ab4c2af67 DIFF: https://github.com/llvm/llvm-project/commit/3eb44f4d28df3d9e9528b8b9f8f6b93ab4c2af67.diff LOG

[clang] 94e2b02 - Revert "[Clang][OpenMP] Add partial support for Static Device Libraries"

Author: Saiyedul Islam Date: 2021-10-07T14:13:24Z New Revision: 94e2b0258a176c7451dd8291cdf060ea048fee44 URL: https://github.com/llvm/llvm-project/commit/94e2b0258a176c7451dd8291cdf060ea048fee44 DIFF: https://github.com/llvm/llvm-project/commit/94e2b0258a176c7451dd8291cdf060ea048fee44.diff LOG

[clang] 1097f48 - Revert "[Clang][OpenMP] Fix fat archive tests for Mac and Windows"

Author: Saiyedul Islam Date: 2021-10-07T14:13:24Z New Revision: 1097f48e3dc3ab6811419f867350e79e280fb0eb URL: https://github.com/llvm/llvm-project/commit/1097f48e3dc3ab6811419f867350e79e280fb0eb DIFF: https://github.com/llvm/llvm-project/commit/1097f48e3dc3ab6811419f867350e79e280fb0eb.diff LOG

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 updated this revision to Diff 377845. jcking1034 added a comment. Update matchers reference page. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111242/new/ https://reviews.llvm.org/D111242 Files: clang/docs/LibASTMatchersReference.htm

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 updated this revision to Diff 377854. jcking1034 added a comment. Fix documentation for hasTemplateArgumentLoc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111242/new/ https://reviews.llvm.org/D111242 Files: clang/docs/LibASTMatcher

[PATCH] D111315: Workaround build error for mingw-g++

ldrumm created this revision. ldrumm added reviewers: v.g.vassilev, rsmith. ldrumm added a project: clang. Herald added a subscriber: mstorsjo. ldrumm requested review of this revision. Workaround build error for mingw-g++ mingw-g++ does not correctly support the full std::errc namespace

[PATCH] D93164: [AST] Add generator for source location introspection

lancethepants added a comment. In D93164#2653067 , @mgorny wrote: > This change breaks cross-compilation now, as it tries running an executable > built for the target system: > > FAILED: tools/clang/lib/Tooling/ASTNodeAPI.json > cd /home/mgorny/llvm-

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109740/new/ https://reviews.llvm.org/D109740 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm created this revision. hsmhsm added reviewers: rjmccall, tra, yaxunl, jdoerfert. hsmhsm requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Sequel patch to https://reviews.llvm.org/D111293. Remove call to CodeGenFunction::InitT

[PATCH] D111315: Workaround build error for mingw-g++

ldrumm updated this revision to Diff 377864. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111315/new/ https://reviews.llvm.org/D111315 Files: clang/lib/Interpreter/Interpreter.cpp Index: clang/lib/Interpreter/Interpreter.cpp ==

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

martong added a comment. @ASDenysPetrov Nice work! I really appreciate the hard work you guys (with @vsavchenko) had done here. I really like that you have created visible test cases (though the last ones are a bit cryptic for me). It is going to take some more time to finish my review.

[PATCH] D111242: Add `TypeLoc`-related matchers.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6361-6362 +/// \endcode +/// qualifiedTypeLoc(hasUnqualifiedLoc(pointerTypeLoc())) +/// matches the `TypeLoc` of the variable declaration of `x`, but not `y`. +AST_MATCHER_P(Qualified

[PATCH] D111283: [clang] WIP: template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 377867. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Sema/Sema.h

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This covers both C-st

[PATCH] D106191: [clang] Option control afn flag

aaron.ballman added a comment. Agreed on the request for description and driver test coverage. I'm also wondering if there should be a release note and documentation because it's lifting a private flag to be a public one. e.g., should we update https://clang.llvm.org/docs/UsersManual.html#contr

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

aaron.ballman added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:893 Builder.defineMacro("_GNU_SOURCE"); +Builder.defineMacro("FUCHSIA_API_LEVEL", Twine(Opts.FuchsiaAPILevel)); +this->PlatformName = "fuchsia"; haowei wrote: > ph

[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

svenvh added a comment. > For the constant address space, the const attribute (or readnone) can be > used. As memory in the constant address space is immutable, the statement in > the langref that: "if a readnone function reads or writes memory visible to > the program, or has other side-effect

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

Jake-Egan added a comment. In D69#3047761 , @shchenz wrote: > Thanks for working on this. > > Could you please help to rerun the affected cases after applying D97184 > ? That patch is approved and I will deliver > it

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 updated this revision to Diff 377885. jcking1034 added a comment. Actually fix documentation for `hasTemplateArgumentLoc`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111242/new/ https://reviews.llvm.org/D111242 Files: clang/docs/Li

[clang] 74b1ac7 - [NFC] Update return type of vec_popcnt to vector unsigned.

Author: Amy Kwan Date: 2021-10-07T11:33:19-05:00 New Revision: 74b1ac7155a01e5d29cff612717f773da095d696 URL: https://github.com/llvm/llvm-project/commit/74b1ac7155a01e5d29cff612717f773da095d696 DIFF: https://github.com/llvm/llvm-project/commit/74b1ac7155a01e5d29cff612717f773da095d696.diff LOG:

[PATCH] D110934: [NFC] Update return type of vec_popcnt to vector unsigned.

This revision was automatically updated to reflect the committed changes. Closed by commit rG74b1ac7155a0: [NFC] Update return type of vec_popcnt to vector unsigned. (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110934/new/ https

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:552-553 "extraneous ')' after condition, expected a statement">; +def ext_alias_in_init_statement : ExtWarn< + "alias declaration in this context is a C++2b extension">, + InGr

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added inline comments. Comment at: llvm/tools/llvm-config/llvm-config.cpp:361 +{ + SmallString<256> Path(StringRef(LLVM_INSTALL_INCLUDEDIR)); + sys::fs::make_absolute(ActivePrefix, Path); Ericson2314 wrote: > Ericson2314 wrote: > > compn

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf marked an inline comment as done. ricejasonf added a comment. In D108482#3047141 , @rjmccall wrote: > I assume we rebuild an AILE and OVE when we process the initializer and see > it's a structured binding? In that case, this should be fine.

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz updated this revision to Diff 377891. adamcz marked an inline comment as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110823/new/ https://reviews.llvm.org/D110823 Files: clang-tools

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1148 + std::set ParamNamesSeen; +}; // SignatureHelpCollector + kadircet wrote: > change the ending comment (well, I'd actually drop it completely) Oops, too much copy/paste. We

[PATCH] D111315: Workaround build error for mingw-g++

v.g.vassilev added a comment. Can you map `state_not_recoverable` to `not_supported`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111315/new/ https://reviews.llvm.org/D111315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra added a comment. In D110089#3047161 , @kgk wrote: > Will the new macros in this patch also be useful for supporting the > surface-related methods that also use __nv_tex_surf_handler (from > surface_indirect_functions.h)? > > I gave this new code a t

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:250 Context.hasSameType(X.getAsType(), Y.getAsType())) return X; mizvekov wrote: > rsmith wrote: > > I wonder if we can come up with a good heuristic for determ

[PATCH] D111187: [Clang] Add information about partially implemented features

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, I think this is a great idea! I'll start using it in the c_status page as well. Thanks! (I can clean up the formatting nits when I land, so don't feel obligated to fix thos

[PATCH] D110114: [OMPIRBuilder] Generate aggregate argument for parallel region outlined functions

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG. Can be merged once the requirement is in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110114/new/ https://reviews.llvm.org/D110114

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

hiraditya updated this revision to Diff 377895. hiraditya added a comment. Herald added a subscriber: jdoerfert. Added SemaObjc test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 Files: clang/include/clang/Basic/Attr.td clang/test/

[clang] d456fed - Add information about partially implemented features

Author: Corentin Jabot Date: 2021-10-07T13:07:44-04:00 New Revision: d456fed1a9feaa441847038d6adbb93ff3bf8f66 URL: https://github.com/llvm/llvm-project/commit/d456fed1a9feaa441847038d6adbb93ff3bf8f66 DIFF: https://github.com/llvm/llvm-project/commit/d456fed1a9feaa441847038d6adbb93ff3bf8f66.diff

[PATCH] D111187: [Clang] Add information about partially implemented features

aaron.ballman closed this revision. aaron.ballman added a comment. I've committed on your behalf in d456fed1a9feaa441847038d6adbb93ff3bf8f66 , thanks for the improvement! Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377900. vitalybuka marked an inline comment as done. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files: compiler-rt/lib/sa

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377903. vitalybuka added a comment. fix rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files: compiler-rt/lib/sanitizer_common/sanitizer_chained_origin_d

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D111315: Workaround build error for mingw-g++

ldrumm added a comment. In D111315#3048459 , @v.g.vassilev wrote: > Can you map `state_not_recoverable` to `not_supported`? Sure. I wasn't really sure that the io_error and not_enough_memory were appropriate. Thanks for the confirmation CHANGES SINCE

[PATCH] D111315: Workaround build error for mingw-g++

ldrumm updated this revision to Diff 377905. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111315/new/ https://reviews.llvm.org/D111315 Files: clang/lib/Interpreter/Interpreter.cpp Index: clang/lib/Interpreter/Interpreter.cpp ==

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 377904. masoud.ataei added a comment. Description and driver test are added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/include/clang/Driver/

[PATCH] D111315: Workaround build error for mingw-g++

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111315/new/ https://reviews.llvm.org/D111315 ___ cfe-commi

[clang] 6283d46 - Workaround build error for mingw-g++

Author: Luke Drummond Date: 2021-10-07T18:34:16+01:00 New Revision: 6283d468e28b35e2731dda1a9e0efcb3d9acf557 URL: https://github.com/llvm/llvm-project/commit/6283d468e28b35e2731dda1a9e0efcb3d9acf557 DIFF: https://github.com/llvm/llvm-project/commit/6283d468e28b35e2731dda1a9e0efcb3d9acf557.diff

[PATCH] D111315: Workaround build error for mingw-g++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6283d468e28b: Workaround build error for mingw-g++ (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 377909. masoud.ataei added a comment. Update the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/docs/UsersManual.rst clang/inclu

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. `id` is a typedef and `@class` is an `ObjCInterface` now, so it looks like it's safe to remove `ObjCObjectPointer` case then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

zequanwu added a comment. In D111273#3047759 , @hans wrote: > Are there no tests for clang-format-diff.py? That seems unfortunate. No test for clang-format-diff.py. > Will this handle more nested cases, for example if the first line here is > deleted,

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 ___

[PATCH] D106191: [clang] Option control afn flag

erichkeane added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. This seems pretty incomplete to me, I have no idea what it does from this desc

[PATCH] D111250: [clang] Set max allowed alignment to 2^32

aeubanks updated this revision to Diff 377915. aeubanks added a comment. add more codegen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111250/new/ https://reviews.llvm.org/D111250 Files: clang/include/clang/Sema/Sema.h clang/lib/CodeGen

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377921. cor3ntin marked 3 inline comments as done. cor3ntin added a comment. Add C++20 compat warning, fix style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75/new/ https://reviews.llvm.org/D75 Fil

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

erichkeane added inline comments. Comment at: clang/test/Parser/cxx2b-init-statement.cpp:19 + +if (using enum ns::e; false){} // expected-error {{expected '='}} + Is there any way to have this elaborate more? The 'expected 'TOKEN'' is my least favorite typ

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

aaron.ballman added a comment. Just nits from me, but otherwise LGTM! Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:556 +def warn_cxx20_alias_in_init_statement : Warning< + "alias declaration in this context is incompatible with C++ standards before C++23">,

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377929. cor3ntin added a comment. fix diagnostic, nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75/new/ https://reviews.llvm.org/D75 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Bas

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377930. cor3ntin added a comment. Fix version in diagnostics in the right direction (23 => 2b) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75/new/ https://reviews.llvm.org/D75 Files: clang/docs/Re

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

erichkeane added inline comments. Comment at: clang/test/Parser/cxx2b-init-statement.cpp:19 + +if (using enum ns::e; false){} // expected-error {{expected '='}} + aaron.ballman wrote: > erichkeane wrote: > > Is there any way to have this elaborate more? The

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29e00b29f76a: [CUDA] Make sure is included with original __THROW defined. (authored by tra). Repository: rG LLVM Github Monorepo CHANG

[clang] 29e00b2 - [CUDA] Make sure is included with original __THROW defined.

Author: Artem Belevich Date: 2021-10-07T11:43:56-07:00 New Revision: 29e00b29f76adb15a51c1ccd6c1fdb6fce5f4d7b URL: https://github.com/llvm/llvm-project/commit/29e00b29f76adb15a51c1ccd6c1fdb6fce5f4d7b DIFF: https://github.com/llvm/llvm-project/commit/29e00b29f76adb15a51c1ccd6c1fdb6fce5f4d7b.diff

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 updated this revision to Diff 377933. jcking1034 marked 2 inline comments as done. jcking1034 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111242/new/ https://reviews.llvm.org/D111242 Files: clang/d

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

hiraditya updated this revision to Diff 377934. hiraditya added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 Files: clang/include/clang/Basic/Attr.td clang/test/CodeGen/instrument-objc-method.m clang/test/Misc/

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin added inline comments. Comment at: clang/test/Parser/cxx2b-init-statement.cpp:19 + +if (using enum ns::e; false){} // expected-error {{expected '='}} + erichkeane wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Is there any way to have thi

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 marked an inline comment as not done. jcking1034 added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:636 -MatcherDecl>blockDeclMatcher

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

erichkeane added inline comments. Comment at: clang/test/Parser/cxx2b-init-statement.cpp:19 + +if (using enum ns::e; false){} // expected-error {{expected '='}} + cor3ntin wrote: > erichkeane wrote: > > aaron.ballman wrote: > > > erichkeane wrote: > > > > Is

[PATCH] D111331: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: pengfei, kristof.beyls. ahatanak requested review of this revision. https://reviews.llvm.org/D92808 made clang use the operand bundle instead of emitting retainRV/claimR

  1   2   >