erichkeane added inline comments.
================
Comment at: clang/test/Parser/cxx2b-init-statement.cpp:19
+
+ if (using enum ns::e; false){} // expected-error {{expected '='}}
+
----------------
cor3ntin wrote:
> erichkeane wrote:
> > aaron.ballman wrote:
> > > erichkeane wrote:
> > > > Is there any way to have this elaborate more? The 'expected 'TOKEN''
> > > > is my least favorite type of error. Could we change this to be
> > > > something like, 'expected '=' in type alias' or something?
> > > FWIW, I'm fine with the diagnostic as-is because I don't expect anyone to
> > > actually *use* this functionality, so I don't expect a ton of users to
> > > hit this. I'd say it's fine to address when a user files a bug showing
> > > some code where the diagnostic is unclear.
> > I'm sad by this, and Aaron points out it is a bit of a hassle, so I can
> > disagree & commit here.
> Yeah, i guess we could but i really do not expect that feature to have a lot
> of uses. So i tried to keep the patch minimal.
Aaron and I discussed it, and I'm willing to relent, so feel free to land. In
Aaron's opinion right now:
`Effort to improve diagnostic >(greatly) Chance of someone running into it`
I'm willing to wait until there is proof of the RHS of that equation being of
greater magnitude before being willing to ask for the effort on the LHS.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111175/new/
https://reviews.llvm.org/D111175
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
