[clang] 66d9d10 - [clang][AST] Add support for ShuffleVectorExpr to ASTImporter

Author: Balazs Benics Date: 2021-09-27T10:17:12+02:00 New Revision: 66d9d1012b031e7f7559e8f0e03b9e7bfb6c20a1 URL: https://github.com/llvm/llvm-project/commit/66d9d1012b031e7f7559e8f0e03b9e7bfb6c20a1 DIFF: https://github.com/llvm/llvm-project/commit/66d9d1012b031e7f7559e8f0e03b9e7bfb6c20a1.diff

[PATCH] D110052: [clang][AST] Add support for ShuffleVectorExpr to ASTImporter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66d9d1012b03: [clang][AST] Add support for ShuffleVectorExpr to ASTImporter (authored by steakhal). Herald added a project: clang. Herald added a sub

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

steakhal added a comment. Great work! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1591-1595 template LLVM_NODISCARD static ProgramStateRef - assign(ProgramStateRef State, SValBuilder &Builder, RangeSet::Factory &F, - ClassOrSymbol CoS, R

[PATCH] D110387: [Analyzer][NFC] Move RangeConstraintManager's def before ConstraintAssignor's def

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. It seems clean to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110387/new/ https://reviews.llvm.org/D110387 __

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm updated this revision to Diff 375169. david-arm retitled this revision from "[AArch64][Clang] Always add -tune-cpu argument to -cc1 driver" to "[AArch64] Always add -tune-cpu argument to -cc1 driver". david-arm edited the summary of this revision. david-arm added a comment. Herald added

[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

bakinovsky-m created this revision. bakinovsky-m added a reviewer: aaron.ballman. bakinovsky-m created this object with edit policy "Administrators". bakinovsky-m added a project: clang-tools-extra. bakinovsky-m requested review of this revision. Herald added a subscriber: cfe-commits. bugprone-vi

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. Sounds great. Glad to see us taking this route. Unfortunately I think we do need to split the subtargetfeatures up into arch flags and tune flags. Same for the details in AArch64Subtarget::initializeProperties. It is hopefully a fairly mechanical process, but they are

[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

DavidSpickett added a comment. > I'd hope that it works this way (armv8l-*) :) Cool I'm going to work with that goal in mind then. I've turned it off by default for 32 bit Arm linux until it's made compatible: https://reviews.llvm.org/rG3c65d54ec3d2 Repository: rG LLVM Github Monorepo CHAN

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm added a comment. In D110258#3023818 , @dmgreen wrote: > Sounds great. Glad to see us taking this route. > > Unfortunately I think we do need to split the subtargetfeatures up into arch > flags and tune flags. Same for the details in > AArch64

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

MyDeveloperDay updated this revision to Diff 375177. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Mark all options with their version, Move the \version into the comment Warning if we add new options without a version I think this is a fairly good representati

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. I think ProcessorModel is class ProcessorModel f, list tunef = []> So we are always currently passing tunef = [] from AArch64 and passing all features through f. They need to be split out and then hopefully the call to ParseSubtargetFeatures w

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:237 +field_type, field_name, trailcomment, version = re.match(r'([<>:\w(,\s)]+)\s+(\w+)\s*(\/\*version=([0-9.]*)\*\/)*;', line).groups() +

[libunwind] 77aa9ca - [libunwind] Support cfi_undefined and cfi_register for float registers.

Author: Daniel Kiss Date: 2021-09-27T12:04:02+02:00 New Revision: 77aa9ca92ae4732f5f92e580e14bb4d757f6b364 URL: https://github.com/llvm/llvm-project/commit/77aa9ca92ae4732f5f92e580e14bb4d757f6b364 DIFF: https://github.com/llvm/llvm-project/commit/77aa9ca92ae4732f5f92e580e14bb4d757f6b364.diff L

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

HazardyKnusperkeks added inline comments. Comment at: clang/docs/tools/dump_format_style.py:218 + if line.startswith(r'/// \version'): +match = re.match(r'/// \\version\s*(?P[0-9.]+)*',line) +if match: This needs to be escaped, doesn't it?

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

balazske created this revision. Herald added subscribers: steakhal, whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 375187. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:470 + ExpectedHint{": S1", "x"}, + ExpectedHint{": S2::Inner", "y"}); } nridge wrote: >

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. I think these are the features I would class as tuning: FeatureExperimentalZeroingPseudos FeatureZCRegMove FeatureZCZeroingGP FeatureNoZCZeroingFP FeatureZCZeroing FeatureZCZeroingFPWorkaround FeatureStrictAlign FeatureBalanceFPOps FeaturePredictableSele

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Headers.cpp:174 + IncludeStructure::HeaderID Result = R.first->getValue(); + auto RealPathName = Entry->tryGetRealPathName();

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

sylvestre.ledru added a comment. @phosek It was probably my fault (mix of different in-tree / out of tree builds) Quick question, why the path to `__config_site` contains this triple `x86_64-pc-linux-gnu` (in `/usr/lib/llvm-14/include/x86_64-pc-linux-gnu/c++/v1/__config_site`) when it is usually:

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 375079. gandhi21299 added a comment. - Declare an unhandled call lowering in SelectionDAG when a callee is encountered which cannot be casted into a Function - I am still investigating the effects on GlobalISel side of things, there seems to be a problem

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. It does not look like function calls are supported yet in AMDGPUCallLowering, is that correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 ___

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

MyDeveloperDay updated this revision to Diff 375206. MyDeveloperDay marked 6 inline comments as done. MyDeveloperDay added a comment. - Minor available version corrections - Addressing review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110432/new/ https://reviews.llvm.org/D11

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:218 + if line.startswith(r'/// \version'): +match = re.match(r'/// \\version\s*(?P[0-9.]+)*',line) +if match: HazardyKnusperkeks wrote: > HazardyKnusperke

[PATCH] D110493: [clang-tidy] Fix bug 51790 in readability-uppercase-literal-suffix

aaron.ballman added a comment. Thank you for the fix! Comment at: clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp:137-138 + // Make sure the first character is actually a digit + // https://bugs.llvm.org/show_bug.cgi?id=51790 + if (!std::isdigit(s

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki updated this revision to Diff 375216. linjamaki added a comment. Rename SPIRABIInfo -> CommonSPIRABIInfo and SPIRTargetCodeGenInfo -> CommonSPIRTargetCodeGenInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.l

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

steakhal added a comment. I appreciate the effort in working on the attribute imports. Personally, I don't really like this change. IMO `AttrImporter::createImportedAttr()` should do the magic, and apply the necessary glue for the import. Or we could even create a dedicated function, which woul

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 375219. linjamaki added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://review

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 375221. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGenHIP/hipspv-ad

[PATCH] D110458: [clang] Put original flags on 'Driver args:' crash report line

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Driver/Driver.cpp:1220 + for (const auto *A : Args) { +while (A->getAlias()) + A = A->getAlias(); Could put a comment here a

[PATCH] D110458: [clang] Put original flags on 'Driver args:' crash report line

thakis marked an inline comment as done. thakis added a comment. Thanks! Comment at: clang/test/Driver/crash-report-clang-cl.c:2 +// RUN: rm -rf %t +// RUN: mkdir %t + hans wrote: > These always make me thing the test should "requires: shell", but I think for

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

balazske added a comment. The code can be made better in a way that only lines similar to Expected ToAttrOrErr = AI.createImportedAttr( From, AI.importArg(From->getSuccessValue()).value(), AI.importArrayArg(From->args(), From->args_size()).value(), From->args_size()); are nee

[PATCH] D110458: [clang] Put original flags on 'Driver args:' crash report line

thakis updated this revision to Diff 375232. thakis added a comment. add comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110458/new/ https://reviews.llvm.org/D110458 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/crash-report-clang-cl.c Index: clang/test/Driver/crash-

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki updated this revision to Diff 375233. linjamaki added a comment. Put HIPSPV logic into new SPIRV{ABI,TargetCodeGen}Info subclassed from CommonSPIR{ABI,TargetCodeGen}Info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://r

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 375237. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Resolve all but two comments, leave the clarification questions for these two. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/n

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:205 CurrentLevel.push_back(Child); - const auto &Name = RealPathNames[Child]; // Can't include files if we don't have their real path. + if (!RealPathNames[sta

[PATCH] D110484: [clang-repl] Allow loading of plugins in clang-repl.

sgraenitz added a comment. Two minor comments. Otherwise LGTM. Comment at: clang/include/clang/Frontend/CompilerInstance.h:223 + void LoadRequestedPlugins(); + /// } This could have a minimal doxygen comment now that it's part of the public interface. ==

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:205 CurrentLevel.push_back(Child); - const auto &Name = RealPathNames[Child]; // Can't include files if we don't have their real path. + if (!RealPathNames[st

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm added a comment. Hi @dmgreen, would you be happy for me to do the splitting-out of arch and tuning features in a separate follow-on patch? I think it's a good idea and I don't object to doing it, but I'm not sure that it really needs to hold up this initial patch? I personally think i

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

aaron.ballman added a comment. Should we also change this to parse an unevaluated string literal: https://github.com/llvm/llvm-project/blob/main/clang/lib/Lex/ModuleMap.cpp#L1594 Similar question for all the uses in OpenMP stemming from: https://github.com/llvm/llvm-project/blob/main/clang/lib/P

[PATCH] D110493: [clang-tidy] Fix bug 51790 in readability-uppercase-literal-suffix

carlosgalvezp updated this revision to Diff 375242. carlosgalvezp added a comment. Fixed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110493/new/ https://reviews.llvm.org/D110493 Files: clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp clang

[clang] 38d0908 - Removing a default constructor argument; NFC

Author: Aaron Ballman Date: 2021-09-27T09:41:28-04:00 New Revision: 38d09080c938c132279644e70001e8607a2998fb URL: https://github.com/llvm/llvm-project/commit/38d09080c938c132279644e70001e8607a2998fb DIFF: https://github.com/llvm/llvm-project/commit/38d09080c938c132279644e70001e8607a2998fb.diff

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 375244. cor3ntin added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basi

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. @MaskRay Do you have further comments or alternative solutions? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 ___ cfe-commits ma

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

aaron.ballman added a comment. In D108560#3020444 , @salman-javed-nz wrote: > Also, in your example, you have begun all checks (`check`, `check2`, `check3` > ... `checkN`) but only ended one of them. The remaining checks are still > awaiting a `NOLINTE

[clang] 63bb2d5 - [clang] Put original flags on 'Driver args:' crash report line

Author: Nico Weber Date: 2021-09-27T10:24:46-04:00 New Revision: 63bb2d585e9760cbc2251f95dfcc335506cad177 URL: https://github.com/llvm/llvm-project/commit/63bb2d585e9760cbc2251f95dfcc335506cad177 DIFF: https://github.com/llvm/llvm-project/commit/63bb2d585e9760cbc2251f95dfcc335506cad177.diff LO

[PATCH] D110458: [clang] Put original flags on 'Driver args:' crash report line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63bb2d585e97: [clang] Put original flags on 'Driver args:' crash report line (authored by thakis). Herald added a project: clang. Repository: rG L

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 375251. cor3ntin added a comment. Fix build and address most of Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/include/clang/Basic/D

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin marked 5 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/AST/Expr.h:1845 StringRef getString() const { -assert(getCharByteWidth() == 1 && +assert((isUnevaluated() || getCharByteWidth() == 1) && "This functio

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:422-423 -ExprResult ArgExpr( -Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); +ExprResult ArgExpr(Actions.CorrectDelayedTyposInExpr( +ParseAttribut

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 375253. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Switch to full DenseMap comparison in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:205 CurrentLevel.push_back(Child); - const auto &Name = RealPathNames[Child]; // Can't include files if we don't have their real path. + if (!RealPathNames[sta

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/HeadersTests.cpp:234 + auto Includes = collectIncludes(); + EXPECT_THAT(Includes.IncludeChildren[getID(MainFile)], + UnorderedElementsAreArray({getID(FooHeader), getID(BarHeader)})); ---

[clang] 1f5b60a - Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c test case.

Author: Amy Kwan Date: 2021-09-27T09:56:18-05:00 New Revision: 1f5b60ad47f1fa0493e4c9d8080eace56f87ee0c URL: https://github.com/llvm/llvm-project/commit/1f5b60ad47f1fa0493e4c9d8080eace56f87ee0c DIFF: https://github.com/llvm/llvm-project/commit/1f5b60ad47f1fa0493e4c9d8080eace56f87ee0c.diff LOG:

[PATCH] D110431: Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c test case.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f5b60ad47f1: Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c… (authored by amyk). Repository: rG LLVM Github Monor

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

yaxunl added a comment. Pls update the description of the patch and also make sure it passes internal CI. Comment at: clang/test/CodeGenCUDA/amdgpu-alias-undef-symbols.cu:1 +// RUN: %clang --offload-arch=gfx906 --cuda-device-only -x hip -emit-llvm -S -o - %s \ +// RUN: -fgp

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. In D109707#3016438 , @gandhi21299 wrote: > - replaced a `cast` with a `dyn_cast` since the return value from > `getCalleeFunction()` is not always a Function > - `RUN on line 2` was causing 2 more scalar registers to be used

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added a comment. In D105759#3024419 , @aaron.ballman wrote: > Should we also change this to parse an unevaluated string literal: > https://github.com/llvm/llvm-project/blob/main/clang/lib/Lex/ModuleMap.cpp#L1594 > Similar question for all the u

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375265. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/checkers/modern

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375267. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/checkers/modern

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG. We might be able to revert/simplify this eventually again but for now it makes it much simpler to distinguish the distribute and workshare (=for) via their call site. ===

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Expr.h:1845 StringRef getString() const { -assert(getCharByteWidth() == 1 && +assert((isUnevaluated() || getCharByteWidth() == 1) && "This function is used in places that assume string

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 375272. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/M

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 375273. cor3ntin added a comment. Correctly rebase on top of D105759 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clan

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

aaron.ballman added reviewers: erichkeane, rjmccall. aaron.ballman added a comment. In general, I think this is shaping up nicely and is almost complete. I'm adding some additional reviewer though, as this is a somewhat experimental patch for a WG21 proposal that has not been accepted yet and I

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 375277. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve the last comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: clang-

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375278. cor3ntin added a comment. Formatting and missing punctuation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/check

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:257 + +def err_unevaluated_string_prefix : Error< + "an unevaluated string literal cannot have an encoding prefix">; Is there value to combining these two diagnostics w

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 375285. quinnp added a comment. Added a backend testcase which goes from `fdiv fast` to software estimate. Added a runline in the front end testcase that sets the fast math flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp added a comment. In D106959#3021069 , @NeHuang wrote: > Do we already have a backend test case for `fdiv` emitting a software > estimate when `-Ofast` is used? I've added a testcase in `llvm/test/CodeGen/PowerPC/fdiv.ll` which goes from `fdiv fa

[PATCH] D110387: [Analyzer][NFC] Move RangeConstraintManager's def before ConstraintAssignor's def

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. LGTM. ?Should mention this as //NFC//. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110387/new/ https://reviews.llvm.org/D110387 ___

[clang-tools-extra] 0b1eff1 - [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

Author: Kirill Bobyrev Date: 2021-09-27T17:50:53+02:00 New Revision: 0b1eff1bc5d004b1964bb9b1667e3efc034f3f62 URL: https://github.com/llvm/llvm-project/commit/0b1eff1bc5d004b1964bb9b1667e3efc034f3f62 DIFF: https://github.com/llvm/llvm-project/commit/0b1eff1bc5d004b1964bb9b1667e3efc034f3f62.diff

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b1eff1bc5d0: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations (authored by kbobyrev). Repository: rG LLVM Github Mon

[PATCH] D110482: [clang] Implement if consteval (P1938)

erichkeane added inline comments. Comment at: clang/include/clang/AST/Stmt.h:166 +/// True if this if statement is a if consteval statement. +unsigned IsConsteval : 1; Not sure how others feel here, but for me, I kinda hate that we're using 'unsigned'

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

ronlieb added a comment. hi, we seem to have a link time error after this patch in our buildbot https://lab.llvm.org/staging/#/builders/182/builds/2023 - TEST 'libomptarget :: amdgcn-amd-amdhsa :: mapping/private_mapping.c' FAILED Script: --- : 'RUN: at line 1'; /w

[PATCH] D108469: Improve handling of static assert messages.

jfb added a comment. Can you test all the values in this? https://godbolt.org/z/h7n54fa5x Comment at: clang/lib/Basic/Diagnostic.cpp:792 +static void pushEscapedString(StringRef Str, SmallVectorImpl &OutStr) { + OutStr.reserve(OutStr.size() + Str.size()); + const unsigned cha

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

ronlieb added a comment. apologies, that pasted very poorly ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110429/new/ https://reviews.llvm.org/D110429 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

ronlieb added a comment. lld: error: undefined symbol: __kmpc_distribute_static_init_4 >>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__) >>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__) lld: error: undefined symbol: __kmpc_distribute

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

ronlieb added a comment. looks like subsequent builders passed. we might have an issue where the runtime was not fully built when the test ran. please disregard , your patch is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110429/new/ https:

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

jhuber6 added a comment. In D110429#3024884 , @ronlieb wrote: > lld: error: undefined symbol: __kmpc_distribute_static_init_4 > referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__) referenced by /tmp/private_m

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

jdoerfert added a comment. In D110429#3024886 , @ronlieb wrote: > looks like subsequent builders passed. we might have an issue where the > runtime was not fully built when the test ran. > please disregard , your patch is fine. two dependent patches and

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen added a comment. In D103938#3018918 , @ychen wrote: > In D103938#3018588 , @aaron.ballman > wrote: > >> In D103938#3013503 , @thakis wrote: >> >>> This flags this c

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1591-1595 template LLVM_NODISCARD static ProgramStateRef - assign(ProgramStateRef State, SValBuilder &Builder, RangeSet::Factory &F, - ClassOrSymbol CoS, RangeSet

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375306. cor3ntin marked 3 inline comments as done. cor3ntin added a comment. - Rename isImmediate to isImmediateFunctionContext - Fix And cleanup Diagnostics in ParseStmt.cpp - Add assert in SemaStmt.cpp - Fix StmtPrinter.cpp Repository: rG LLVM Github

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. FYI I just realized some other tests I never run locally relied on the former behavior of the ElaboratedType printer. I will see what looks more reasonable, but I think the defaults are tuned so the type printer will output code that looks close to what it was as writt

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin added inline comments. Comment at: clang/include/clang/AST/Stmt.h:166 +/// True if this if statement is a if consteval statement. +unsigned IsConsteval : 1; erichkeane wrote: > Not sure how others feel here, but for me, I kinda hate that we're

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/45971/step_9.txt PTAL! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386

[PATCH] D110482: [clang] Implement if consteval (P1938)

erichkeane added a comment. Note I didn't have a good chance to re-review this, but wanted to give my feedback to the comments right away. Comment at: clang/include/clang/AST/Stmt.h:166 +/// True if this if statement is a if consteval statement. +unsigned IsConsteval

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 375284. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - added the `REQUIRES` line as requested by Sam Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.l

RE: [PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

[AMD Official Use Only] Yes, thank you, it was two dependent patches Builder 1 only saw 1st patch, failed, then 2nd patch arrived, and passed. Builder 2 picked up both and passed All good. -Original Message- From: Johannes Doerfert via Phabricator Sent: Monday, September 27, 2021 12:0

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. @yaxunl Should inline-calls.ll be converted into an expected failing test or removed? (to avoid cast failure in AMDGPUResourceAnalysis to break the test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https:

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375319. cor3ntin added a comment. Replace `Unevaluated` by an enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/checke

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov marked an inline comment as not done. mizvekov added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:470 + ExpectedHint{": S1", "x"}, + ExpectedHint{": S2::Inner", "y"}); } mizvekov wr

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added a comment. The description isn't clear why the previous `weak` symbol usage does not work. Have you verified that it does not work? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 _

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:257 + +def err_unevaluated_string_prefix : Error< + "an unevaluated string literal cannot have an encoding prefix">; erichkeane wrote: > Is there value to combining

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

erichkeane added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:95-96 + case '?': + case 'n': + case 't': +return true; aaron.ballman wrote: > erichkeane wrote: > > aaron.ballman wrote: > > > aaron.ballman wrote: > > > > cor3ntin wrote: > >

[clang] c4afb5f - [HIP] Fix linking of asanrt.bc

Author: Yaxun (Sam) Liu Date: 2021-09-27T13:25:46-04:00 New Revision: c4afb5f81b62b903e4af8a92235e1b901e184040 URL: https://github.com/llvm/llvm-project/commit/c4afb5f81b62b903e4af8a92235e1b901e184040 DIFF: https://github.com/llvm/llvm-project/commit/c4afb5f81b62b903e4af8a92235e1b901e184040.dif

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGc4afb5f81b62: [HIP] Fix linking of asanrt.bc (authored by yaxunl). Herald added a project: clang. Changed p

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra added a comment. So, what's the current state of affairs regarding CUDA SDK layout in debian? Clang does rely on very particular ordering of includes, so having CUDA headers in a location clang does not expect will lead to issues sooner or later. If the headers are not available where --cuda-

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

aaron.ballman added a comment. In D103938#3024938 , @ychen wrote: > In D103938#3018918 , @ychen wrote: > >> In D103938#3018588 , >> @aaron.ballman wrote: >> >>> In D10393

  1   2   >