mizvekov marked an inline comment as not done.
mizvekov added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:470
+ ExpectedHint{": S1", "x"},
+ ExpectedHint{": S2::Inner<int>", "y"});
}
----------------
mizvekov wrote:
> nridge wrote:
> > This test expectation change is suspicious. The type is being printed with
> > `PrintingPolicy::SuppressScope=true`, shouldn't that still be respected?
> Thanks for pointing that out, I will take a look, but I suspect this to be
> some TypePrinter issue.
Could you explain to me why the former behavior is more desirable here?
I initially understood that this hint should provide the type written in a form
that would actually work if it replaced the 'auto'.
It is strange, but if it is just meant as a hint, it's still fine I guess.
Or maybe this was broken in the first place and just was just missing a FIXME?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110216/new/
https://reviews.llvm.org/D110216
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
