cor3ntin added a comment. In D105759#3024419 <https://reviews.llvm.org/D105759#3024419>, @aaron.ballman wrote:
> Should we also change this to parse an unevaluated string literal: > https://github.com/llvm/llvm-project/blob/main/clang/lib/Lex/ModuleMap.cpp#L1594 > Similar question for all the uses in OpenMP stemming from: > https://github.com/llvm/llvm-project/blob/main/clang/lib/Parse/ParseOpenMP.cpp#L825 > (https://www.openmp.org/spec-html/5.1/openmp.html is the OpenMP spec but I > didn't see any mention of encoding prefixes when I peeked) Maybe - but I don't know anything about OpenMP. I tried to be conservative in where I apply the change > I think we still need to handle UDLs so that we parse the declaration's `""` > as an unevaluated string literal. There is a different diagnostic, but the semantic is correct. Not sure it would be worth it to change it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
