dmgreen added a comment.
Sounds great. Glad to see us taking this route.
Unfortunately I think we do need to split the subtargetfeatures up into arch
flags and tune flags. Same for the details in
AArch64Subtarget::initializeProperties. It is hopefully a fairly mechanical
process, but they are an important part of tuning and without them -mtune is
only a half-working option.
Are you happy to give that a go too?
================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:305
/// of the specified triple.
- AArch64Subtarget(const Triple &TT, const std::string &CPU,
+ AArch64Subtarget(const Triple &TT, const std::string &CPU, const std::string
&TuneCPU,
const std::string &FS, const TargetMachine &TM,
----------------
Needs reformatting.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110258/new/
https://reviews.llvm.org/D110258
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
