[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

mgorny added a comment. This change causes `clang-ast-dump` to segfault for me while building clang: [399/399] ASTNodeAPI.json FAILED: tools/clang/lib/Tooling/ASTNodeAPI.json /home/mgorny/git/llvm-project/build/tools/clang/lib/Tooling/ASTNodeAPI.json cd /home/mgorny/git/llvm-project/build

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

keryell added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasi

[PATCH] D109609: [C++4OpenCL] Add support for multiple address spaced destructors

keryell added a comment. While it might be possible to extend arbitrarily C++, I have the feeling that having just 1 destructor and have a different code path-code according the address space would not be enough. It is possible to write: ~MyDestructor() { if constexpr (SomeAPIReturningAdd

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp:534 + +union U2 { + U2() {} aaron.ballman wrote: > A related interesting test would be: > ``` > union U3 { > U3() {} > > struct

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

curdeius added a comment. In D69764#2996365 , @steveire wrote: > FYI - there's nothing "anti-inclusive" about East/West. Thank you for your comment. Personally I don't think that the question of not using East/West is whether these terms are inclusive o

[PATCH] D109659: Fix scan-build-py executable lookup path

This revision was automatically updated to reflect the committed changes. Closed by commit rGc84755a046bb: Fix scan-build-py executable lookup path (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109659/new/ https://re

[clang] c84755a - Fix scan-build-py executable lookup path

Author: serge-sans-paille Date: 2021-09-13T11:01:47+02:00 New Revision: c84755a046bbdcd0564693e30b2508034b06002b URL: https://github.com/llvm/llvm-project/commit/c84755a046bbdcd0564693e30b2508034b06002b DIFF: https://github.com/llvm/llvm-project/commit/c84755a046bbdcd0564693e30b2508034b06002b.d

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

mgorny added a comment. I'm sorry, it seems to have been caused by ccache. After clearing the cache, I can't reproduce anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544 ___

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in keryell wr

[clang] 3731de6 - [X86] Adjust Keylocker handle mem size

Author: Xiang1 Zhang Date: 2021-09-13T17:59:33+08:00 New Revision: 3731de6b7f2d42d40151f9574636bc4d5ccfa5e3 URL: https://github.com/llvm/llvm-project/commit/3731de6b7f2d42d40151f9574636bc4d5ccfa5e3 DIFF: https://github.com/llvm/llvm-project/commit/3731de6b7f2d42d40151f9574636bc4d5ccfa5e3.diff

[clang] bdce8d4 - Revert "[X86] Adjust Keylocker handle mem size"

Author: Xiang1 Zhang Date: 2021-09-13T18:00:46+08:00 New Revision: bdce8d40c6da56f1c95a8d7bfeac12b1ffce79cf URL: https://github.com/llvm/llvm-project/commit/bdce8d40c6da56f1c95a8d7bfeac12b1ffce79cf DIFF: https://github.com/llvm/llvm-project/commit/bdce8d40c6da56f1c95a8d7bfeac12b1ffce79cf.diff

[clang] c81d6ab - [X86] Adjust Keylocker handle mem size

Author: Xiang1 Zhang Date: 2021-09-13T18:03:27+08:00 New Revision: c81d6ab8758224ab950716d9533df79c5b5fb706 URL: https://github.com/llvm/llvm-project/commit/c81d6ab8758224ab950716d9533df79c5b5fb706 DIFF: https://github.com/llvm/llvm-project/commit/c81d6ab8758224ab950716d9533df79c5b5fb706.diff

[PATCH] D109488: [X86] Adjust Keylocker store register num for encodekey128/256

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc81d6ab87582: [X86] Adjust Keylocker handle mem size (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-comm

[clang] d86a947 - [Sema] Add test for __builtin_fminf errors.

Author: Florian Hahn Date: 2021-09-13T11:12:06+01:00 New Revision: d86a947bb91cc67452057b4bc25c0c7734b5139c URL: https://github.com/llvm/llvm-project/commit/d86a947bb91cc67452057b4bc25c0c7734b5139c DIFF: https://github.com/llvm/llvm-project/commit/d86a947bb91cc67452057b4bc25c0c7734b5139c.diff

[PATCH] D109681: [RISCV] add Half-precision test for vle/vse

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: craig.topper, HsiangKai. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, r

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added a comment. I like everything I see here so far! As soon as those debug functions are in, the patch should land! Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:236-240 + /// At any stream operation that can cause (multiple type of) bugs, we can

[PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

foad added a comment. What is a "keep constructor"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/new/ https://reviews.llvm.org/D109483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] d353d1c - [OpenCL] Support cl_ext_float_atomics

Author: Sven van Haastregt Date: 2021-09-13T12:12:40+01:00 New Revision: d353d1c50112a1cb315eccdab18ce7bd1563cd06 URL: https://github.com/llvm/llvm-project/commit/d353d1c50112a1cb315eccdab18ce7bd1563cd06 DIFF: https://github.com/llvm/llvm-project/commit/d353d1c50112a1cb315eccdab18ce7bd1563cd06.

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd353d1c50112: [OpenCL] Support cl_ext_float_atomics (authored by svenvh). Herald added a subscriber: ldrumm. Changed prior to commit: https://revi

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh added a comment. Apologies for the delayed response. In D106343#2967089 , @haonanya wrote: > Hi, svenvh. > Should we use cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics to > guard the functions using atomic_double type? > Thanks very

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:233 +if (Opts.HIP && Opts.CUDAIsDevice) + // Enable address space mapping from HIP to SPIR-V. + // See comment on the SPIRDefIsGenMap table. Anastasia wrote: > My guess is t

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

This revision was automatically updated to reflect the committed changes. Closed by commit rG0213d7ec0c50: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire… (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D108695?vs=370549&id=372217#toc Repo

[clang] 0213d7e - [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Author: Kristóf Umann Date: 2021-09-13T13:50:01+02:00 New Revision: 0213d7ec0c501414d12020737fdc47e47e4392d9 URL: https://github.com/llvm/llvm-project/commit/0213d7ec0c501414d12020737fdc47e47e4392d9 DIFF: https://github.com/llvm/llvm-project/commit/0213d7ec0c501414d12020737fdc47e47e4392d9.diff

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

jdoerfert added a comment. In D109544#2996913 , @mgorny wrote: > I'm sorry, it seems to have been caused by ccache. After clearing the cache, > I can't reproduce anymore. The problem is that clang-ast-dump has incomplete dependences and sometimes picks

[clang] 8008009 - [OpenCL] Initialize temporaries in the private address space

Author: Ole Strohm Date: 2021-09-13T12:56:04+01:00 New Revision: 8008009fd25bf51c2c85c612bfefec64e975bbe4 URL: https://github.com/llvm/llvm-project/commit/8008009fd25bf51c2c85c612bfefec64e975bbe4 DIFF: https://github.com/llvm/llvm-project/commit/8008009fd25bf51c2c85c612bfefec64e975bbe4.diff LO

[PATCH] D107553: [C++4OpenCL] Initialize temporaries in the private address space

This revision was automatically updated to reflect the committed changes. Closed by commit rG8008009fd25b: [OpenCL] Initialize temporaries in the private address space (authored by olestrohm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107553/new/

[clang] ec6c847 - [clang] Check unsupported types in expressions

Author: Andrew Savonichev Date: 2021-09-13T14:59:37+03:00 New Revision: ec6c847179fd019acae4d97a18f9e7d3961a6fdf URL: https://github.com/llvm/llvm-project/commit/ec6c847179fd019acae4d97a18f9e7d3961a6fdf DIFF: https://github.com/llvm/llvm-project/commit/ec6c847179fd019acae4d97a18f9e7d3961a6fdf.d

[PATCH] D109315: [clang] Check unsupported types in expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGec6c847179fd: [clang] Check unsupported types in expressions (authored by asavonic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109315/new/ https://revie

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal added a comment. Hey, Jon, sorry for late reply. I cannot reproduce this issue on nvptx so it seems to occur only on amdgcn. Will it be better if instead the name mangling issue is fixed? Or for the meantime, I could add #ifdef around as a temporary fix. Suggestions? Repository: r

[clang] 6377426 - Revert "[clang] Check unsupported types in expressions"

Author: Andrew Savonichev Date: 2021-09-13T15:34:21+03:00 New Revision: 6377426b4a326b52733065609a5d811afd2b8b1b URL: https://github.com/llvm/llvm-project/commit/6377426b4a326b52733065609a5d811afd2b8b1b DIFF: https://github.com/llvm/llvm-project/commit/6377426b4a326b52733065609a5d811afd2b8b1b.d

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

thakis added a comment. Can you just set `CLANG_TIDY_ENABLE_STATIC_ANALYZER=OFF` too if you care about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109611/new/ https://reviews.llvm.org/D109611 __

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

arichardson added a comment. In D109611#2997236 , @thakis wrote: > Can you just set `CLANG_TIDY_ENABLE_STATIC_ANALYZER=OFF` too if you care > about this? That doesn't have any effect on the libraries linked into clang-shlib. I am not building clang-too

[clang] 648feab - [clang] Make the driver not diagnose errors on nonexistent linker inputs

Author: Nico Weber Date: 2021-09-13T08:57:38-04:00 New Revision: 648feabc65d8ec20e5d39ac88e019d310955a6e6 URL: https://github.com/llvm/llvm-project/commit/648feabc65d8ec20e5d39ac88e019d310955a6e6 DIFF: https://github.com/llvm/llvm-project/commit/648feabc65d8ec20e5d39ac88e019d310955a6e6.diff LO

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

This revision was automatically updated to reflect the committed changes. Closed by commit rG648feabc65d8: [clang] Make the driver not diagnose errors on nonexistent linker inputs (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gi

[clang] 9d359f6 - [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default

Author: Kristóf Umann Date: 2021-09-13T15:01:20+02:00 New Revision: 9d359f6c738632c6973e9f5328b10bf39b3df55a URL: https://github.com/llvm/llvm-project/commit/9d359f6c738632c6973e9f5328b10bf39b3df55a DIFF: https://github.com/llvm/llvm-project/commit/9d359f6c738632c6973e9f5328b10bf39b3df55a.diff

[PATCH] D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d359f6c7386: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a… (authored by Szelethus). Repository: rG LLVM Github M

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

Szelethus added a comment. Gonna land this in a day or two, regardless of whether its accepted! Please take a look if you have anything to object to! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108912/new/ https://reviews.llvm.org/D108912

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke added a comment. kindly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. @saiislam did you turn on offload? https://github.com/ye-luo/openmp-target/wiki/OpenMP-offload-compilers#llvm-clang On NVIDIA, it fails at CMake step. On AMD, make step stops because of unrelated issue. Please make the exact reproducer 1 working. Right now I got $ cla

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:56 +hasType(Container), +hasType(pointsTo(Container)), +

[PATCH] D109686: Check supported architectures in sseXYZ/avxXYZ headers

serge-sans-paille created this revision. serge-sans-paille added reviewers: craig.topper, RKSimon. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It doesn't make sense to include those headers on the wrong architecture, p

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze updated this revision to Diff 372237. zukatsinadze added a comment. Thanks for the review @martong I've fixed all the suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 Files: clang/docs/analyzer/checkers.rst clang/in

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze marked 4 inline comments as done. zukatsinadze added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:163 +// memory region returned by previous call of this function +REGISTER_MAP_WITH_PROGRAMSTATE(PreviousCallResultMap, cons

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Accepting the review -- if you don't hear back from @delesley in the next few days, I think it's fine to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 372243. quinnp added a comment. Adding SemaChecking for the first argument of __builitn_ppc_test_data_class so the llvm_unreachable in CGBuiltin is actually unreachable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

pengfei added a comment. In D109658#2996767 , @craig.topper wrote: > In D109658#2996714 , @pengfei wrote: > >> In D109658#2996412 , @craig.topper >> wrote: >> >>> Does g

[PATCH] D109688: [AMDGPU] ASan Patches for OpenMP

ampandey-AMD created this revision. Herald added subscribers: kerbowa, guansong, hiraditya, t-tye, tpr, dstuttard, yaxunl, mgorny, nhaehnle, jvesely, kzhuravl. ampandey-AMD requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1, wdng. Hera

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:748 + + // ar tool command "llvm-ar ". + ArgStringList CmdArgs; libtool ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/ne

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

RKSimon added a comment. > Regarding this case, we already have a different name with GCC, I think it > worthwhile to use a different order for the swapping optimization. > With a bit research on AVX512IFMA, I found: > > 1. The use of C, A, B order in GCC is not consistent on its AVX512IFMA > bu

[PATCH] D109688: [AMDGPU] ASan Patches for OpenMP

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. This doesn't seem to be based on LLVM upstream, among other issues. Blocking it for now w/o looking at the actual patch. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

craig.topper added a comment. In D109658#2997395 , @pengfei wrote: > In D109658#2996767 , @craig.topper > wrote: > >> In D109658#2996714 , @pengfei >> wrote: >> >>> In D

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added a comment. Let's change to the uglier #ifdef for now, and add it to the short list of things that aren't quite right in declare variant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D10934

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei updated this revision to Diff 372254. pengfei marked an inline comment as done. pengfei added a comment. Add more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ https://reviews.llvm.org/D109607 Files: clang/lib/CodeG

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:3454 - -return llvm::Type::getHalfTy(getVMContext()); - } LuoYuanke wrote: > Is this the major change? No, this logic is not changed. When `T1` is nullptr, it means `IRType` is simp

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

jdoerfert added a comment. In D109344#2997454 , @JonChesterfield wrote: > Let's change to the uglier #ifdef for now, and add it to the short list of > things that aren't quite right in declare variant Can you please file a bug with a reproducer, I'm no

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Excellent! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 ___ cfe-commits mailing list

[PATCH] D109693: Driver: Remove major release version detection for RHEL

tstellar created this revision. tstellar added a reviewer: serge-sans-paille. tstellar requested review of this revision. Herald added a project: clang. We treat all release of RHEL the same in the driver, so we don't need to detect the RHEL major release version. Repository: rG LLVM Github Mo

[PATCH] D109694: Driver: Add preferred gcc triples for Red Hat operating systems

tstellar created this revision. tstellar added reviewers: serge-sans-paille, MaskRay, mgorny. Herald added a subscriber: pengfei. tstellar requested review of this revision. Herald added a project: clang. The GCCInstallationDetector has a list of gcc triples to search for when trying to find a val

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman marked an inline comment as done. dgoldman added a comment. Friendly ping, PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ https://reviews.llvm.org/D108556 ___ cfe-commits mailing

[PATCH] D109128: [VFS] Use original path when falling back to external FS

JDevlieghere added a comment. Keith and I discussed this offline. My suggestion was to do the following: 1. Check the overlay for the canonicalized path 2. Check the fall-through for the canonicalized path 3. Check the fall-through for the original path If I understand correctly, this patch does

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

martong added a reviewer: teemperor. martong added a comment. Thanks, nice work! I like the direction, however, I'd like to ask comments from @teemperor . Comment at: clang/lib/AST/ASTImporter.cpp:656-671 +// Helper for chaining together multiple imports. If an error is de

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added a comment. In D109344#2997495 , @jdoerfert wrote: > Can you please file a bug with a reproducer, I'm not sure I follow your > problem. Should be a case of trying to compile complex test cases for ovo for amdgpu immediately crashes

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. Probably it is better to make a big comment at the start of the file that explains how the checker works, like in FuchsiaHandleChecker. This comes in a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106262/

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

aaron.ballman added a comment. In D69764#2996365 , @steveire wrote: > FYI - there's nothing "anti-inclusive" about East/West. While I'm certain that there can be confusion around why terms are or are not troublesome to some people and there needs to be s

[PATCH] D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes

mbenfield added a comment. I'd request small changes for grammar: `Wunused-but-set-parameter` and `-Wunused-but-set-variable` emit warnings when a parameter or a variable is set but not used. Otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

catenacyber added a comment. This commit has broken oss-fuzz workflow for rust projects. I do not know if the fix is https://reviews.llvm.org/rG66e2772e4285588ccc3bcdb5f392c8326debbd7d Scenario is export RUSTFLAGS="--cfg fuzzing -Cdebuginfo=1 -Cforce-frame-pointers -Zinstrument-coverage -C l

[PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added a comment. > What is a "keep constructor"? Good question, I'm not sure. I think I meant to say "key constructors". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/new/ https://reviews.llvm.org/D109483 _

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1930 + // mixed with an O0 prelink and an O2 postlink. Loading a sample profile in + // the postlink will require pseudo probe instrumentation in the prelink. + if (PGOOpt && PGOOpt->PseudoProbeForProfiling

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt:42 DynamicTypeChecker.cpp + cert/InvalidPtrChecker.cpp EnumCastOutOfRangeChecker.cpp Please, insert this in its sorted place. CHANGES SINCE LAST ACTION https:/

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. In D104556#2997674 , @catenacyber wrote: > This commit has broken oss-fuzz workflow for rust projects. > I do not know if the fix is > https://reviews.llvm.org/rG66e2772e4285588ccc3bcdb5f392c8326debbd7d > > Scenario is > > exp

[PATCH] D109694: Driver: Add preferred gcc triples for Red Hat operating systems

MaskRay added a comment. Haven't looked closely at this particular commit, but I think hard coding the detected triples is almost always a bad idea. See https://reviews.llvm.org/D63497#2993662 for a longer comment. The proper way is (1) making sure CMake `LLVM_DEFAULT_TARGET_TRIPLE` is correct

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y created this revision. vaibhav.y added a reviewer: lattner. Herald added subscribers: dexonsmith, wenlei, mgorny. vaibhav.y edited the summary of this revision. vaibhav.y added a project: clang. vaibhav.y added subscribers: aaron.ballman, lebedev.ri. vaibhav.y added a comment. vaibhav.y e

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. In D109128#2997588 , @JDevlieghere wrote: > If I understand correctly, this patch does that, but swaps 2 and 3. What's > the motivation for trying the non-canonical path first? If we treat the > current working directory as a pro

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb created this revision. krisb added reviewers: dblaikie, probinson. Herald added a subscriber: hiraditya. krisb requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This fixes https://bugs.llvm.org/show_bug.cgi?id=44695 (a

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:711 + +/*template +friend struct AttrArgImporter; Looks like left over unused code? Comment at: clang/lib/AST/ASTImporter.cpp:8448 + +class AttrImporter { + Error

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

phosek added a comment. `Clang :: Driver/cl.c` started failing on our Windows bots after this change landed. Here

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd marked 7 inline comments as done. compnerd added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:63 +hasType(Container), +hasType(

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

keith updated this revision to Diff 372286. keith marked an inline comment as done. keith added a comment. Fix formatting and comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://reviews.llvm.org/D109461 Files: clang/lib/Dri

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd updated this revision to Diff 372285. compnerd added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893 Files: clang-tools-extra/clang-tidy/readability/CMakeList

[PATCH] D109557: Adds an AlignCloseBracket option

MyDeveloperDay added a comment. Please resubmit the patch with full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 ___ cfe-commits mailing list cfe-com

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

keith updated this revision to Diff 372287. keith added a comment. Revert unrelated formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://reviews.llvm.org/D109461 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Dri

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://reviews.llvm.org/D109461 __

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 372289. vaibhav.y added a comment. [clangBasic] Fixup header guard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h clan

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:69 +/// Reference: +/// 1. https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317427";>artifactLocation object +/// 2. \ref SarifArtifact I'm not sure how to

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

lattner resigned from this revision. lattner edited reviewers, added: rsmith; removed: lattner. lattner added a comment. I'm not sure who the best person is to review this, but it isn't me anymore sadly. Richard, can you recommend someone? Comment at: clang/lib/Basic/Sarif.cp

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern added a comment. I've added more information to my original message. Please let me know if further context is desired. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 __

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added a comment. I think the relevance of Left/Right East/West as a setting is less important, as its more about an ordering, allowing some tokens to go to the Left and some to the Right of the "type" QualifierAlignment: Custom QualifierOrder: [ inline, static, type, const,

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

jyknight added a comment. In D108243#2995898 , @waltl wrote: > Added driver flags, and tests for them @ahatanak did you intend to ask Walt to add a driver flag for this? I think we should not have one, since this isn't something we should be telling us

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman edited reviewers, added: aaron.ballman; removed: rsmith. aaron.ballman added a subscriber: lattner. aaron.ballman added a comment. In D109701#2997892 , @lattner wrote: > I'm not sure who the best person is to review this, but it isn't me any

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 372292. MyDeveloperDay added a comment. QualifierAlignmentFixer need to process all the Left/Right passes internally before return the fixes on the original code. So now QualifierAlignmentFixer has its own inner set of passes which will be processed,

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

aaron.ballman added a comment. In D69764#2997910 , @MyDeveloperDay wrote: > I think the relevance of Left/Right East/West as a setting is less > important, as its more about an ordering, allowing some tokens to go to the > Left and some to the Right of

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman accepted this revision. aaron.ballman added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:63 +hasType(Container), +

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

thakis added a comment. Hm, it passes on my win box and on the one running the presubmit test. Do you know if there's anything special about your bot? Any idea how I could reproduce this? The output is `error: command failed with exit status: True`. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds range checking for some Power10 altivec builtins and changes the signature of a built

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 created this revision. gandhi21299 added reviewers: yaxunl, aeubanks. Herald added subscribers: foad, kerbowa, hiraditya, tpr, nhaehnle, jvesely, arsenm. gandhi21299 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commi

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

arsenm added a comment. While I think the early inliner is largely obsolete, it should still handle aliases correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 _

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5069 // where aliases aren't supported. - if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && !RawTriple.isAMDGPU()) CmdArgs.push_back("-mconstructor-aliases"); This looks

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

ahatanak added a comment. I was just asking for test cases as I thought it was already a driver option, but it turns out it wasn't. I agree that this shouldn't be a driver option. Sorry @waltl, please revert the changes that made it a driver option in the last patch. Repository: rG LLVM Git

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8448 + +class AttrImporter { + Error Err = Error::success(); shafik wrote: > @martong the `ASTImporter` file is quite large as it is and I think it makes > sense to have `AttrImporter` but

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

yaxunl added a comment. We cannot disable early inline all since this will cause performance regressions. Instead, the early inline all pass should be fixed so it does not remove aliases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/

  1   2   >