MaskRay added a comment.

Haven't looked closely at this particular commit, but I think hard coding the 
detected triples is almost always a bad idea.

See https://reviews.llvm.org/D63497#2993662 for a longer comment.

The proper way is (1) making sure CMake `LLVM_DEFAULT_TARGET_TRIPLE` is correct 
at configure time (2) the user should specify the complete --target=.

Inferring random target triple from an incomplete `--target=x86_64` really 
should not be supported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109694/new/

https://reviews.llvm.org/D109694

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to