zukatsinadze marked 4 inline comments as done. zukatsinadze added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:163 +// memory region returned by previous call of this function +REGISTER_MAP_WITH_PROGRAMSTATE(PreviousCallResultMap, const char *, + const MemRegion *) ---------------- martong wrote: > I think we could use the canonical `FunctionDecl*` as the key instead of > `const char *`. Then all the `eval` functions like `evalGetenv` and alike > could be substituted with one simple function. Thanks! Those functions annoyed me a lot. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits