[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 358307. dgoldman added a comment. Minor TODO change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ex

[clang] 3d89fb4 - [RISCV] Support machine constraint "S"

Author: Fangrui Song Date: 2021-07-13T09:30:09-07:00 New Revision: 3d89fb4d13bc3af1c3643a310b90fce51a649119 URL: https://github.com/llvm/llvm-project/commit/3d89fb4d13bc3af1c3643a310b90fce51a649119 DIFF: https://github.com/llvm/llvm-project/commit/3d89fb4d13bc3af1c3643a310b90fce51a649119.diff

[PATCH] D105254: [RISCV] Support machine constraint "S"

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d89fb4d13bc: [RISCV] Support machine constraint "S" (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D105254?vs=355749&id=358308#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

mbenfield updated this revision to Diff 358309. mbenfield added a comment. undo commenting out in source_location.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104887/new/ https://reviews.llvm.org/D104887 Files: clang/include/clang/AST/Expr.

[PATCH] D105892: [OpenCL] Add verbosity when checking support of read_write images

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105892/new/ https://reviews.llvm.org/D105892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. > What you're describing sounds like clang-tidy but perhaps with improved > support for composing source modifications from fix-its, or do you envision > something rather different? All my uses of clang-tidy require extensive command line arguments to handle c

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

kito-cheng updated this revision to Diff 358314. kito-cheng added a comment. Changes: - Add 2 testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105091/new/ https://reviews.llvm.org/D105091 Files: clang/lib/Driver/ToolChains/RISCVToolchain

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

efriedma added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:831 +// 64bit version of popcntb for 64bit sized unsigned long. +let isCodeGenOnly = 1 in +def POPCNTB8 : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS), I'm sort of confused

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2874404 , @MyDeveloperDay wrote: >> What you're describing sounds like clang-tidy but perhaps with improved >> support for composing source modifications from fix-its, or do you envision >> something rather diffe

[clang] 7a20670 - AST: correct name decoration for swift async functions on Windows

Author: Saleem Abdulrasool Date: 2021-07-13T10:04:11-07:00 New Revision: 7a20670d168af31ef77209f43ca0622800ce513a URL: https://github.com/llvm/llvm-project/commit/7a20670d168af31ef77209f43ca0622800ce513a DIFF: https://github.com/llvm/llvm-project/commit/7a20670d168af31ef77209f43ca0622800ce513a.

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

MaskRay added a comment. The update was not what expected. I said that there should be just one RUN line and you can place -T, -u, --defsym and all linker options on that line. Each new RUN line consumes some resources on testing machines. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

necipfazil created this revision. necipfazil added reviewers: rsmith, morehouse, kcc, cfe-commits, llvm-commits. Herald added subscribers: ormris, dexonsmith, dang, hiraditya. necipfazil requested review of this revision. Herald added projects: clang, LLVM. This is the first of the patch series th

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity added a comment. Bump. 🙂 I would prefer this check to be able to go into Clang-Tidy 13 if it's okay, together with the other check I implemented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D20689/new/ https://reviews.llvm.org/D20689

[clang] 03282f2 - [clang] C++98 implicit moves are back with a vengeance

Author: Matheus Izvekov Date: 2021-07-13T19:16:49+02:00 New Revision: 03282f2fe14e9dd61aaeeda3785f56c7ccb4f3c9 URL: https://github.com/llvm/llvm-project/commit/03282f2fe14e9dd61aaeeda3785f56c7ccb4f3c9 DIFF: https://github.com/llvm/llvm-project/commit/03282f2fe14e9dd61aaeeda3785f56c7ccb4f3c9.dif

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

This revision was automatically updated to reflect the committed changes. Closed by commit rG03282f2fe14e: [clang] C++98 implicit moves are back with a vengeance (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105756/new/ https

[PATCH] D105014: added some example code for llvm::Expected

dblaikie added a comment. In D105014#2873739 , @sammccall wrote: > In D105014#2872674 , @dblaikie > wrote: > >> +@lhames for context as the author/owner of `llvm::Error` and associated >> things. >> >> Perhaps i

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. > FWIW, if you use the compile commands database, the only thing you need to do > on the command line is specify the checks to enable or disable. The project I work on doesn't have/use compile commands databases? if you are make based system or some other legacy

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dblaikie added a comment. In D105457#2873838 , @glaubitz wrote: > In D105457#2873294 , @dyung wrote: > >> This change I suspect is causing a build failure on a build bot. >> >> https://lab.llvm.org/buildbot/#/buil

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil created this revision. necipfazil added reviewers: rjmccall, rsmith, morehouse, kcc, llvm-commits, cfe-commits. necipfazil requested review of this revision. Herald added a project: clang. Create and add generalized type identifier metadata to indirect calls, and to functions that may

[PATCH] D105911: [CallGraphSection] Introduce CGSectionFuncComdatCreator pass

necipfazil created this revision. necipfazil added reviewers: lattner, morehouse, kcc, llvm-commits. Herald added subscribers: ormris, hiraditya, mgorny. necipfazil requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Create comdats for fun

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

vsavchenko updated this revision to Diff 358336. vsavchenko added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105692/new/ https://reviews.llvm.org/D105692 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Could probably haggle over the tests some more, but might be diminishing returns at this point. Looks good! Might suggest separating the code cleanup mlir changes from the warning change

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2874464 , @atomgalaxy wrote: > It's very difficult to use a compile_commands database if you can't > actually check out all the code and a remote service builds it for you. In D69764#2874514

[PATCH] D105693: [analyzer][solver][NFC] Refactor how we detect (dis)equalities

vsavchenko updated this revision to Diff 358341. vsavchenko marked an inline comment as done. vsavchenko added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105693/new/ https://reviews.llvm.org/D105693 Files: clang/lib/St

[PATCH] D105693: [analyzer][solver][NFC] Refactor how we detect (dis)equalities

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:687 /// A small helper structure representing symbolic equality. /// martong wrote: > This is no longer a `structure`. Good catch! Repository: rG LLVM G

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. OK, thanks for putting a summary. I now got a good idea why you need both. At the same time, take a look at D105692 . I'm about to land it and I think it's going to be useful for you. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

ldionne added a comment. I'm not entirely sure I understand the purpose of this patch. So the idea is that let's say a tool suggests including `<__algorithm/find.h>` to get the definition of `std::find` as a IWYU fix-it sort of suggestion, the user would naively do that, and then the compiler (

[clang] 303ddb6 - Fix utils/update_cc_test_checks/check-globals.test on stand-alone builds

Author: Tom Stellard Date: 2021-07-13T10:47:30-07:00 New Revision: 303ddb60a2d28fb7603266d8977f69ac77b194dd URL: https://github.com/llvm/llvm-project/commit/303ddb60a2d28fb7603266d8977f69ac77b194dd DIFF: https://github.com/llvm/llvm-project/commit/303ddb60a2d28fb7603266d8977f69ac77b194dd.diff

[PATCH] D105873: Fix utils/update_cc_test_checks/check-globals.test on stand-alone builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG303ddb60a2d2: Fix utils/update_cc_test_checks/check-globals.test on stand-alone builds (authored by tstellar). Repository: rG LLVM Github Monorep

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

lebedev.ri added a comment. In D105439#2874706 , @ldionne wrote: > I'm not entirely sure I understand the purpose of this patch. So the idea is > that let's say a tool suggests including `<__algorithm/find.h>` to get the > definition of `std::find` as a

[clang] 60bd8cb - [analyzer][solver][NFC] Refactor how we detect (dis)equalities

Author: Valeriy Savchenko Date: 2021-07-13T21:00:30+03:00 New Revision: 60bd8cbc0c84a41146b1ad6c832fa75f48cd2568 URL: https://github.com/llvm/llvm-project/commit/60bd8cbc0c84a41146b1ad6c832fa75f48cd2568 DIFF: https://github.com/llvm/llvm-project/commit/60bd8cbc0c84a41146b1ad6c832fa75f48cd2568.d

[clang] f26deb4 - [analyzer][solver][NFC] Introduce ConstraintAssignor

Author: Valeriy Savchenko Date: 2021-07-13T21:00:30+03:00 New Revision: f26deb4e6ba7e00c57b4be888c4d20c95a881154 URL: https://github.com/llvm/llvm-project/commit/f26deb4e6ba7e00c57b4be888c4d20c95a881154 DIFF: https://github.com/llvm/llvm-project/commit/f26deb4e6ba7e00c57b4be888c4d20c95a881154.d

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf26deb4e6ba7: [analyzer][solver][NFC] Introduce ConstraintAssignor (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D105693: [analyzer][solver][NFC] Refactor how we detect (dis)equalities

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60bd8cbc0c84: [analyzer][solver][NFC] Refactor how we detect (dis)equalities (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge added a comment. To be honest, I don't really understand this error. It seems to come from a compile step (not a link step), and it comes from the assembler and says "symbol ... is already defined"? I don't think I've seen an error like that before. (Typically, errors about duplicate def

[clang] 01d3a3d - [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

Author: Artem Belevich Date: 2021-07-13T11:09:14-07:00 New Revision: 01d3a3dcabaf862581b1d1aee604fcee6a18b240 URL: https://github.com/llvm/llvm-project/commit/01d3a3dcabaf862581b1d1aee604fcee6a18b240 DIFF: https://github.com/llvm/llvm-project/commit/01d3a3dcabaf862581b1d1aee604fcee6a18b240.diff

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01d3a3dcabaf: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. > so there's something like precedent here I think its worth mentioning, that my personal preference would STILL be to land this inside clang-format with default configuration of "OFF", where there is also significant existing precedent for passes that change non

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2874706 , @ldionne wrote: > I'm not entirely sure I understand the purpose of this patch. So the idea is > that let's say a tool suggests including `<__algorithm/find.h>` to get the > definition of `std::find` as a IWYU

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2874733 , @lebedev.ri wrote: > In D105439#2874706 , @ldionne wrote: > >> I'm not entirely sure I understand the purpose of this patch. So the idea is >> that let's say a tool sug

[PATCH] D105629: [TSan] Add SystemZ support

iii updated this revision to Diff 358363. iii added a comment. Based on Ulrich's feedback I tested the series on RHEL7, which, in addition to an old kernel, contains an old glibc and an old toolchain. This uncovered a few extra issues, which are fixed here: - Call __tls_get_offset() in order to f

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen updated this revision to Diff 358364. samitolvanen added a comment. Moved the alias creation to module level inline assembly to avoid issues with LowerTypeTestsModule, based on pcc's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra updated this revision to Diff 358365. tra added a comment. Updated LD/ST generation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105384/new/ https://reviews.llvm.org/D105384 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/Co

[clang] e4585d3 - Revert "[PowerPC][NFC] Power ISA features for Semachecking"

Author: Victor Huang Date: 2021-07-13T13:13:34-05:00 New Revision: e4585d3f4e1f076ff12db65259924492f5912b19 URL: https://github.com/llvm/llvm-project/commit/e4585d3f4e1f076ff12db65259924492f5912b19 DIFF: https://github.com/llvm/llvm-project/commit/e4585d3f4e1f076ff12db65259924492f5912b19.diff

[clang] 781929b - [PowerPC][NFC] Power ISA features for Semachecking

Author: Victor Huang Date: 2021-07-13T13:13:34-05:00 New Revision: 781929b4236bc34681fb0783cf7b6021109fe28b URL: https://github.com/llvm/llvm-project/commit/781929b4236bc34681fb0783cf7b6021109fe28b DIFF: https://github.com/llvm/llvm-project/commit/781929b4236bc34681fb0783cf7b6021109fe28b.diff

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1203 +if (!Opts.ShouldSupportSymbolicIntegerCasts) + return VisitSymExpr(Sym); + vsavchenko wrote: > ASDenysPetrov wrote: > > vsavchenko wrote: > >

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik updated this revision to Diff 358373. shafik added a comment. - Modified `FindTypeForAutoReturnForDIE` to take into account if we have multiple symbols with the same name. - Modified `ParseSubroutine` to take into account that case we get the definition first, this can happen when we set

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. I took another looks and noticed: also clang/docs/UsersManual.rst and maybe clang/docs/AddressSanitizer.rst also could you add some trivial test that the flag affects generated

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2874790 , @MyDeveloperDay wrote: >> so there's something like precedent here > > I think its worth mentioning, that my personal preference would STILL be to > land this inside clang-format with default configurati

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

tra added a comment. Ugh. I broke the cuda-bad-arch.cu test. Comment at: clang/test/Driver/cuda-bad-arch.cu:30 // RUN: | FileCheck -check-prefix OK %s // RUN: %clang -### -target x86_64-linux-gnu --cuda-gpu-arch=gfx90a -c %s 2>&1 \ // RUN: | FileCheck -check-prefix OK %s --

[PATCH] D105876: OMPIRBuilder for Interop directive

jdoerfert added a subscriber: mikerice. jdoerfert added a comment. There are 3 clang tidy warnings to address. Overall this is a good first step. @ABataev @mikerice is there any major problem with this? If not we should try to get it in asap and improve it in tree. Comment at

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

HazardyKnusperkeks added a comment. I already said I would like that in `clang-format` and would directly add that to my config. I also think that there should be no problem in having that in `clang-format`, include sorting has a bigger chance of breaking code, yeah only with poorly designed h

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

labrinea added a comment. In D94098#2868751 , @efriedma wrote: > The part I'm confused about is that you're forcing it to use "*r". At the IR > level, LLVM handles something like `call void asm sideeffect "#$0", "r"([8 x > i64] %c)` fine. You'll have t

[PATCH] D105926: [PowerPC] Extra test case for LDARX

Conanap created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Conanap requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An extra test case added for the builtin __LDARX. Repository: rG LLVM Github Monorepo https://

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

dyung added a comment. I think your change also broke cuda-flush-denormals-to-zero.cu: https://lab.llvm.org/buildbot/#/builders/139/builds/7048 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105295/new/ https://reviews.llvm.org/D105295 ___

[clang] 25629bb - Fix cuda-bad-arch.cu test.

Author: Artem Belevich Date: 2021-07-13T11:57:25-07:00 New Revision: 25629bb45f0a4b8c8e99dbde4f4a7e3d980b9fd7 URL: https://github.com/llvm/llvm-project/commit/25629bb45f0a4b8c8e99dbde4f4a7e3d980b9fd7 DIFF: https://github.com/llvm/llvm-project/commit/25629bb45f0a4b8c8e99dbde4f4a7e3d980b9fd7.diff

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

tra added a comment. In D105295#2874935 , @tra wrote: > Ugh. I broke the cuda-bad-arch.cu test. Should be fixed in 25629bb45f0a4b8c8e99dbde4f4a7e3d980b9fd7 Repository: rG LLVM Git

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2874805 , @cjdb wrote: > In D105439#2874733 , @lebedev.ri > wrote: > >> In D105439#2874706 , @ldionne >> wrote: >> >>> I'm not entirely

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

glaubitz added a comment. In D105457#2874516 , @dblaikie wrote: > Any ideas what version of the standard library these buildbots are using? > This /looks/ a bit like a bug in the standard library in use, perhaps? (also > because it's not showing up in l

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung added a comment. In D105457#2875058 , @glaubitz wrote: > In D105457#2874516 , @dblaikie > wrote: > >> Any ideas what version of the standard library these buildbots are using? >> This /looks/ a bit like a

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:406 + virtual lldb::TypeSP + FindTypeForAutoReturnForDIE(const DWARFDIE &die, teemperor wrote: > If this is virtual then I guess `SymbolFileDWARFDwo` should overl

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

efriedma added a comment. In D94098#2874976 , @labrinea wrote: > In D94098#2868751 , @efriedma wrote: > >> > > but in my honest opinion I don't see the benefit. The problem is, there isn't really any point to supp

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei created this revision. lei added reviewers: stefanp, nemanjai, power-llvm-team. Herald added subscribers: shchenz, hiraditya. lei requested review of this revision. Herald added projects: clang, LLVM. Implement a subset of builtins required for compatiblilty with AIX XL compiler. Repository:

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

aaron.ballman accepted this revision. aaron.ballman added a comment. In D20689#2874473 , @whisperity wrote: > Bump. 🙂 I would prefer this check to be able to go into Clang-Tidy 13 if it's > okay, together with the other check I implemented. @alexfh has h

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

morehouse added inline comments. Comment at: clang/docs/CallGraphSection.rst:58 + +A type identifier may be repeated in different entries. The id value 0 is +reserved for unknown and used for indirect targets with unknown type. Why would a type ID be repeated?

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 358397. NeHuang marked 4 inline comments as done. NeHuang added a comment. Addressed review comments from Nemanja. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/D102875 Fil

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei updated this revision to Diff 358409. lei added a comment. update tc to only check for pwr7 and up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105930/new/ https://reviews.llvm.org/D105930 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

furdyna added a comment. > I think its worth mentioning, that my personal preference would STILL be to > land this inside clang-format with default configuration of "OFF", > I would be interested to know how many people would be unhappy if we stated > that "sorting includes" and "namespace comm

[PATCH] D105937: [OpenMP] Encode `omp [...] assume[...]` assumptions with `omp[x]` prefix

jdoerfert created this revision. jdoerfert added a reviewer: jhuber6. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Since these assumptions are coming from OpenMP it ma

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

necipfazil added inline comments. Comment at: clang/docs/CallGraphSection.rst:58 + +A type identifier may be repeated in different entries. The id value 0 is +reserved for unknown and used for indirect targets with unknown type. morehouse wrote: > Why would a typ

[PATCH] D105876: OMPIRBuilder for Interop directive

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6310-6311 + int DependClauseCount = 0; + for (const auto *DC : S.getClausesOfKind()) +DependClauseCount++; + assert(DependClauseCount <= 1 && "Multiple OMPDependClause not supported."); -

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

kstoimenov updated this revision to Diff 358422. kstoimenov added a comment. Modified UsersManual.rst and added a test. Couldn't find a relevant section in AddressSanitizer.rst and adding a new one is outside of the scope of this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM aside from a formatting nit. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1574 + : GCCBuiltin<"__builtin_ppc_cmprb">, +Intrinsic<[llvm_i32_ty],

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

dschuff added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/varargs.ll:5 -target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128" -target triple = "wasm32-unknown-unknown" +target triple = "wasm32-unknown-emscripten" sunfish wrote: > It appears th

[PATCH] D105629: [TSan] Add SystemZ support

iii updated this revision to Diff 358431. iii added a comment. - Fix style issues (seems like arc diff is linting only the top commit?). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105629/new/ https://reviews.llvm.org/D105629 Files: clang/lib/

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I guess Phabricator just sent this back to review automatically when you updated the diff? Just mark this as 'needs review' again when this is ready for review. I'll send this

[clang] 18c1941 - [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

Author: Victor Huang Date: 2021-07-13T16:55:09-05:00 New Revision: 18c19414eb70578d4c487d6f4b0f438aead71d6a URL: https://github.com/llvm/llvm-project/commit/18c19414eb70578d4c487d6f4b0f438aead71d6a DIFF: https://github.com/llvm/llvm-project/commit/18c19414eb70578d4c487d6f4b0f438aead71d6a.diff

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18c19414eb70: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for… (authored by NeHuang). Changed prior to commit: htt

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2874123 , @jdoerfert wrote: > In D102107#2867693 , @ABataev wrote: > >> In D102107#2867670 , >> @josemonsalve2 wrote: >> >>> In D10210

[PATCH] D105943: [clang-format++] Create a new variant of the clang-format tool to allow additional code mutating behaviour such as East/West Const Fixer

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, aaron.ballman. MyDeveloperDay added projects: clang-format, clang. Herald added a subscriber: mgorny. MyDeveloperDay requested review of this revision. There has been much discussion about the relat

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. Because I don't want to move this review on other than to maintain it for future rebasing, I've created a new review for the concept of the new tool D105943: [clang-format++] Create a new variant of the clang-format tool to allow additional code mutating behavi

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dblaikie added a comment. In D105457#2874783 , @nridge wrote: > To be honest, I don't really understand this error. It seems to come from a > compile step (not a link step), and it comes from the assembler and says > "symbol ... is already defined"? I d

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Conanap requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch implements store, load, move from and to registers relate

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1063 +<< ModuleName; +return ImportingInstance.getFrontendOpts().AllowPCMWithCompilerErrors; + } vsapsai wrote: > Can we get in infinite loop with `AllowPCMWithCompil

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

arphaman updated this revision to Diff 358457. arphaman added a comment. Sorry, took a bit longer than anticipated. I updated the patch to address reviewer's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105052/new/ https://reviews.llvm.org/D105052 Files: clang/include/clan

[PATCH] D105869: [Driver] fix PowerPC SPE musl dynamic linker name

pattop added a comment. Here is the corresponding gcc patch: https://github.com/richfelker/musl-cross-make/commit/5b405688ee23df621e5b33911e2aa7b046ef632e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105869/new/ https://reviews.llvm.org/D105869

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

morehouse added a comment. I think we want a C++ test as well, with class functions, templates, etc. Also, please rebase the patch onto any parent commits, so that it builds properly and the clang-tidy warnings go away. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:2288 +}

[PATCH] D105939: [OpenMP] Add IDs to OpenMP remarks

jhuber6 updated this revision to Diff 358461. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding test case for IDs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105939/new/ https://reviews.llvm.o

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

necipfazil updated this revision to Diff 358463. necipfazil added a comment. rebase, fix nits in docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105907/new/ https://reviews.llvm.org/D105907 Files: clang/docs/CallGraphSection.rst clang/inclu

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. R

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham marked 5 inline comments as done. bnbarham added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1063 +<< ModuleName; +return ImportingInstance.getFrontendOpts().AllowPCMWithCompilerErrors; + } bnbarham wrote: > vsapsai

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham updated this revision to Diff 358465. bnbarham edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105328/new/ https://reviews.llvm.org/D105328 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td cla

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 358481. TaoPan added a comment. Change select of BB sections to IMAGE_COMDAT_SELECT_NODUPLICATES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 Files: clang/include/c

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov created this revision. mizvekov updated this revision to Diff 358468. mizvekov added a comment. mizvekov updated this revision to Diff 358483. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. . mizvekov added a comment.

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov updated this revision to Diff 358488. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105951/new/ https://reviews.llvm.org/D105951 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/lib/Sema/SemaStmt.cpp

[clang] 8a0f116 - Fix test trying to write a spurious output file into the source

Author: Richard Smith Date: 2021-07-13T18:58:24-07:00 New Revision: 8a0f1163d02c77c6e764929b66c26ba196cfc549 URL: https://github.com/llvm/llvm-project/commit/8a0f1163d02c77c6e764929b66c26ba196cfc549 DIFF: https://github.com/llvm/llvm-project/commit/8a0f1163d02c77c6e764929b66c26ba196cfc549.diff

[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

nemanjai created this revision. nemanjai added reviewers: PowerPC, ZhangKang. Herald added subscribers: shchenz, kbarton, hiraditya. nemanjai requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This provides intrinsics for emitting instruc

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

nemanjai added a subscriber: ZhangKang. nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3087 // RM should be set. +let hasSideEffects = 1 in { def MTFSB0 : XForm_43<63, 70, (outs), (ins u5imm:$FM), I think we should conservat

[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:4484 +// as an implicit def for all of them. +let Predicates = [HasFPU] in { +let Defs = [RM] in { @ZhangKang You modified this code most recently. Please provide your opinion he

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1712 + COFF::IMAGE_SCN_MEM_READ | COFF::IMAGE_SCN_LNK_COMDAT, + SectionKind::getText(), COMDATSymName, + COFF::IMAGE_COMDAT_SELECT_NODUPLICATES, UniqueID); -

<    1   2   3   >