jdoerfert added a subscriber: mikerice.
jdoerfert added a comment.
There are 3 clang tidy warnings to address. Overall this is a good first step.
@ABataev @mikerice is there any major problem with this? If not we should try
to get it in asap and improve it in tree.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:133
+enum class OMPInteropType { Unknown, Target, TargetSync };
+
----------------
move into the omp namespace and add doxygen documentation.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:797
+ llvm::Value *NumDependences,
+ llvm::Value *DependenceAddress, int HaveNowaitClause);
+
----------------
Also elsewhere.
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2192
+ ConstantInt *InteropTypeVal =
+ ConstantInt::get(M.getContext(), APInt(64, (int)InteropType, true));
+ if (NumDependences == nullptr) {
----------------
Also similarly elsewhere.
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2194
+ if (NumDependences == nullptr) {
+ NumDependences = ConstantInt::get(M.getContext(), APInt(32, 0, true));
+ PointerType *PointerTy_0 = llvm::Type::getInt8PtrTy(M.getContext());
----------------
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2264
+ return Builder.CreateCall(Fn, Args);
+}
+
----------------
Remove all the `llvm::` in this file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105876/new/
https://reviews.llvm.org/D105876
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
