MyDeveloperDay added a comment. > so there's something like precedent here
I think its worth mentioning, that my personal preference would STILL be to land this inside clang-format with default configuration of "OFF", where there is also significant existing precedent for passes that change non whitespace and even add tokens. I still believe clang-format is the best location, I think its the most optimal, and I think its the fairest (because those that want it get it, and those that don't aren't forced to have it). But doing this as another tool would be a `compromise`, in my view an inferior one to it being in clang-format, but at least we could set out clear goals where allowing code modification was the intent (as this seems to be the major sticking point) I would be interested to know how many people would be unhappy if we stated that "sorting includes" and "namespace comments" had to be removed from clang-format and into the new tool! I am thinking it would be fairly significant. (I'm not suggesting we would, just making a point) So you know, I'm pushing because I'm being ask privately to land this, because I assume people want to use it, but maybe don't want to voice their opinions publicly. I don't want to fragment the community by pushing an agenda (something I see you seem to care about), but I would also like to think that those of us who contribute to clang-format regularly can help shape a future for it moving forward. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
