[PATCH] D95342: [clang][cli] Store LangStandard::Kind in LangOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2154cffdc2a6: [clang][cli] Store LangStandard::Kind in LangOptions (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D95343: [clang][cli] Port GNU language options to marshalling system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG956d8e02e8a5: [clang][cli] Port GNU language options to marshalling system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D95419: [clangd] Fix filename completion at the end of file

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for puzzling this one out, i thought it would be in lexer... Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1127 + // If preamble doesn't end on a new li

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

grimar added a comment. I like this approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D95246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D95344: [clang][cli] Accept strings instead of options in ImpliedByAnyOf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9338f3a586bc: [clang][cli] Accept strings instead of options in ImpliedByAnyOf (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CH

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:433 PreambleSymbols.update( -Uri, std::make_unique(std::move(*IF->Symbols)), +FilePath ? *FilePath : (consumeError(FilePath.takeError()), Uri), +std::make_unique(s

[PATCH] D95419: [clangd] Fix filename completion at the end of file

kadircet updated this revision to Diff 319229. kadircet marked an inline comment as done. kadircet added a comment. - Rewrite the condition as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95419/new/ https://reviews.llvm.org/D95419 Files

[PATCH] D95419: [clangd] Fix filename completion at the end of file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64cdba65bbfa: [clangd] Fix filename completion at the end of file (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D95421: [NFC] Refine some uninitialized used variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3b0acdc6fb5: [NFC] Refine some uninitialized used variables. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95421/new/ https://revie

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. Basically LGTM - (I'm happy for this to land either with or without my comments being addressed). Would be nice to get a second reviewer to confirm they're happy. C

[PATCH] D95365: [clangd] Add include-fixer fixit for no_member_template diagnostic.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68dbd1aefe5a: [clangd] Add include-fixer fixit for no_member_template diagnostic. (authored by hokein). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

jhenderson added a comment. I did briefly consider one alternative, which was to build these directly into FileCheck, but it doesn't quite feel like the right approach for FileCheck to need to know system level details. In practice, I think the lit substitution may be the best way forward overa

[PATCH] D95345: [clang][cli] Port GPU-related language options to marshalling system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7025fef3f653: [clang][cli] Port GPU-related language options to marshalling system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous marked an inline comment as done. nomanous added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:10111-10124 +// Check the static member's type given in the explicit instantiation +// definition against the one in the class template. This won't happe

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. Restoring the old behaviour for LLVM 12 may or may not help the Chrome/Chromium people: if they also regularly build with clang from git, they would need to handle this change anyway. However, if it does help, then it sounds like a good idea to me. > So we should be wor

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2490 + continue; +std::string::size_type position1 = Constraints.find("={eax}"); +if (position1 != std::string::npos) { If `Clobber` is `edx` only, we shouldn't chang

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

fhahn added inline comments. Comment at: llvm/include/llvm/Analysis/ObjCARCRVAttr.h:28 + +static inline const char *getRVAttrValStr(bool Retain) { + return Retain ? "retain" : "claim"; Is there a place the attributes could be documented? Comme

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added a comment. Ok, reverted. If there's a doubt, then I guess it's the best solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 ___ cfe-commits m

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion. kentsommer wrote: > MyDeveloperDay wrote: > >

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Requesting changes so that it appears correctly in the review queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ http

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske updated this revision to Diff 319261. balazske added a comment. Adding a test, fixing other problems revealed by the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 Files: clang/lib/AST/Exp

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2490 + continue; +std::string::size_type position1 = Constraints.find("={eax}"); +if (position1 != std::string::npos) { pengfei wrote: > If `Clobber` is `edx` only,

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske added a comment. I could add a test in ToolingTests, lit test is much more difficult to add because the function is normally not called on "bad" code. Comment at: clang/lib/AST/Expr.cpp:1403 +if (CalleeType.isNull()) + return CreateDependentType(); +

[PATCH] D95435: [clang][aarch64][WOA64][docs] Release note for longjmp crash with /guard:cf

peterwaller-arm created this revision. peterwaller-arm added a reviewer: richard.townsend.arm. Herald added subscribers: danielkiss, kristof.beyls. peterwaller-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a release note workaroun

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:433 PreambleSymbols.update( -Uri, std::make_unique(std::move(*IF->Symbols)), +FilePath ? *FilePath : (consumeError(FilePath.takeError()), Uri), +std::make_unique

[PATCH] D95423: [clangd] Add std::size_t to StdSymbol mapping

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This might annoy people occasionally, but so does the current behavior. I guess inserting *nothing* might be better, we could have a list of symbols known to have no insertable header. Bu

[PATCH] D95439: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94614/new/ https://reviews.llvm.org/D94614 ___ cfe-commits mailing list cfe-c

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

This revision was automatically updated to reflect the committed changes. ZarkoCA marked an inline comment as done. Closed by commit rG028d7a36681f: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D95408: [Sema][C] members of anonymous struct inherit QualType

aaron.ballman added a comment. I know we don't have to deal with `restrict` because that qualifies a pointer (so there's no way to use it with an anonymous struct), but are there others? There's `DeclSpec::TQ_unaligned` (which has no corresponding qualifier in `Qualifiers::TQ` despite the comme

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319276. abhina.sreeskantharajan added a comment. Herald added subscribers: mgorny, emaste. This patch makes the following changes: - Define LLVM_HOST_TRIPLE for lld tests. (This was the project that didn't have host defined.) - Change %err_no

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan requested review of this revision. abhina.sreeskantharajan marked 4 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:349-354 +if (re.match(r's390x-.*-zos', triple)): +

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

aaron.ballman added a comment. Pinging the reviewers to help with the naming questions. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2867 +extern const internal::MapAnyOfMatcher +callOrConstruct; + steveire wrote: > aaron.ballman wrote: > > ste

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 319282. FreddyYe added a comment. If Clobber is edx only, don't change "={eax}" to "=&{eax}". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGe

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 319284. FreddyYe added a comment. refine clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/ms-inl

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

RedDocMD added a comment. On further digging as to how pointer-to-members are handled in StaticAnalyzer, I discovered that in `BasicValueFactory::accumCXXBase() for the example given in my test produces the two `CXXBaseSpecifier` for the pointer-to-member. At line 195, one base specifier is add

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

Anastasia created this revision. Anastasia added a reviewer: mantognini. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. References to functions are less permissive than pointers to functions and therefore some use cases could be allowed for example: - For

[PATCH] D82862: [ThinLTO] Always parse module level inline asm with At&t dialect

uweigand added a comment. In D82862#2513044 , @rnk wrote: > In D82862#2512908 , @uweigand wrote: > >> So why do you want GNU inline asm for clang-cl anyway? I thought the whole >> point of clang-cl was to be comp

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added inline comments. Comment at: llvm/lib/IR/Instruction.cpp:580 +if (auto *CB = dyn_cast(this)) + return objcarc::hasRetainRVOrClaimRVAttr(CB); +return false; fhahn wrote: > rjmccall wrote: > > nikic wrote: > > > This change looks pretty

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

fhahn added inline comments. Comment at: llvm/lib/IR/Instruction.cpp:580 +if (auto *CB = dyn_cast(this)) + return objcarc::hasRetainRVOrClaimRVAttr(CB); +return false; ahatanak wrote: > fhahn wrote: > > rjmccall wrote: > > > nikic wrote: > > > > This

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, sscalpone, sameeranjoshi, SouraVX, tskeith, kiranktp, AMDChirag. Herald added a subscriber: dang. Herald added a reviewer: jansvoboda11. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D95417: [NFC] Disallow unused prefixes under clang/test/CodeGen

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c0d009a88f2: [NFC] Disallow unused prefixes under clang/test/CodeGen (authored by mtrofin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95417/new/ https:

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/references.cl:24 +void templ() { + // FIXME: We miss to diagnose the reference to function. + T loc; //expected-error{{declaration of reference variable 'loc' requires an initializer}} I hav

[PATCH] D95450: [clangd] Respect ReferencesParams.context.includeDeclarations

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Unfortunately this treats overr

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319309. abhina.sreeskantharajan added a comment. Fix CI: Other projects like flang also do not specify LLVM_HOST_TRIPLE. If this is not specified, set the triple to an empty string. I also added one more error code %errc_EISDIR and updated th

[PATCH] D95439: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:81 case diag::err_func_def_incomplete_result: + case diag::err_field_incomplete_or_sizeless: // Incomplete type diagnostics should have a QualType argument for the what

[PATCH] D95423: [clangd] Add std::size_t to StdSymbol mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rG9190f17a7cc5: [clangd] Add std::size_t to StdSymbol mapping (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95423/new/ https://reviews

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 319315. whisperity added a comment. - Added a fallback case to also diagnose when Clang parsed the two types to be canonically the same (we will elaborate a few cases of such equivalences later, such as `typedef`s) - Fixed Clang-Format and Clang-Tidy wa

[PATCH] D95451: [clangd] references: decls of overrides of x are refs to x, not decls

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This requires a second index query for re

[PATCH] D95229: [clangd] Treat optional field type mismatches as soft failures

kadircet updated this revision to Diff 319321. kadircet marked 4 inline comments as done. kadircet added a comment. As discussed offline, only treat "null" fields as missing, rather than allowing type mismatches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D94806: [OpenMP] Add support for mapping names in mapper API

MaskRay added a comment. In your commit the message has just `Reviewers:`. The `Reviewers:` list does not necessarily mean all the people on the list have acknowledged the patch so `Reviewers:` is mostly useless. Many people agree that both `Reviewed:` & `Differential Revision:` should be prese

[PATCH] D95075: [hip] Fix `` compilation on Windows with VS2019.

MaskRay added a comment. In your commit the message does not include `Reviewed by:`. Many people agree that both `Reviewed by:` & `Differential Revision:` should be present. The `Reviewed by:` list indicates people who acknowledged the patch. (The `Reviewers:` list does not necessarily mean all

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

MaskRay added a comment. In your commit the message does not include `Reviewed by:`. Many people agree that both `Reviewed by:` & `Differential Revision:` should be present. The `Reviewed by:` list indicates people who acknowledged the patch. (The `Reviewers:` list does not necessarily mean all

[PATCH] D95017: [clang-format] add case aware include sorting

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion. curdeius wrote: > kentsommer wrote: > >

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c03f7d7d04c: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target… (authored by tianshilei1992). Repository: rG LLVM Github Mo

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

Bigcheese added a comment. In D94472#2519838 , @jansvoboda11 wrote: > In D94472#2508018 , @dexonsmith > wrote: > >> `strict` mode additionally uses the `GeneratedArgs1` to fill >> CompilerInvocation, indirectly c

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

tra added a comment. @hliao -- Can you take a look at https://bugs.llvm.org/show_bug.cgi?id=48866. This patch may be relevant there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___

[PATCH] D95451: [clangd] references: decls of overrides of x are refs to x, not decls

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/XRefs.cpp:1406 + Req.Limit = Limit; + auto QueryIndex = [&](bool AllowAttributes) { +if (Req.IDs.empty() || !Inde

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 319337. MaskRay marked 6 inline comments as done. MaskRay added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 Files: clang/docs/ReleaseN

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM I think, it would be good to get input from other reviewers Comment at: clang/unittests/Format/FormatTest.cpp:13696 " }\n" -

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Conanap created this revision. Conanap added reviewers: nemanjai, saghir, PowerPC. Conanap added projects: LLVM, clang, PowerPC. Herald added a subscriber: kbarton. Conanap requested review of this revision. Previously related differential (exploit xxsplti32dx for vectors) here: https://reviews.l

[PATCH] D95459: Add helper functionality for parsing different attribute syntaxes in arbitrary order

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie, jyknight, rjmccall. aaron.ballman requested review of this revision. In Clang today, we parse the different attribute syntaxes (`__attribute__`, `__declspec`, and `[[]]`) in a fairly rigid order. This leads to c

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rjmccall added inline comments. Comment at: clang/include/clang/AST/CXXInheritance.h:77 - CXXBasePath() = default; + /// Additional data stashed on the base path by its consumers. + union { rsmith wrote: > rjmccall wrote: > > rsmith wrote: > > > rjmccall wro

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

leonardchan added a comment. Hi. Up until this point, we've noticed that this patch can produce different formatted files depending on amount of whitespace. For example, given (A): #include namespace fuzzing {} `clang-format` with this patch would produced (B): #include namespace fuz

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 319348. akhuang marked an inline comment as done. akhuang added a comment. change to function returning a number, fill in ItaniumMangle function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

This revision was automatically updated to reflect the committed changes. Closed by commit rGd92413a45e20: [clangd] Selection handles CXXBaseSpecifier (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95231/new/ https://reviews.l

[PATCH] D95338: [clangd] FindTarget resolves base specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG7730599c4164: [clangd] FindTarget resolves base specifier (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95338/new/ https://reviews.l

[PATCH] D94820: Support for instrumenting only selected files or functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG4edf35f11a9e: Support for instrumenting only selected files or functions (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D94820?vs=318257&id=319359#toc Repository: rG LLVM Git

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

rnk added a comment. I see a potential issue, but I think this looks good otherwise. Comment at: clang/lib/AST/ItaniumMangle.cpp:210 +if (Number == 0) + return getAnonymousStructId(Lambda); +return Number; This has the potential to create a situati

[PATCH] D83250: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver

jrmuizel added a comment. This seems to have broken compilation for me on 10.15. The stdio.h from the 10.15 SDK there's the following usage: #if TARGET_OS_EMBEDDED #define __swift_unavailable_on(osx_msg, ios_msg) __swift_unavailable(ios_msg) #else #define __swift_unavailable_on(osx_msg,

[PATCH] D83250: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver

jrmuizel added a comment. Actually, this may just be a local configuration issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83250/new/ https://reviews.llvm.org/D83250 ___ cfe-commits mailing list cfe

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

Anastasia updated this revision to Diff 319369. Anastasia added a comment. Improved diagnostics to cover more cases. NOTE that this now also contains similar improvements for the pointers to member functions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95442/new/ https://reviews.llv

[PATCH] D95017: [clang-format] add case aware include sorting

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion. MyDeveloperDay wrote: > curdeius wro

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/references.cl:29 +void foo(); +void test(void (&par)()) { + void (&loc)(); Anastasia wrote: > oops, I thought this was covered in my patch. I will see if there is a quick > fix and if not I w

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

This revision was automatically updated to reflect the committed changes. Closed by commit rG31d375f178c2: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94391/ne

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

rsmith accepted this revision. rsmith added a comment. Clang side looks good to me. On the LLVM side, is it intended that invalid `-binutils-version` values are silently accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://r

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG189f311130da: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid… (authored by MaskRay). Repository: rG LLVM Github Monore

[PATCH] D94820: Support for instrumenting only selected files or functions

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/32075/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.ll

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. In D85474#2523439 , @rsmith wrote: > Clang side looks good to me. > > On the LLVM side, is it intended that invalid `-binutils-version` values are > silently accepted? Yes. In `llvm/tools/llc/llc.cpp`, there is no validity check.

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

dexonsmith added a comment. In D94472#2523053 , @Bigcheese wrote: > In D94472#2519838 , @jansvoboda11 > wrote: > >> In D94472#2508018 , @dexonsmith >> wrote: >> >>> `strict

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added a comment. Herald added a reviewer: jansvoboda11. ping :) Is there any more feedback on the implementation inside ProcessCharEscape()? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://reviews.llvm.org/D

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 319378. MaskRay added a comment. Add llc validity check and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 Files: clang/docs/ReleaseNotes.rst clang/include/c

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang added inline comments. Comment at: clang/include/clang/AST/Mangle.h:92 + virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0; + rnk wrote: > I think I would prefer to have this return a number. I think CGDebugInfo > should be responsibl

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 319379. akhuang added a comment. Avoid using getLambdaId function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 Files: clang/include/clang/AST/Mangle.h clang/lib/

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added a comment. In D94820#2523461 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/32075/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks for the heads up, I suspect it m

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34b60d8a5684: Add -fbinutils-version= to gate ELF features on the specified binutils version (authored by MaskRay). Repository: rG LLVM Github Mon

[PATCH] D94820: Support for instrumenting only selected files or functions

MaskRay added inline comments. Comment at: clang/docs/UsersManual.rst:2271 +.. option:: -fprofile-list= + This can be added below `-fprofile-exclude-files=` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

curdeius added a comment. That's definitely an unintended behaviour. Please file a bug and possibly mark it as release blocker for LLVM 12. Either a fix will be there soon, or we'll revert. FYI, simple reproduce: verifyFormat("#include \n" "namespace rep {}", St

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

leonardchan added a comment. In D93839#2523703 , @curdeius wrote: > That's definitely an unintended behaviour. Please file a bug and possibly > mark it as release blocker for LLVM 12. Either a fix will be there soon, or > we'll revert. > > FYI, simple re

[PATCH] D95479: [clang-format] Avoid considering include directive as a template closer.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, leonardchan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bug introduced in D93839 where: #include na

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov updated this revision to Diff 319400. mizvekov added a comment. added tests adds test that will catch original bug also adds some tests on default equality/relational operators this last one would have caught the issue of not accepting equality operator for function pointers, had I not

[PATCH] D95479: [clang-format] Avoid considering include directive as a template closer.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Confirmed on our end this fixes our issue. Thanks for addressing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95479/new/

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added inline comments. Comment at: llvm/lib/IR/Instruction.cpp:580 +if (auto *CB = dyn_cast(this)) + return objcarc::hasRetainRVOrClaimRVAttr(CB); +return false; fhahn wrote: > ahatanak wrote: > > fhahn wrote: > > > rjmccall wrote: > > > > n

[PATCH] D95482: [PATCH] [clang] Fix bug 48848 by removing assertion related to recoverFromMSUnqualifiedLookup

mibintc created this revision. mibintc added reviewers: erichkeane, rnk. mibintc requested review of this revision. Herald added a project: clang. Fix https://bugs.llvm.org/show_bug.cgi?id=48848 by removing assertion Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95482 Files:

[PATCH] D95479: [clang-format] Avoid considering include directive as a template closer.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95479/new/ https://reviews.llvm.org/D95479 ___ cfe-commits mailing list cfe-commi

[PATCH] D93248: Frontend: Fix layering between create{,Default}OutputFile, NFC

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93248/new/ https://reviews.llvm.org/D93248 __

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added inline comments. Comment at: clang/docs/UsersManual.rst:2271 +.. option:: -fprofile-list= + MaskRay wrote: > This can be added below `-fprofile-exclude-files=` I considered it but that's in the GCOV section and this flag only applies to the LLVM i

[PATCH] D93249: Frontend: Fix memory leak in CompilerInstance::setVerboseOutputStream

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93249/new/ https://reviews.llvm.org/D93249 ___

[PATCH] D95459: Add helper functionality for parsing different attribute syntaxes in arbitrary order

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me! (welcome to wait for more eyes, if you like) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95459/new/ https://reviews.llvm.org/D95459 __

  1   2   >