MaskRay added a comment. In your commit the message does not include `Reviewed by:`. Many people agree that both `Reviewed by:` & `Differential Revision:` should be present. The `Reviewed by:` list indicates people who acknowledged the patch. (The `Reviewers:` list does not necessarily mean all the people on the list have acknowledged the patch so `Reviewers:` is mostly useless.)
`arc amend` can fetch the Phabricator summary and amend the local description. You can install `llvm/.git/hooks/pre-push` to prevent accidental `Summary:`, `Reviewers:`, `Subscribers:` and `Tags:`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95075/new/ https://reviews.llvm.org/D95075 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
