MaskRay added a comment.

In D85474#2523439 <https://reviews.llvm.org/D85474#2523439>, @rsmith wrote:

> Clang side looks good to me.
>
> On the LLVM side, is it intended that invalid `-binutils-version` values are 
> silently accepted?

Yes. In `llvm/tools/llc/llc.cpp`, there is no validity check. For these 
non-user-facing utilities (opt/llc/llvm-mc/...), validity check for options 
tends to be scarce.

I can add some tests to `llvm/test/tools/llc` (which hardly has any test 
currently).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85474/new/

https://reviews.llvm.org/D85474

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to