[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. Herald added a reviewer: jansvoboda11. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

ArcsinX updated this revision to Diff 318442. ArcsinX added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95206/new/ https://reviews.llvm.org/D95206 Files: clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/clangd

[clang] ff5f42e - [clang][cli] Port visibility LangOptions to marshalling system

Author: Jan Svoboda Date: 2021-01-22T09:32:01+01:00 New Revision: ff5f42e413386b1b3730879abf7b35756891e1c3 URL: https://github.com/llvm/llvm-project/commit/ff5f42e413386b1b3730879abf7b35756891e1c3 DIFF: https://github.com/llvm/llvm-project/commit/ff5f42e413386b1b3730879abf7b35756891e1c3.diff L

[PATCH] D95147: [clang][cli] Port visibility LangOptions to marshalling system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff5f42e41338: [clang][cli] Port visibility LangOptions to marshalling system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 318452. jansvoboda11 added a comment. Create function for argument generation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https://reviews.llvm.org/D94472 Files: clang/include/clang/Frontend

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, I'd seen these crashes but not manage to track down yet! LG with one fix Comment at: clang-tools-extra/clangd/index/Index.cpp:81 SwapIndex::indexedFiles() con

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

curdeius added inline comments. Comment at: clang/docs/tools/dump_format_style.py:194 +# is used. +pass elif state == State.InEnumMemberComment: Just a nit, maybe we should have a warning at least? Repository: rG LLVM Github Monorepo CHA

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 318457. jansvoboda11 added a comment. Move boilerplate from CreateFromArgs to separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https://reviews.llvm.org/D94472 Files: clang/incl

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

azabaznov updated this revision to Diff 318458. azabaznov added a comment. Herald added a project: clang. Removed getCoreFeatures() as it's not used in this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92277/new/ https://reviews.llvm.org/D

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 318459. jansvoboda11 added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https://reviews.llvm.org/D94472 Files: clang/include/clang/Frontend/CompilerInvocation.h c

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

azabaznov marked an inline comment as done. azabaznov added inline comments. Comment at: clang/test/Misc/nvptx.languageOptsOpenCL.cl:18 // RUN: %clang_cc1 -x cl -cl-std=CL2.0 %s -verify -triple nvptx64-unknown-unknown -Wpedantic-core-features -DTEST_CORE_FEATURES +// XFAIL: *

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS updated this revision to Diff 318463. MoritzS added a comment. Rebased onto master, run tests again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.llvm.org/D92221 Files: clang/include/clang/Analysis/PathDiagnost

[PATCH] D95131: [CodeComplete] Add ranged for loops code pattern.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95131/new/ https://reviews.llvm.org/D95131

[PATCH] D95087: [clangd] Inject context provider rather than config into ClangdServer. NFC

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:277 + D.getColumnNo(), D.getMessage()); +break; + } nit: maybe finish

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

Anastasia accepted this revision. Anastasia added a comment. Cool. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92277/new/ https://reviews.llvm.org/D92277 ___ cfe-commits mailing list cfe-commit

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

ArcsinX updated this revision to Diff 318470. ArcsinX added a comment. Call snapshot() only once to avoid possible race. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95206/new/ https://reviews.llvm.org/D95206 Files: clang-tools-extra/clangd/ind

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

ArcsinX updated this revision to Diff 318474. ArcsinX added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95206/new/ https://reviews.llvm.org/D95206 Files: clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/clangd

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

vsavchenko accepted this revision. vsavchenko added a comment. Hi @MoritzS thanks for the cleanup! Maybe while you are on it, you can set default values as pointed by @NoQ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.ll

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

kadircet added a comment. Thanks this looks great, and something i've been longing for some time! But I got a couple of questions about the how the interaction is designed (sorry if I missed some high level discussions elsewhere, feel free to just point me in that direction). - Why do we just

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 318475. jansvoboda11 added a comment. Herald added a subscriber: dang. Add round-tripping arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https://reviews.llvm.org/D94472 Files: clang/

[clang-tools-extra] 4cca222 - [clangd] Add documentation for building and testing clangd

Author: Kadir Cetinkaya Date: 2021-01-22T11:53:31+01:00 New Revision: 4cca79396c4e4d484ba79e74c5dc45fe63e4 URL: https://github.com/llvm/llvm-project/commit/4cca79396c4e4d484ba79e74c5dc45fe63e4 DIFF: https://github.com/llvm/llvm-project/commit/4cca79396c4e4d484ba79e74c5dc45fe63e4.dif

[PATCH] D91186: [clangd] Add documentation for building and testing clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cca7939: [clangd] Add documentation for building and testing clangd (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91186/new/ ht

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS updated this revision to Diff 318477. MoritzS edited the summary of this revision. MoritzS added a comment. Initialize bool flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.llvm.org/D92221 Files: clang/inclu

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS added a comment. Some tests were failing, I'll try to fix that and then commit the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.llvm.org/D92221 ___ cfe-commit

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added inline comments. Comment at: clang/docs/tools/dump_format_style.py:194 +# is used. +pass elif state == State.InEnumMemberComment: curdeius wrote: > Just a nit, maybe we should have a warning at least? Not sure. After this commit

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

steakhal updated this revision to Diff 318480. steakhal marked 2 inline comments as done. steakhal retitled this revision from "[RFC][analyzer] Introduce MacroExpansionContext to libAnalysis" to "[analyzer] Introduce MacroExpansionContext to libAnalysis". steakhal edited the summary of this revis

[PATCH] D93223: [analyzer] Create MacroExpansionContext member in AnalysisConsumer

steakhal updated this revision to Diff 318482. steakhal retitled this revision from "[RFC][analyzer] Create MacroExpansionContext member in AnalysisConsumer and pass down to the diagnostics consumers" to "[analyzer] Create MacroExpansionContext member in AnalysisConsumer". steakhal edited the su

[clang] d972d4c - Revert "[clang] Suppress "follow-up" diagnostics on recovery call expressions."

Author: Haojian Wu Date: 2021-01-22T13:04:37+01:00 New Revision: d972d4c749048531953a16b815e07c67e8455a3b URL: https://github.com/llvm/llvm-project/commit/d972d4c749048531953a16b815e07c67e8455a3b DIFF: https://github.com/llvm/llvm-project/commit/d972d4c749048531953a16b815e07c67e8455a3b.diff LO

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

JonChesterfield added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:24 + return() +endif() + jdoerfert wrote: > we need the 32 bit versions as well, I guess? We could limit to 64 and see if a feature request for 32 comes in.

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

dmgreen added a comment. Thanks. @fhahn @SjoerdMeijer what do we think about the edge case where the width==1? As far as I understand (with this patch): #pragma clang loop vectorize_predicate(disable) vectorize_width(4) Gives llvm.loop.vectorize.predicate.enable=false, llvm.loop.vectorize.w

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:772 + // Parse records + SmallVector, 512> Defs; + std::vector RV = Records.getAllDerivedDefinitions("RVVBuiltin"); This getAllDerivedDefinitions, loop, call createRVVIntrin

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:772 + // Parse records + SmallVector, 512> Defs; + std::vector RV = Records.getAllDerivedDefinitions("RVVBuiltin"); craig.topper wrote: > craig.topper wrote: > > This getAll

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 318423. khchen added a comment. 1. address @craig.topper's comment. 2. rewrite script as python. I'm still have no idea to make generating tests mechanism be more elegant... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen marked 7 inline comments as done. khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:191 +defvar suffix = s_p[1]; +defvar prototype = s_p[2]; + Paul-C-Anagnostopoulos wrote: > Well now, thanks for highlighti

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 318447. khchen marked 2 inline comments as done. khchen added a comment. 1. do not need to manually define new op in gen-rvv-tests.py. 2. do not need to manually add new op define in ALL marco. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95221: [clang][cli] NFC: Move prefix to the front of BoolOption

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: dang, jfb. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The prefix used to be the last (optional) argument to

[clang] e16959c - Don't delete default constructor of PathDiagnosticConsumerOptions

Author: Moritz Sichert Date: 2021-01-22T13:42:38+01:00 New Revision: e16959c9b8553a60ec5e9aa55d101154d5805292 URL: https://github.com/llvm/llvm-project/commit/e16959c9b8553a60ec5e9aa55d101154d5805292 DIFF: https://github.com/llvm/llvm-project/commit/e16959c9b8553a60ec5e9aa55d101154d5805292.diff

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe16959c9b855: Don't delete default constructor of PathDiagnosticConsumerOptions (authored by MoritzS). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/ne

[clang] a0e3091 - [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

Author: Mikhail Maltsev Date: 2021-01-22T13:01:41Z New Revision: a0e30914f8c8bb60795a008ce2d9e3c0a4f9b7a2 URL: https://github.com/llvm/llvm-project/commit/a0e30914f8c8bb60795a008ce2d9e3c0a4f9b7a2 DIFF: https://github.com/llvm/llvm-project/commit/a0e30914f8c8bb60795a008ce2d9e3c0a4f9b7a2.diff LO

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0e30914f8c8: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94599/new/ h

[PATCH] D95225: [clang][cli] NFC: Pass CC1Option explicitly to BoolOption

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: dang, jfb. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When `Bool{F,G}Option` were introduced, they were des

[clang-tools-extra] 7388c34 - [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

Author: Aleksandr Platonov Date: 2021-01-22T16:26:39+03:00 New Revision: 7388c34685954862e5f1fa4734f42f7087e697a2 URL: https://github.com/llvm/llvm-project/commit/7388c34685954862e5f1fa4734f42f7087e697a2 DIFF: https://github.com/llvm/llvm-project/commit/7388c34685954862e5f1fa4734f42f7087e697a2.

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

This revision was automatically updated to reflect the committed changes. Closed by commit rG7388c3468595: [clangd][SwapIndex] ensure that the old index is alive while we are using it… (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang-tools-extra] 60cd75a - [clangd] Inject context provider rather than config into ClangdServer. NFC

Author: Sam McCall Date: 2021-01-22T14:34:30+01:00 New Revision: 60cd75a098d4f18d9c8903ddcb466b4e7deb0580 URL: https://github.com/llvm/llvm-project/commit/60cd75a098d4f18d9c8903ddcb466b4e7deb0580 DIFF: https://github.com/llvm/llvm-project/commit/60cd75a098d4f18d9c8903ddcb466b4e7deb0580.diff LO

[PATCH] D95087: [clangd] Inject context provider rather than config into ClangdServer. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG60cd75a098d4: [clangd] Inject context provider rather than config into ClangdServer. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D95087?vs=317995&id=318498#toc Reposi

[PATCH] D95057: [clangd] WIP: configurable compilation database directory

sammccall updated this revision to Diff 318499. sammccall added a comment. Rebase, implement yaml bits (no tests yet) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95057/new/ https://reviews.llvm.org/D95057 Files: clang-tools-extra/clangd/Clangd

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal added a comment. The patch doesn't seem to affect the reports. It only introduced 3 new reports during the analysis of clang + clang-tidy. The analysis times indeed increased slightly, ~~ +3%. Overall, I think it's a valuable patch, which resolves crashes when the Z3 refutation enabled.

[PATCH] D94293: [clangd] automatically index STL

kuhnel abandoned this revision. kuhnel added a comment. thx for the review and feedback! I guess I'll re-design the feature and add a new indexing layer instead. However that might take a while, so I'll abandon this revision and start a new one later on. Repository: rG LLVM Github Monorepo

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4671 + D.Diag(diag::err_aix_default_altivec_abi); } Just to confirm, because the patch description confuses me a bit on this: The intent is to not complain

[PATCH] D94814: [HIP] Support `__managed__` attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. The attribute parts LGTM aside from some small nits. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8245 "%select{__device__|__global__|__host__|__host__ __device__}0 functions">; -def err_c

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG98a8344895a8: [clang][ASTImporter] Add support for importing CXXFoldExpr. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ h

[clang] 98a8344 - [clang][ASTImporter] Add support for importing CXXFoldExpr.

Author: Balázs Kéri Date: 2021-01-22T15:20:55+01:00 New Revision: 98a8344895a8e1f2cfa98b664b50fb7b864afa52 URL: https://github.com/llvm/llvm-project/commit/98a8344895a8e1f2cfa98b664b50fb7b864afa52 DIFF: https://github.com/llvm/llvm-project/commit/98a8344895a8e1f2cfa98b664b50fb7b864afa52.diff L

[PATCH] D95145: [clang] Fix a nullptr dereference bug on invalid code

adamcz added inline comments. Comment at: clang/test/SemaCXX/subst-func-type-invalid-ret-type.cpp:2 +// RUN: %clang -fsyntax-only -std=c++17 %s -Xclang -verify +#include + hokein wrote: > A common practice is to avoid depending on STL in tests. I think we need t

[PATCH] D95228: Add swift_async_context parameter attribute mapping to IR equivalent

t.p.northover created this revision. Herald added subscribers: dexonsmith, jdoerfert, mcrosier. Herald added a reviewer: aaron.ballman. t.p.northover requested review of this revision. This adds `__attribute__((swift_async_context))` very much following the existing `swift_context` so that Swift'

[PATCH] D95229: [clangd] Treat optional field type mismatches as soft failures

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd currently throws away any protocol m

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 added a comment. In D94942#2515049 , @kadircet wrote: > Thanks this looks great, and something i've been longing for some time! But I > got a couple of questions about the how the interaction is designed (sorry if > I missed some high level disc

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 created this revision. njames93 added reviewers: kadircet, hokein, sammccall. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Selection now includes the

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

SjoerdMeijer added a comment. In D94779#2515157 , @dmgreen wrote: > Thanks. @fhahn @SjoerdMeijer what do we think about the edge case where the > width==1? As far as I understand (with this patch): > > #pragma clang loop vectorize_predicate(disable) vec

[PATCH] D95002: [RISCV] Update B extension version to 0.93.

frasercrmck added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoB.td:732 // There's no encoding for roli in the current version of the 'B' extension // (v0.92) as it can be implemented with rori by negating the immediate. let Predicates = [HasStdExtZbbOrZbp]

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 updated this revision to Diff 318523. njames93 added a comment. Update FindTargets to fix symbol renaming on a CXXBaseSpecifier. Add test to ensure rename wont trigger on a CXXBaseSpecifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D952

[PATCH] D95057: [clangd] WIP: configurable compilation database directory

sammccall updated this revision to Diff 318526. sammccall added a comment. Add tests and fix bugs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95057/new/ https://reviews.llvm.org/D95057 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clan

[PATCH] D95221: [clang][cli] NFC: Move prefix to the front of BoolOption

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95221/new/ https://reviews.llvm.org/D95221

[PATCH] D95225: [clang][cli] NFC: Pass CC1Option explicitly to BoolOption

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM; this is much better! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95225/new/ https://reviews.llvm.org/D95225 ___

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz updated this revision to Diff 318529. adamcz marked an inline comment as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94919/new/ https://reviews.llvm.org/D94919 Files: clang-tools-e

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1807-1811 +@interface Foo +- (void)fun:(bool)foo + bar:(bool)bar, + baz:(bool)baz; +@end dgoldman wrote: > It's hard to tell what Clang ma

[PATCH] D95017: [clang-format] add case aware include sorting

HazardyKnusperkeks added a comment. I can push that, but will wait a bit longer so the others have time to object. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 ___

[PATCH] D94814: [HIP] Support `__managed__` attribute

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8245 "%select{__device__|__global__|__host__|__host__ __device__}0 functions">; -def err_cuda_nonstatic_constdev: Error<"__constant__ and __dev

[PATCH] D95145: [clang] Fix a nullptr dereference bug on invalid code

adamcz updated this revision to Diff 318534. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95145/new/ https://reviews.llvm.org/D95145 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang

[PATCH] D95145: [clang] Fix a nullptr dereference bug on invalid code

adamcz added a comment. PTAL Comment at: clang/test/SemaCXX/subst-func-type-invalid-ret-type.cpp:2 +// RUN: %clang -fsyntax-only -std=c++17 %s -Xclang -verify +#include + adamcz wrote: > hokein wrote: > > A common practice is to avoid depending on STL in tests

[clang] 622eaa4 - [HIP] Support __managed__ attribute

Author: Yaxun (Sam) Liu Date: 2021-01-22T11:43:58-05:00 New Revision: 622eaa4a4cea17c2cec6942d9702b010deae392b URL: https://github.com/llvm/llvm-project/commit/622eaa4a4cea17c2cec6942d9702b010deae392b DIFF: https://github.com/llvm/llvm-project/commit/622eaa4a4cea17c2cec6942d9702b010deae392b.dif

[PATCH] D94814: [HIP] Support `__managed__` attribute

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rG622eaa4a4cea: [HIP] Support __managed__ attribute (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D94814?v

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Type of `Callee` can be overloaded function type that was not handled. This causes a c

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske added a comment. Should add some responsible (for this code) reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 ___ cfe-commits mailing list cfe-

[PATCH] D95002: [RISCV] Update B extension version to 0.93.

craig.topper updated this revision to Diff 318548. craig.topper added a comment. Remove reference to version from the rori comment. The version doesn't really matter, I doubt the encoding will ever be added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 318552. njames93 added a comment. If cursor is over one of the base specifiers, offer to implement only the pure methods from that base class. Depends on D95231 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman requested changes to this revision. dgoldman added a comment. This revision now requires changes to proceed. Looks good but I think for posterity we should add a similar test to clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp for the exact intended code complete behavior (or in

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 318553. saudi marked an inline comment as done. saudi added a comment. Applied the suggestions from the parent patch D95099 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 Fi

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: fanbo-meng, anirudhp, muiez, Kai, yusra.syeda. Herald added subscribers: rupprecht, steven_wu, hiraditya, sbc100. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald added a reviewer:

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2342 +attrs = attrs.addAttribute(CGF.getLLVMContext(), + llvm::AttributeList::ReturnIndex, "rv_marker"); +callBase->setAttributes(attrs); rjmccall wrote

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

muiez accepted this revision. muiez added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D95246 ___ cfe

[PATCH] D95168: Add InsertBraces option

tiagoma added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2254 + + * ``BIS_WrapLikely`` (in configuration: ``WrapLikely``) +Insert braces if wrapping is likely curdeius wrote: > Shouldn't it be consistent with clang-tidy? So instead o

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

JDevlieghere added a comment. Overall this looks good. I wonder if abstracting the ExternalRedirect as a small wrapper class around a SmallString would help. There's a few operations that are repeated, like the example below, and it could also house the logic that's currently in the lambda.

Re: [PATCH] D70701: Fix more VFS tests on Windows

BTW, I hope I didn't come across as overly negative in my previous response. I'd love to see the situation improved. I just don't know what that would look like. > One thing I see, but wasn't obvious from your description, is that the mixed/hybrid separator behaviour only happens for `defined(_W

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma updated this revision to Diff 318563. tiagoma added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/F

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

kpn updated this revision to Diff 318567. kpn added a comment. Update for review comments: Move uses of CGFPOptionsRAII lower and closer to where they are needed. This should be less error prone as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94614/new/ https://reviews.llvm.org/

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz added a comment. The crash happens while indexing the file, not during code completion. The code completion tests generally specify a cursor position, but in this case it is not relevant and could confuse the reader. This seemed like a logical place for indexing bug, in the spirit of usi

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman accepted this revision. dgoldman added a comment. This revision is now accepted and ready to land. In D94919#2515987 , @adamcz wrote: > The crash happens while indexing the file, not during code completion. The > code completion tests generally s

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Please, look at my solution. Is it worth to be accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ImplementAbstract.cpp:354 + return "Implement pure virtual methods from '" + + FromBase->getType().getAsString() + "'"; +} Maybe this should be changed as it

[PATCH] D95249: [NFC] Disallow unused prefixes in clang/test/Analysis

mtrofin created this revision. mtrofin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95249 Files: clang/test/Analysis/auto-obj-dtors-cfg-output.cpp clang/test/Analysis/

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

leonardchan added a comment. Almost there! Just a few more comments on my end. Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:5694 +Constant *CaseRes = Values[I].second; +if (auto *GlobalVal = dyn_cast(CaseRes)) + if (!GlobalVal->isDSOLocal()) --

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

This revision was automatically updated to reflect the committed changes. Closed by commit rG520b5ecf8561: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit… (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 520b5ec - [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

Author: Abhina Sreeskantharajan Date: 2021-01-22T13:54:25-05:00 New Revision: 520b5ecf856152f35ee38207eec39f5674dd2bd4 URL: https://github.com/llvm/llvm-project/commit/520b5ecf856152f35ee38207eec39f5674dd2bd4 DIFF: https://github.com/llvm/llvm-project/commit/520b5ecf856152f35ee38207eec39f5674dd

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

rnk added a comment. I see a variety of presubmit failures in Harbormaster that seem related, so make sure to check those. Comment at: clang/include/clang/AST/Mangle.h:92 + virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0; + I think I woul

[PATCH] D95253: [clang][Fuchsia] Add relative-vtables + asan multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. We're choosing to take an opt-in approach for landing Relative VTables, so we'll need asan-equiva

[PATCH] D89490: Introduce __attribute__((darwin_abi))

rjmccall added a comment. In D89490#2514695 , @aguinet wrote: >> I may be over-reacting to the way the patch seemed to be touching on the C++ >> ABI in multiple places. My understanding is that `ms_abi` is just a >> calling-convention attribute; it's ba

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 318594. ahatanak edited the summary of this revision. ahatanak added a comment. Stop using `clang.arc.rv_marker` and just use "clang.arc.rv"="retain/claim". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/n

[clang] 72f863f - [CodeGen] Use getCharWidth() more consistently in CGRecordLowering. NFC

Author: Bjorn Pettersson Date: 2021-01-22T21:12:17+01:00 New Revision: 72f863fd37c3471e7e1b152ac613da00ab6faaba URL: https://github.com/llvm/llvm-project/commit/72f863fd37c3471e7e1b152ac613da00ab6faaba DIFF: https://github.com/llvm/llvm-project/commit/72f863fd37c3471e7e1b152ac613da00ab6faaba.di

[clang] ea2cfda - [CGExpr] Use getCharWidth() more consistently in CCGExprConstant. NFC

Author: Bjorn Pettersson Date: 2021-01-22T21:12:17+01:00 New Revision: ea2cfda386f1a0f0b8cab06a9400bbf4cf7bfbaa URL: https://github.com/llvm/llvm-project/commit/ea2cfda386f1a0f0b8cab06a9400bbf4cf7bfbaa DIFF: https://github.com/llvm/llvm-project/commit/ea2cfda386f1a0f0b8cab06a9400bbf4cf7bfbaa.di

[PATCH] D94977: [CodeGen] Use getCharWidth() more consistently in CGRecordLowering. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72f863fd37c3: [CodeGen] Use getCharWidth() more consistently in CGRecordLowering. NFC (authored by bjope). Repository: rG LLVM Github Monorepo CH

  1   2   >