JonChesterfield added inline comments.

================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:24
+  return()
+endif()
+
----------------
jdoerfert wrote:
> we need the 32 bit versions as well, I guess?
We could limit to 64 and see if a feature request for 32 comes in.


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:62
 #else
+#error "Wrong number!"
 #define MAX_SM 16
----------------
Unintended?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94745/new/

https://reviews.llvm.org/D94745

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to