kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/ClangdServer.cpp:277 + D.getColumnNo(), D.getMessage()); + break; + } ---------------- nit: maybe finish here with a `return` and unify the duplicated `if (ClientDiags) ClientDags->push_back..` after the `switch`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95087/new/ https://reviews.llvm.org/D95087 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
