adamcz added a comment. PTAL
================ Comment at: clang/test/SemaCXX/subst-func-type-invalid-ret-type.cpp:2 +// RUN: %clang -fsyntax-only -std=c++17 %s -Xclang -verify +#include <type_traits> + ---------------- adamcz wrote: > hokein wrote: > > A common practice is to avoid depending on STL in tests. I think we need to > > pull out (even simplify?) std::result_of implementation if it is needed for > > reproducing the crash. > I've noticed that pattern, but can't tell why this is. Is it documented > somewhere? > Anyway, I updated the change to not require type_traits. Turned out to be simpler than expected ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95145/new/ https://reviews.llvm.org/D95145 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
