[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm added a comment. Thanks @spatel , @Florian and @fpetrogalli for the review comments and approval. Can someone please commit it on my behalf. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88154/new/ https://reviews.llvm.org/D88154 _

[clang] e32036b - [X86] Add clang release notes for HRESET and minor change for llvm release notes. (NFC)

Author: Wang, Pengfei Date: 2020-10-21T15:59:42+08:00 New Revision: e32036b9732fd1ec4794fef48ec79a268aa8cbce URL: https://github.com/llvm/llvm-project/commit/e32036b9732fd1ec4794fef48ec79a268aa8cbce DIFF: https://github.com/llvm/llvm-project/commit/e32036b9732fd1ec4794fef48ec79a268aa8cbce.diff

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88956/new/ https://reviews.llvm.org/D88956 _

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

eduucaldas added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:52-55 +const syntax::Token *FirstToken = Tree->findFirstLeaf()->getToken(), +*LastToken = Tree->findLastLeaf()->getToken(); +assert(FirstToken->kind() == t

[clang] 42a8286 - Reapply "[clang] Improve handling of physical registers in inline

Author: Jonas Paulsson Date: 2020-10-21T10:53:40+02:00 New Revision: 42a82862b625279028130e62846d057425bca691 URL: https://github.com/llvm/llvm-project/commit/42a82862b625279028130e62846d057425bca691 DIFF: https://github.com/llvm/llvm-project/commit/42a82862b625279028130e62846d057425bca691.diff

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

This revision was automatically updated to reflect the committed changes. Closed by commit rG42a82862b625: Reapply "[clang] Improve handling of physical registers in inline (authored by jonpa). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/

[PATCH] D89859: Remove .svn from exclude list as we moved to git

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: serge-sans-paille. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, mgorny. Herald added a reviewer: bollu. Herald added projects: clang, LLDB, LLVM. sylvestre.ledru requested review of this revision. Herald

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo http

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:172-174 /// Find the first node with a corresponding role. Node *findChild(NodeRole R); + const Node *findChild(NodeRole R) const; I think that makes sense, since all t

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev updated this revision to Diff 299618. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https://reviews.llvm.org/D84232 Files: clang-tools-extra/clangd/index/remote/README.md l

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 299619. kbobyrev marked an inline comment as done. kbobyrev added a comment. Prevent code duplication for const-nonconst versions of the same function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 299620. kbobyrev added a comment. Fix a typo and remove invalid const-ness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/SemanticS

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev updated this revision to Diff 299623. kbobyrev added a comment. Add macOS version check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https://reviews.llvm.org/D84232 Files: clang-tools-extra/clangd/index/remote/README.md l

[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c66606230df: [Driver] Incorporate -mfloat-abi in the computed triple on ARM (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89573/ne

[clang] 0c66606 - [Driver] Incorporate -mfloat-abi in the computed triple on ARM

Author: John Brawn Date: 2020-10-21T11:19:38+01:00 New Revision: 0c66606230df39e0bf4190f1fc2c2e2fb37a81ea URL: https://github.com/llvm/llvm-project/commit/0c66606230df39e0bf4190f1fc2c2e2fb37a81ea DIFF: https://github.com/llvm/llvm-project/commit/0c66606230df39e0bf4190f1fc2c2e2fb37a81ea.diff LO

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev added a comment. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=965217 is not going anywhere, I think we should just add this check and not check for the correct patch on Debian (and macOS is different anyway). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/ProtocolVersion.h:4 +namespace remote { +static const char *RemoteIndexProtocolVersion = "0.1.0"; +} Not sure if having a separate file with a hard-coded string is a good idea, sho

[PATCH] D89297: [clangd] Add a TestWorkspace utility

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/unittests/TestWorkspace.cpp:17 + for (const auto &Input : Inputs) { +if (!Input.second.IsMainFile) { + contin

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

ABataev added a comment. In D88978#2343484 , @jdoerfert wrote: > I have no idea what from the commit message what this has to do with the > OpenMP code gen but I saw this randomly while looking for something else so > here we go: > > In D88978#2326036

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

emankov accepted this revision. emankov added a comment. This revision is now accepted and ready to land. Thank you! I've successfully applied your change in `Cuda.cpp` to the following clang versions: `10.0.0`, `10.0.1`, `11.0.0`, and `12.0.0git`; and have created the working patches (#206

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: dexonsmith, jfb. azabaznov requested review of this revision. This change relates to OpenCL C 3.0 support. RFC thread: https://lists.llvm.org/pipermail/cfe-dev/2020-September/066883.html The

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Now, given `template foo() {}` w

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Updated patch LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82699/new/ https://reviews.llvm.org/D82699 ___ cfe-commits maili

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

davezarzycki added a comment. A git bisect run blamed this patch for breaking the ability to build with a read-only source tree. Can we revert this or make a quick fix? FAIL: Clang :: CodeGen/basic-block-sections.c (3385 of 26774) TEST 'Clang :: CodeGen/basic-block-secti

[clang] c50f0d2 - [Clang] Update newpm pipeline test in clang after D87322.

Author: Florian Hahn Date: 2020-10-21T12:59:50+01:00 New Revision: c50f0d239dc367b087ef7b06d413ae1df0750758 URL: https://github.com/llvm/llvm-project/commit/c50f0d239dc367b087ef7b06d413ae1df0750758 DIFF: https://github.com/llvm/llvm-project/commit/c50f0d239dc367b087ef7b06d413ae1df0750758.diff

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

davezarzycki added a comment. I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89500/new/ https://reviews.llvm.org/D89500 ___ cfe-

[clang] 87f6de7 - [clang testing] Fix a read-only source build system failure

Author: David Zarzycki Date: 2020-10-21T08:08:03-04:00 New Revision: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 URL: https://github.com/llvm/llvm-project/commit/87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 DIFF: https://github.com/llvm/llvm-project/commit/87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9.diff

Re: [llvm-dev] Upcoming upgrade of LLVM buildbot

> On Oct 20, 2020, at 03:35, Galina Kistanova via llvm-dev > wrote: > > Hello everyone, > > We have reached the point when all the bots could be updated to a newer > buildbot-worker software. > > We should be fine to go with whatever the version is current for the OS on > your bots. > > I

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

mibintc added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3223 +// Preserve floating point exceptions +#pragma fp exceptions(strict) +z = x + y; do you mean pragma clang fp ... Comment at: clang/lib/Parse/ParsePr

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

sepavloff added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3223 +// Preserve floating point exceptions +#pragma fp exceptions(strict) +z = x + y; mibintc wrote: > do you mean pragma clang fp ... Sure. Thank you!

[clang] 1bcec29 - Only run when `arm` is registered. NFC.

Author: Michael Liao Date: 2020-10-21T09:30:07-04:00 New Revision: 1bcec29afb321976cdcaa632ee6a47567dd651a7 URL: https://github.com/llvm/llvm-project/commit/1bcec29afb321976cdcaa632ee6a47567dd651a7 DIFF: https://github.com/llvm/llvm-project/commit/1bcec29afb321976cdcaa632ee6a47567dd651a7.diff

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 updated this revision to Diff 299672. jhuber6 added a comment. Changing test to be similar to LLVM's method, checks the linker flags for 32-bit library and only if the target triple is one of the known 64-bit triples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

aaron.ballman added a comment. In D74299#2339994 , @AlexanderLanin wrote: > I cannot reproduce the problem and there is just not enough info to go on. Ugh, I hate when that happens. :-( > Is there any way to get anything in addition? e.g. run the same t

[PATCH] D89859: Remove .svn from exclude list as we moved to git

emaste added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89859/new/ https://reviews.llvm.org/D89859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 added a comment. @daltenty Do you think this will fix the problem on AIX? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89696/new/ https://reviews.llvm.org/D89696 ___ cfe-commits mailing list cfe

[PATCH] D89859: Remove .svn from exclude list as we moved to git

sylvestre.ledru added a comment. ed if you want to approve it ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89859/new/ https://reviews.llvm.org/D89859 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:172-174 /// Find the first node with a corresponding role. Node *findChild(NodeRole R); + const Node *findChild(NodeRole R) const; eduucaldas wrote: > I think that make

[PATCH] D89859: Remove .svn from exclude list as we moved to git

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0784e17f1b4a: Remove .svn from exclude list as we moved to git (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D89882: [clangd] Offset enum values by when marshalling

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This will allow us detect missing values.

[PATCH] D88659: [NFC] Fix the definition of SuitableAlign

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659 ___

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx updated this revision to Diff 299684. flx added a comment. Fix compile errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89332/new/ https://reviews.llvm.org/D89332 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitializa

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

yaxunl added a comment. I am not sure whether it is proper to rename it. Originally, this flag means driver option which is not supposed to be forwarded to tools. It is more like a reminder to driver developers since clang driver does not automatically forward options to tools and does not enfo

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: alexfh, gribozavr, klimek. DmitryPolukhin added a project: clang-tools-extra. Herald added subscribers: kbarton, xazax.hun, nemanjai. Herald added a project: clang. DmitryPolukhin requested review of this revision. In memory VFS

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

DmitryPolukhin updated this revision to Diff 299697. DmitryPolukhin added a comment. Linting diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89886/new/ https://reviews.llvm.org/D89886 Files: clang-tools-extra/clang-tidy/ExpandModularHeadersPP

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

DmitryPolukhin updated this revision to Diff 299698. DmitryPolukhin added a comment. And one more time linting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89886/new/ https://reviews.llvm.org/D89886 Files: clang-tools-extra/clang-tidy/ExpandMod

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added a comment. In D89696#2344508 , @jhuber6 wrote: > @daltenty Do you think this will fix the problem on AIX? It's not just AIX that will have this problem I suspect. If you configure any cross-compiling build with a 64-bit host, targeting a 3

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 added a comment. In D89696#2344753 , @daltenty wrote: > In D89696#2344508 , @jhuber6 wrote: > >> @daltenty Do you think this will fix the problem on AIX? > > It's not just AIX that will have this problem I s

[PATCH] D89851: [clangd] Separate final_result into a different message; NFC

kbobyrev updated this revision to Diff 299705. kbobyrev added a comment. Fix proto formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89851/new/ https://reviews.llvm.org/D89851 Files: clang-tools-extra/clangd/index/remote/Client.cpp clan

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

compnerd added a comment. In D85474#2343393 , @MaskRay wrote: > In D85474#2343356 , @dexonsmith > wrote: > >> In D85474#2343326 , @MaskRay wrote: >> >>> In D85474#2342365

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: lattner, nhaehnle, asl. Herald added subscribers: cfe-commits, dexonsmith, dmgreen. Herald added a project: clang. Paul-C-Anagnostopoulos requested review of this revision. This patch continues the cleanup of boo

[PATCH] D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC

shafik added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1684 bool MyInvalid = false; ComputeLineNumbers(Diag, Content, ContentCacheAlloc, *this, MyInvalid); if (MyInvalid) Is the `const_cast` just for this line? Maybe we can loc

[clang] ba60de5 - Use -### in arm-float-abi.c test

Author: John Brawn Date: 2020-10-21T17:40:02+01:00 New Revision: ba60de5250ce1c4baa4a7bb7098ac67349f88a99 URL: https://github.com/llvm/llvm-project/commit/ba60de5250ce1c4baa4a7bb7098ac67349f88a99 DIFF: https://github.com/llvm/llvm-project/commit/ba60de5250ce1c4baa4a7bb7098ac67349f88a99.diff LO

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski added a comment. Thank you all for you comments! Please find my replies below. I've picked 4 main points raised here. 1 - In D89799#2342677 , @rnk wrote: > This seems like pretty corner case functionality. Do we really need this > diagnostic

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added a comment. In D89696#2344797 , @jhuber6 wrote: > In D89696#2344753 , @daltenty wrote: > >> In D89696#2344508 , @jhuber6 wrote: >> >>> @daltenty Do you think th

[clang] cf34dd0 - [clang] Improve Serialization/Imporing/Dumping of APValues

Author: Tyker Date: 2020-10-21T19:03:13+02:00 New Revision: cf34dd0c4e84b69bb901f9cd4f3491852238ec44 URL: https://github.com/llvm/llvm-project/commit/cf34dd0c4e84b69bb901f9cd4f3491852238ec44 DIFF: https://github.com/llvm/llvm-project/commit/cf34dd0c4e84b69bb901f9cd4f3491852238ec44.diff LOG: [c

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf34dd0c4e84: [clang] Improve Serialization/Imporing/Dumping of AP

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added a comment. In D63640#2339917 , @rsmith wrote: > In D63640#2331779 , @Tyker wrote: > >> but the "real" blocker is that the testing depends on D85144 >> for testing. >> w

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra added a comment. In D89752#2344113 , @emankov wrote: > Thank you! > I've successfully applied your change in `Cuda.cpp` to the following clang > versions: `10.0.0`, `10.0.1`, `11.0.0`, and `12.0.0git`; and have created the > working patches (#206 >

[PATCH] D89897: [AIX] Emit error for -G option on AIX

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, daltenty. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. Xiangling_L requested review of this revision. 1. Emit error for -G driver option on AIX 2. A

[clang] cf11f01 - [NFC] Fix the definition of SuitableAlign

Author: Xiangling Liao Date: 2020-10-21T13:34:56-04:00 New Revision: cf11f017af32a797e301f56b163a989ad73630fa URL: https://github.com/llvm/llvm-project/commit/cf11f017af32a797e301f56b163a989ad73630fa DIFF: https://github.com/llvm/llvm-project/commit/cf11f017af32a797e301f56b163a989ad73630fa.diff

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein added a comment. friendly ping @rsmith :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

hokein added a comment. friendly ping @rsmith :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87349/new/ https://reviews.llvm.org/D87349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante created this revision. Mordante added reviewers: aaron.ballman, rjmccall, rsmith. Mordante added a project: clang. Herald added a subscriber: dexonsmith. Mordante requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89899 Files: clang/incl

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

dblaikie added a comment. In D89500#2344234 , @davezarzycki wrote: > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > Thanks - if that's unblocked you, gr

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator wrote: > > dblaikie added a comment. > > In D89500#2344234 , @davezarzycki > wrote: > > > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > >

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

emankov added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:161 + if (FS.exists(LibDevicePath + "/libdevice.10.bc")) { +Version = CudaVersion::LATEST; +DetectedVersionIsNotSupported = Version > CudaVersion::LATEST_SUPPORTED; -

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

ille created this revision. ille added reviewers: jfb, rjmccall. Herald added a project: clang. ille requested review of this revision. This applies to situations where a `__block` variable's initializer references a block that potentially captures the variable itself. Clang special-cases this be

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with an extra testing request (that should hopefully just work for you). Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp:445 + int i = Orig(); +} -

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, daltenty. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. The changes made in D88594

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

ye-luo added a comment. Getting this even when compiling without offload. You can use the reproducer from the original bug report. clang++: /home/yeluo/opt/llvm-clang/llvm-project/llvm/include/llvm/ADT/APInt.h:1151: bool llvm::APInt::operator==(const llvm::APInt &) const: Assertion `BitWidth

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 updated this revision to Diff 299767. jhuber6 added a comment. Changing to just check if the target triple is of four known 64-bit architectures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89904/new/ https://reviews.llvm.org/D89904 Fil

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

rsmith added a comment. There are a couple of cases where you're returning `EvalStmtResult` from a function with a `bool` return type, that I'd like to see fixed before this lands. All the other comments are directed towards producing more precise behavior when evaluating a function containing

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 added a comment. In D89844#2345337 , @ye-luo wrote: > Getting this even when compiling without offload. You can use the reproducer > from the original bug report. I noticed one issue and I'm working on it now. Repository: rG LLVM Githu

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. (Accepted subject to previous comment.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 __

[PATCH] D81072: [analyzer] ObjCAutoreleaseWriteChecker: Support explicit autoreleasepools.

ddkilzer added a comment. Herald added a subscriber: steakhal. Thanks for implementing this! For posterity, I wanted to note a couple cases that this checker doesn't catch. 1. Under ARC, a more general case of assigning to an `__autoreleasing` variable. (Not sure why anyone would do this, but

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator wrote: > > dblaikie added a comment. > > In D89500#2344234 , @davezarzycki > wrote: > > > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > >

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

rjmccall added a comment. It's not optimal, but an alternative would be to force the variable to the heap immediately rather than waiting for a potential block copy. The variable would actually be uninitialized during its "copy", so we'd need to give it a trivial copy helper. But once the var

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

rjmccall added a comment. Of course, that wouldn't solve the general problem that the block might be getting used before its capture is fully initialized, but that's a general problem with uses within initializers in C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:45 AM Sriraman Tallam wrote: > > On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator > wrote: > > > > dblaikie added a comment. > > > > In D89500#2344234 , @davezarzycki > > wrote: > > > > > I think I fixed it. Please

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:161 + if (FS.exists(LibDevicePath + "/libdevice.10.bc")) { +Version = CudaVersion::LATEST; +DetectedVersionIsNotSupported = Version > CudaVersion::LATEST_SUPPORTED;

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:59 AM Sriraman Tallam wrote: > > On Wed, Oct 21, 2020 at 11:45 AM Sriraman Tallam wrote: > > > > On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator > > wrote: > > > > > > dblaikie added a comment. > > > > > > In D89500#2344234

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

emankov added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:161 + if (FS.exists(LibDevicePath + "/libdevice.10.bc")) { +Version = CudaVersion::LATEST; +DetectedVersionIsNotSupported = Version > CudaVersion::LATEST_SUPPORTED; -

[clang] b3881d0 - [NFC] Fixes Doxygen copy-paste error.

Author: Mark de Wever Date: 2020-10-21T21:19:04+02:00 New Revision: b3881d01abcbc519032e0c942f90124f2bdba56a URL: https://github.com/llvm/llvm-project/commit/b3881d01abcbc519032e0c942f90124f2bdba56a DIFF: https://github.com/llvm/llvm-project/commit/b3881d01abcbc519032e0c942f90124f2bdba56a.diff

[PATCH] D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS

Jonathan.Crowther updated this revision to Diff 299779. Jonathan.Crowther added a comment. Added a test for `-fno-short-enums` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89801/new/ https://reviews.llvm.org/D89801 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/zos

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. David, I don't think this is appropriate here. Let's take the discussion to llvm-dev. Comment at: mlir/include/mlir/IR/Dominance.h:49 +template <> +struct llvm::CfgTraitsFor { + using CfgTraits = mlir::CfgTraits; antiagainst wrote: >

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

ille added a comment. One downside of that approach is performance. It's somewhat idiosyncratic, but I work on codebases that use blocks heavily in performance-sensitive paths. Typically, the blocks are never copied (they don't escape) and are expected to be inlined. Any implicit heap alloca

[PATCH] D89897: [AIX] Emit error for -G option on AIX

jasonliu added a comment. Could we add some rationale to the patch summary about why we would want to deliberately emitting an error for AIX? Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4924 + if (RawTriple.isOSAIX()) +if (Arg *A = Args.getLastArg(options::OPT_G))

[clang] ba4768c - [c++20] For P0732R2 / P1907R1: Basic frontend support for class types as

Author: Richard Smith Date: 2020-10-21T13:21:41-07:00 New Revision: ba4768c966581658465f7366df9b0811f468a2d7 URL: https://github.com/llvm/llvm-project/commit/ba4768c966581658465f7366df9b0811f468a2d7 DIFF: https://github.com/llvm/llvm-project/commit/ba4768c966581658465f7366df9b0811f468a2d7.diff

[clang] 0c417d4 - Add more test coverage for APValue serialization / deserialization and

Author: Richard Smith Date: 2020-10-21T13:21:41-07:00 New Revision: 0c417d4bef1e78b0716c546101462f6d8962f358 URL: https://github.com/llvm/llvm-project/commit/0c417d4bef1e78b0716c546101462f6d8962f358 DIFF: https://github.com/llvm/llvm-project/commit/0c417d4bef1e78b0716c546101462f6d8962f358.diff

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx updated this revision to Diff 299794. flx added a comment. Add fake std function to ensure it is still matched. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89332/new/ https://reviews.llvm.org/D89332 Files: clang-tools-extra/clang-tidy/perf

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader created this revision. bader added reviewers: Anastasia, keryell, Naghasan, asavonic, Fznamznon. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, kerbowa, ebevhan, hiraditya, yaxunl, nhaehnle, jvesely, jholewinski. Herald added projects: clang, LLVM. bader requested review of

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

bader marked an inline comment as not done. bader added a comment. Alternative approach with SYCL specific semantic attributes - https://reviews.llvm.org/D89909. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80932/new/ https://reviews.llvm.org/D80

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx marked an inline comment as done. flx added a comment. Added a fake std function that still triggers the check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89332/new/ https://reviews.llvm.org/D89332 __

[PATCH] D53238: [Driver] Add -static= to unify -static-{libgcc,libstdc++}

Yu added a comment. Herald added a subscriber: dang. I accidentally come into this thread when searching for how to statically link to libc++/libc++abi. I'm really curious if this patch will or will not get merged. I'm really painful on using c++17 on ancient environment which does not have lib

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, ZarkoCA. Herald added subscribers: cfe-commits, dexonsmith, kbarton, nemanjai. Herald added a project: clang. Xiangling_L requested review of this revision. On AIX, to support vector types, which shou

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

nickdesaulniers updated this revision to Diff 299797. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - rebase, use stronger language about mutual exclusion, prefer assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D53238: [Driver] Add -static= to unify -static-{libgcc,libstdc++}

MaskRay added a comment. In D53238#2345618 , @Yu wrote: > I accidentally come into this thread when searching for how to statically > link to libc++/libc++abi. I'm really curious if this patch will or will not > get merged. I'm really painful on using c+

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: llvm/docs/LangRef.rst:1829 + +If a function with the ``nossp`` attribute calls a callee function that has +a stack protector function attribute, such as ``ssp``, ``sspreq`

[clang] eef2e67 - Simple fix to basic-block-sections to replace emit-obj with emit-llvm

Author: Sriraman Tallam Date: 2020-10-21T13:52:33-07:00 New Revision: eef2e67d2326e7d4027fddb29eefdb69371dc24a URL: https://github.com/llvm/llvm-project/commit/eef2e67d2326e7d4027fddb29eefdb69371dc24a DIFF: https://github.com/llvm/llvm-project/commit/eef2e67d2326e7d4027fddb29eefdb69371dc24a.dif

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. Thanks! I've verified this fixes the test on AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89904/new/ https://reviews.llvm.org/D89904

  1   2   >