kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
================
Comment at: clang-tools-extra/clangd/unittests/TestWorkspace.cpp:17
+ for (const auto &Input : Inputs) {
+ if (!Input.second.IsMainFile) {
+ continue;
----------------
nit: redundant braces
================
Comment at: clang-tools-extra/clangd/unittests/TestWorkspace.h:32
+private:
+ struct SourceFile {
+ std::string Code;
----------------
nit: I would move this near the stringmap.
================
Comment at: clang-tools-extra/clangd/unittests/TestWorkspace.h:38
+public:
+ TestWorkspace() {}
+
----------------
drop this.
================
Comment at:
llvm/utils/gn/secondary/clang-tools-extra/clangd/unittests/BUILD.gn:99
"TestTU.cpp",
+ "TestWorkspace.cpp",
"TweakTesting.cpp",
----------------
these are usually picked up by gn-build-bots and auto-updated. but it shouldn't
hurt to do that manually as well (i hope)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89297/new/
https://reviews.llvm.org/D89297
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
