[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added a comment. In D63640#2331734 , @martong wrote: > In D63640#2331410 , @rsmith wrote: > >> Reverse ping: I have a patch implementing class type non-type template >> parameters that's blocked on this landi

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 298318. Tyker added a comment. try to apply martongs's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/inc

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp added a comment. Ping! I don't have commit access, can anyone help me commit this with "Yang Fan " ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Ok, I can switch them back to staging. However today's staging was frequently offline. On Wed, 14 Oct 2020 at 21:44, Galina Kistanova wrote: > Thanks everyone! > > I would like to keep the bots in the staging till Friday. And if > everything is good, then apply the changes to the production and

[clang] 53122ce - [NFC] Correct name of profile function to Profile in APValue

Author: Tyker Date: 2020-10-15T10:53:40+02:00 New Revision: 53122ce2b39f5fb52c7a5933cc4cf32aad43568f URL: https://github.com/llvm/llvm-project/commit/53122ce2b39f5fb52c7a5933cc4cf32aad43568f DIFF: https://github.com/llvm/llvm-project/commit/53122ce2b39f5fb52c7a5933cc4cf32aad43568f.diff LOG: [N

[PATCH] D88643: [NFC] Correct name of profile function to Profile in APValue

This revision was automatically updated to reflect the committed changes. Closed by commit rG53122ce2b39f: [NFC] Correct name of profile function to Profile in APValue (authored by Tyker). Changed prior to commit: https://reviews.llvm.org/D88643?vs=295502&id=298330#toc Repository: rG LLVM Gi

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

martong added a comment. In D63640#2331779 , @Tyker wrote: > In D63640#2331734 , @martong wrote: > >> In D63640#2331410 , @rsmith wrote: >> >>> Reverse ping: I have a patch i

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini updated this revision to Diff 298333. mantognini added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89372/new/ https://reviews.llvm.org/D89372 Files: clang/include/clang/Basic/OpenCLExtensions.def cla

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:16 // // If the extensions are to be enumerated without the supported OpenCL version, // define OPENCLEXT(ext) where ext is the name of the extension. Anastasia wrote:

[clang] d7fa903 - [CodeGen][X86] Emit fshl/fshr ir intrinsics for shiftleft128/shiftright128 ms intrinsics

Author: Simon Pilgrim Date: 2020-10-15T10:22:41+01:00 New Revision: d7fa9030d47fa62ad443717f4d1c8da4096a1d6c URL: https://github.com/llvm/llvm-project/commit/d7fa9030d47fa62ad443717f4d1c8da4096a1d6c DIFF: https://github.com/llvm/llvm-project/commit/d7fa9030d47fa62ad443717f4d1c8da4096a1d6c.diff

[PATCH] D89405: [CodeGen][X86] Emit fshl/fshr ir intrinsics for shiftleft128/shiftright128 ms intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7fa9030d47f: [CodeGen][X86] Emit fshl/fshr ir intrinsics for shiftleft128/shiftright128 ms… (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D89453: Fix hidden-redecls.m test for some environments

kschwarz created this revision. kschwarz added reviewers: bnbarham, akyrtzi. Herald added subscribers: arphaman, dexonsmith. Herald added a project: clang. kschwarz requested review of this revision. This test was failing in our CI environment, because Jenkins mounts the workspaces into Docker co

[PATCH] D74130: [clang] fix consteval call in default arguements

Tyker updated this revision to Diff 298344. Tyker retitled this revision from "[clang] fix consteval call in default arguements " to "[clang] fix consteval call in default arguements". Tyker added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. rebased and add mo

[PATCH] D89407: [clang-tidy] Add scoped enum constants to identifier naming check

njames93 updated this revision to Diff 298349. njames93 added a comment. Removed runtime check in release mode that EnumConstant DeclContext is a EnumDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89407/new/ https://reviews.llvm.org/D89407 Fi

[PATCH] D89446: [WebAssembly] Prototype i8x16.popcnt

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:117 +TARGET_BUILTIN(__builtin_wasm_popcnt, "V16ScV16Sc", "nc", "simd128") + - Even if t

[PATCH] D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG145e44bb1885: [SVE]Fix implicit TypeSize casts in EmitCheckValue (authored by CarolineConcatto). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 145e44b - [SVE]Fix implicit TypeSize casts in EmitCheckValue

Author: Caroline Concatto Date: 2020-10-15T13:25:46+01:00 New Revision: 145e44bb18853bc9beeac0e64fffd9e6895e71f9 URL: https://github.com/llvm/llvm-project/commit/145e44bb18853bc9beeac0e64fffd9e6895e71f9 DIFF: https://github.com/llvm/llvm-project/commit/145e44bb18853bc9beeac0e64fffd9e6895e71f9.d

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. Herald added a subscriber: rdzhabarov. ping^2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83088/new/ https://reviews.llvm.org/D83088 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a documentation request, but you may want to wait a few days before committing in case Richard or John have opinions. In D89210#2330466

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

sylvestre.ledru created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. sylvestre.ledru requested review of this revision. This reverts commit b2eb439317576ce718193763c12bff9fccdfc166 . Cau

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

yaxunl updated this revision to Diff 298368. yaxunl marked an inline comment as done. yaxunl added a comment. Rename StreamableDiagnosticBase to StreamingDiagnostic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84362/new/ https://reviews.llvm.org/D84362 Files: clang/include/clang/AS

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

JakeMerdichAMD added a comment. Belated 'sounds good to me'. Other things have been keeping me busy, sorry for the delayed response on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https://reviews.llvm.org/D79388

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

lebedev.ri added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:12255 Alignment); - - // Bug 25167 Passing-by comment: you probably want to keep the tests though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/Diagnostic.h:1065 +/// +class StreamableDiagnosticBase { +public: rjmccall wrote: > I think I would prefer `StreamingDiagnostic` as the class name here. r

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

sepavloff updated this revision to Diff 298375. sepavloff added a comment. Remade the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88498/new/ https://reviews.llvm.org/D88498 Files: clang/include/clang/Basic/LangOptions.h clang/include/c

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam updated this revision to Diff 298377. saiislam added a comment. 1. Removed unnecessary formatting of untouched code. 2. Encapsulated addFieldToRecordDecl and createGlobalStruct methods in a class and made them static (triggered change at all calling sites). 3. Marked most of the member m

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

sepavloff added a comment. In D89360#2330522 , @rsmith wrote: > In D89360#2329856 , @sepavloff wrote: > >> I would propose to consider solution in D88498 >> . It tries to fix the re

[PATCH] D89468: [libTooling] Change `after` range-selector to operate only on source ranges

ymandel created this revision. ymandel added a reviewer: tdl-g. Herald added a project: clang. ymandel requested review of this revision. Currently, `after` fails when applied to locations in macro arguments. This change projects the subrange into a file source range and then applies `after`. R

[PATCH] D89469: FileManager: Test FileManager::getFileRef

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Add a test demonstrating `getFileRef`'s behaviour, which isn't obvious from code inspection when it's handling a redirected file. https://re

[PATCH] D89468: [libTooling] Change `after` range-selector to operate only on source ranges

tdl-g requested changes to this revision. tdl-g added a comment. This revision now requires changes to proceed. Just one comment about the tests. Comment at: clang/unittests/Tooling/RangeSelectorTest.cpp:196 +static void testAfterMacroArg(StringRef Code) { + const std::strin

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

sylvestre.ledru added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:12255 Alignment); - - // Bug 25167 lebedev.ri wrote: > Passing-by comment: you probably want to keep the tests though? Sure, i will keep that and add a test

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov updated this revision to Diff 298388. ASDenysPetrov added a comment. Updated. Moved `castRegion()` to `SValBuilder`. Actually it wasn't so hard as I thought :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89055/new/ https://reviews.llvm.org/D89055 Files: clang/include

[PATCH] D89475: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall. Herald added subscribers: ributzka, dexonsmith, jkorous. erik.pilkington requested review of this revision. This fixes a regression introduced in 9a6f4d451ca7aa06b94a407015fbadb456bc09ef

[PATCH] D89468: [libTooling] Change `after` range-selector to operate only on source ranges

ymandel updated this revision to Diff 298392. ymandel added a comment. cleaned up test code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89468/new/ https://reviews.llvm.org/D89468 Files: clang/lib/Tooling/Transformer/RangeSelector.cpp clang/u

[PATCH] D89468: [libTooling] Change `after` range-selector to operate only on source ranges

ymandel added inline comments. Comment at: clang/unittests/Tooling/RangeSelectorTest.cpp:196 +static void testAfterMacroArg(StringRef Code) { + const std::string Ref = "ref"; tdl-g wrote: > If this helper function took an "expected" parameter I might consider

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c6bfd90ab2d: [WebAssembly] v128.load{8,16,32,64}_lane instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 7c6bfd9 - [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

Author: Thomas Lively Date: 2020-10-15T15:33:10Z New Revision: 7c6bfd90ab2ddaa60de62878c8512db0645e8452 URL: https://github.com/llvm/llvm-project/commit/7c6bfd90ab2ddaa60de62878c8512db0645e8452 DIFF: https://github.com/llvm/llvm-project/commit/7c6bfd90ab2ddaa60de62878c8512db0645e8452.diff LOG:

[clang] 7c8385a - Revert "[WebAssembly] v128.load{8,16,32,64}_lane instructions"

Author: Thomas Lively Date: 2020-10-15T15:49:36Z New Revision: 7c8385a352ba21cb388046290d93b53dc273cd9f URL: https://github.com/llvm/llvm-project/commit/7c8385a352ba21cb388046290d93b53dc273cd9f DIFF: https://github.com/llvm/llvm-project/commit/7c8385a352ba21cb388046290d93b53dc273cd9f.diff LOG:

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88859/new/ https://reviews.llvm.org/D88859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp:175 + +void CGOpenMPRuntimeAMDGCN::emitSPMDKernelWrapper( +const OMPExecutableDirective &D, StringRef ParentName, The nvptx emitSPMDKernelWrapper does nothing and t

[PATCH] D89177: [cmake] Add support for multiple distributions

ldionne added a comment. Are the runtimes expected to support this multi-distribution configuration? I don't think we'd want to move libc++ towards building multiple configurations at once in a single CMake invocation -- it's already too complicated to build just one configuration. While I'm v

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D89481: [scan-build] Fix clang++ pathname again

sberg created this revision. sberg added reviewers: aadg, dcoughlin. Herald added a subscriber: Charusso. Herald added a project: clang. sberg requested review of this revision. e00629f777d9d62875730f40d266727df300dbb2 "[scan-build] Fix clang++ pathname" had removed the -MAJOR.MINOR suffix, but si

[PATCH] D89453: Fix hidden-redecls.m test for some environments

akyrtzi added a comment. Thank you! Are you able to commit it by yourself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89453/new/ https://reviews.llvm.org/D89453 ___ cfe-commits mailing list cfe-commit

[PATCH] D89177: [cmake] Add support for multiple distributions

beanz added a comment. In D89177#2332547 , @ldionne wrote: > Are the runtimes expected to support this multi-distribution configuration? I > don't think we'd want to move libc++ towards building multiple configurations > at once in a single CMake invocat

[PATCH] D89177: [cmake] Add support for multiple distributions

ldionne added a comment. In D89177#2332626 , @beanz wrote: > In D89177#2332547 , @ldionne wrote: > >> Are the runtimes expected to support this multi-distribution configuration? >> I don't think we'd want to move l

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski updated this revision to Diff 298407. awarzynski added a comment. Address PR comments, clang-format, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 Files: clang/include/clang/Driver/Opt

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski commandeered this revision. awarzynski edited reviewers, added: CarolineConcatto; removed: awarzynski. awarzynski added a comment. Thank you for reviewing @SouraVX! I'm just about to submit an updated patch with the requested changes. @CarolineConcatto has recently moved to a differen

[PATCH] D89177: [cmake] Add support for multiple distributions

beanz added a comment. In D89177#2332627 , @ldionne wrote: > That isn't what I meant. It's entirely okay for the runtimes to be driven via > `AddExternalProject` like the runtimes build does, since that's akin to > having a separate CMake invocation for

[PATCH] D89484: [AMDGPU][HIP] Switch default DWARF version to 5

scott.linder created this revision. Herald added subscribers: cfe-commits, kerbowa, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. Herald added a project: clang. scott.linder requested review of this revision. Herald added a subscriber: wdng. Another attempt at this, see D59008

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI and add clang and llvm option

ZarkoCA updated this revision to Diff 298409. ZarkoCA retitled this revision from "[PPC][AIX] Add vector callee saved registers for AIX extended vector ABI" to "[PPC][AIX] Add vector callee saved registers for AIX extended vector ABI and add clang and llvm option". ZarkoCA edited the summary of t

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI and add clang and llvm option

ZarkoCA marked 5 inline comments as done. ZarkoCA added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-csr-vector.ll:4 +; RUN: FileCheck --check-prefix=MIR32 %s + +; RUN: llc -mtriple=powerpc-unknown-aix-xcoff -verify-machineinstrs \ Xiangling_L wro

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. I've added more reviewers for the Clang side of this patch. I choose people who most recently changed the functions/files that this patch modifies. Any input much appreciated! For more context regarding Clang changes: http://lists.llvm.org/pipermail/cfe-dev/2020-Octo

[PATCH] D89297: [clangd] Add a TestWorkspace utility

nridge added a comment. In D89297#2326838 , @nridge wrote: > In principle, it should be possible to make the same interface work with > `FileIndex` under the hood, but I haven't figured out how. (Specifically, I > haven't figured out how to get `FileInde

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 298416. eduucaldas added a comment. - [SyntaxTree] `ElementAndDelimiterIterator` is polymorphic and supports `BeforeBegin` iterator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.l

[PATCH] D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.

jdoerfert accepted this revision. jdoerfert added a comment. LGTM. We can change the name later if we need to. This is now "opt-in" and (IIRC) we addressed all the known issues. Comment at: llvm/include/llvm/IR/Intrinsics.td:359 +class DefaultIntrinsic ret_types, +

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rnk added a comment. In D85802#2331403 , @leonardchan wrote: > Perhaps we can add some mechanism in Clang that determines which ABIs are > supported for specific platforms? That is, when targetting Linux, Clang will > diagnose an error if using `-fc++-ab

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. In D85802#2332766 , @rnk wrote: > In D85802#2331403 , @leonardchan > wrote: > >> Perhaps we can add some mechanism in Clang that determines which ABIs are >> supported for specific platform

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

rjmccall added inline comments. Comment at: clang/include/clang/Basic/PartialDiagnostic.h:66 +return *this; + } + yaxunl wrote: > rjmccall wrote: > > Why are these template operators necessary? The LHS of the `<<` should > > convert to a base reference typ

[PATCH] D89475: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89475/new/ https://reviews.llvm.org/D89475 ___ cfe-commits mailing list cfe-commits

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rnk added a comment. Would "f[no-]fuchsia-c++-abi-extensions" (or shorter, -ffuchsia-c++-abi) do the trick? I know it doesn't map well onto our current internal option representation, but I don't think the internal representation is particularly good. I'd rather limit the user-visible driver in

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 298420. eduucaldas added a comment. Linting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.org/D88106 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooling/Sy

[PATCH] D89478: AMDGPU: Make sure both cc1 and cc1as process -m[no-]code-object-v3

This revision was automatically updated to reflect the committed changes. Closed by commit rG67f189e93ce3: Make sure both cc1 and cc1as process -m[no-]code-object-v3 (authored by kzhuravl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[clang] 67f189e - Make sure both cc1 and cc1as process -m[no-]code-object-v3

Author: Konstantin Zhuravlyov Date: 2020-10-15T14:03:26-04:00 New Revision: 67f189e93ce3c25db74697551a77831a72b34929 URL: https://github.com/llvm/llvm-project/commit/67f189e93ce3c25db74697551a77831a72b34929 DIFF: https://github.com/llvm/llvm-project/commit/67f189e93ce3c25db74697551a77831a72b349

[PATCH] D89297: [clangd] Add a TestWorkspace utility

kadircet added a comment. This looks like a useful infra to have indeed, we currently don't have an easy way to setup a testcase that would require interactions between multiple files (e.g. a workspace), as you've noticed while working on callhierarchy tests (sorry for that). A couple of sugge

[PATCH] D89372: [OpenCL] Remove unused extensions

jvesely added a comment. `cl_khr_byte_addressable_stores` changes language semantics. without it, pointer dereferences of types smaller than 32 bits are illegal. Even if all clang targets support this the macro should still be defined for backward compatibility. it would be useful if the commit

[PATCH] D88498: [FPEnv] Apply dynamic rounding to function body only

sepavloff added a comment. Actually this solution also behaves wrong in some cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88498/new/ https://reviews.llvm.org/D88498 ___ cfe-commits mailing list c

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

sepavloff added a comment. As C++ case is much more complicated and we need a ruleset based on essential properties rather than implementation viewpoint, I am convinced that the solution based on manifestly constant-evaluated property is the best. Thank you for the discussion! Repository: r

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

compnerd updated this revision to Diff 298425. compnerd added a comment. Herald added a subscriber: arichardson. Passes locally now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 Files: clang/include/cla

[PATCH] D89453: Fix hidden-redecls.m test for some environments

kschwarz added a comment. Yes, I'll commit it tomorrow, thanks for the review @akyrtzi! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89453/new/ https://reviews.llvm.org/D89453 ___ cfe-commits mailing li

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. In D85802#2332808 , @rnk wrote: > Would "f[no-]fuchsia-c++-abi-extensions" (or shorter, -ffuchsia-c++-abi) do > the trick? I know it doesn't map well onto our current internal option > representation, but I don't think the interna

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: usaxena95, ributzka, kadircet. dexonsmith requested review of this revision. This is a WIP patch to shrink FileEntryRef to the size of a pointer, posting for early feedback in case someone has some.

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk accepted this revision. vsk added a comment. Thank you! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D89276: Support ObjC in IncludeInserter

alexfh accepted this revision. alexfh added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet created this revision. aguinet added reviewers: t.p.northover, mstorsjo, thegameg. Herald added subscribers: llvm-commits, cfe-commits, arphaman, dexonsmith, steven_wu, hiraditya, kristof.beyls, krytarowski. Herald added a reviewer: aaron.ballman. Herald added projects: clang, LLVM. aguine

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added a comment. In D89372#2332853 , @jvesely wrote: > `cl_khr_byte_addressable_stores` changes language semantics. without it, > pointer dereferences of types smaller than 32 bits are illegal. Ok, does it mean that we are missing to diagnose t

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith planned changes to this revision. dexonsmith added a comment. I'd still appreciate feedback on the direction, but `clang/test/ClangScanDeps/modules-full.cpp` is failing (getting `""` listed twice under `"file-deps"` for each translation unit) so I'm marking this as needing changes.

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam marked 3 inline comments as done. saiislam added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp:175 + +void CGOpenMPRuntimeAMDGCN::emitSPMDKernelWrapper( +const OMPExecutableDirective &D, StringRef ParentName, JonChesterfiel

[PATCH] D89445: clang/Basic: Remove ContentCache::getRawBuffer, NFC

dexonsmith updated this revision to Diff 298434. dexonsmith added a comment. Fix a compile error (I forgot to run `check-clang-tools` before). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89445/new/ https://reviews.llvm.org/D89445 Files: clang-tools-extra/clang-tidy/ExpandModularHea

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

rsmith added a comment. I worry that we're chasing after the implementation details of GCC here. It seems self-contradictory to say all three of these things at once: 1. The frontend function `foo` has known, builtin semantics X. (Eg, we'll use those semantics in the frontend.) 2. The symbol `f

[clang] 3513171 - [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type

Author: Erik Pilkington Date: 2020-10-15T15:21:01-04:00 New Revision: 351317167e2b28aad03f8e45e0ed0acbbff18c61 URL: https://github.com/llvm/llvm-project/commit/351317167e2b28aad03f8e45e0ed0acbbff18c61 DIFF: https://github.com/llvm/llvm-project/commit/351317167e2b28aad03f8e45e0ed0acbbff18c61.dif

[PATCH] D89475: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type

This revision was automatically updated to reflect the committed changes. Closed by commit rG351317167e2b: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 3f738d1 - Reland "[WebAssembly] v128.load{8,16,32,64}_lane instructions"

Author: Thomas Lively Date: 2020-10-15T19:32:34Z New Revision: 3f738d1f5e2d657993a51ca3fe56585268025d89 URL: https://github.com/llvm/llvm-project/commit/3f738d1f5e2d657993a51ca3fe56585268025d89 DIFF: https://github.com/llvm/llvm-project/commit/3f738d1f5e2d657993a51ca3fe56585268025d89.diff LOG:

[PATCH] D89484: [AMDGPU][HIP] Switch default DWARF version to 5

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89484/new/ https://reviews.llvm.org/D89484 _

[clang] d1beb95 - [AMDGPU] gfx1032 target

Author: Stanislav Mekhanoshin Date: 2020-10-15T12:41:18-07:00 New Revision: d1beb95d1241ec50bdf19db351d273374a146a4a URL: https://github.com/llvm/llvm-project/commit/d1beb95d1241ec50bdf19db351d273374a146a4a DIFF: https://github.com/llvm/llvm-project/commit/d1beb95d1241ec50bdf19db351d273374a146a

[PATCH] D89490: Introduce __attribute__((darwin_abi))

mstorsjo added a comment. I see that the llvm side of the patch lacks tests? Comment at: llvm/lib/IR/AsmWriter.cpp:379 +Out << "aarch64_darwincc"; +break; case CallingConv::SPIR_FUNC: Out << "spir_func"; break; The new code here has a different i

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. In D85802#2332895 , @phosek wrote: > In D85802#2332808 , @rnk wrote: > >> Would "f[no-]fuchsia-c++-abi-extensions" (or shorter, -ffuchsia-c++-abi) do >> the trick? I know it doesn't map

[PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

rsmith added inline comments. Comment at: cfe/trunk/lib/Sema/SemaType.cpp:2067 + S.LangOpts.GNUMode || + S.LangOpts.OpenCL).isInvalid(); } This looks wrong to me. The OpenCL rule

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

joerg added a comment. Disabling builtin handling when `asm` is enabled would be a major annoyance for NetBSD. The interaction between symbol renaming and TLI is complicated. There are cases where it would make perfect sense and others were it would be harmful. Example of the latter is the way

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. In D89490#2333073 , @mstorsjo wrote: > I see that the llvm side of the patch lacks tests? Sorry I forgot to add them indeed... I will push a patch with these. About the formatting, git clang-format HEAD~1 did this, and it looks b

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a subscriber: zatrazz. MaskRay added a comment. In D88712#2333030 , @rsmith wrote: > I worry that we're chasing after the implementation details of GCC here. It > seems self-contradictory to say all three of these things at once: > > 1. The

[clang] 68f116a - PR47864: Fix assertion in pointer-to-member emission if there are

Author: Richard Smith Date: 2020-10-15T13:51:51-07:00 New Revision: 68f116aa23434b577743307c487b2edf037fca4c URL: https://github.com/llvm/llvm-project/commit/68f116aa23434b577743307c487b2edf037fca4c DIFF: https://github.com/llvm/llvm-project/commit/68f116aa23434b577743307c487b2edf037fca4c.diff

[PATCH] D89446: [WebAssembly] Prototype i8x16.popcnt

tlively updated this revision to Diff 298457. tlively added a comment. - Update builtin function name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89446/new/ https://reviews.llvm.org/D89446 Files: clang/include/clang/Basic/BuiltinsWebAssembly.d

[PATCH] D89446: [WebAssembly] Prototype i8x16.popcnt

tlively marked an inline comment as done. tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:117 +TARGET_BUILTIN(__builtin_wasm_popcnt, "V16ScV16Sc", "nc", "simd128") + aheejin wrote: > - Even if there's only one vector

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

fhahn added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1096 static_cast(Tok.getAnnotationValue()); - IdentifierInfo *PragmaNameInfo = Info->PragmaName.getIdentifierInfo(); nit: unrelated change? Comment at: clang/lib

[clang] 65cb4fd - [libTooling] Change `after` range-selector to operate only on source ranges

Author: Yitzhak Mandelbaum Date: 2020-10-15T20:58:30Z New Revision: 65cb4fdd69f43b6c39a8e4ca27b509284b11d807 URL: https://github.com/llvm/llvm-project/commit/65cb4fdd69f43b6c39a8e4ca27b509284b11d807 DIFF: https://github.com/llvm/llvm-project/commit/65cb4fdd69f43b6c39a8e4ca27b509284b11d807.diff

[PATCH] D89468: [libTooling] Change `after` range-selector to operate only on source ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rG65cb4fdd69f4: [libTooling] Change `after` range-selector to operate only on source ranges (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet updated this revision to Diff 298460. kadircet added a comment. - As discussed offline moving with compact version of the output, while preserving names starting with an `_` to be leaves. This is also ready for an implementation-wise review now. Repository: rG LLVM Github Monorepo

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 298461. aguinet added a comment. Update format + llvm tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 Files: clang/include/clang-c/Index.h clang/include/clang

[PATCH] D89496: [Format/ObjC] Correctly handle base class with lightweight generics and protocol

benhamilton created this revision. benhamilton added reviewers: sammccall, MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. benhamilton requested review of this revision. ClangFormat does not correctly handle an Objective-C interface declaration with both ligh

  1   2   >