beanz added a comment. In D89177#2332627 <https://reviews.llvm.org/D89177#2332627>, @ldionne wrote:
> That isn't what I meant. It's entirely okay for the runtimes to be driven via > `AddExternalProject` like the runtimes build does, since that's akin to > having a separate CMake invocation for each configuration. That's okay. > > What I'm saying is that if the next logical step is to also add support for > multiple distributions in libc++'s build itself (e.g. adding > `LIBCXX_<DISTRIBUTION>_ENABLE_SHARED` & al), then I don't think that's a good > idea. Totally agree. That would be the path compiler-rt’s Darwin build goes, and it is a frequent problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
