ldionne added a comment. In D89177#2332626 <https://reviews.llvm.org/D89177#2332626>, @beanz wrote:
> In D89177#2332547 <https://reviews.llvm.org/D89177#2332547>, @ldionne wrote: > >> Are the runtimes expected to support this multi-distribution configuration? >> I don't think we'd want to move libc++ towards building multiple >> configurations at once in a single CMake invocation -- it's already too >> complicated to build just one configuration. > > I don’t see why the runtimes wouldn’t be included in this, especially when > using the runtimes build which already supports building multiple > configurations of libc++ from a single LLVM CMake invocation which in turn > runs CMake for the runtimes multiple times. In fact, I think runtimes is > basically the only place where we can currently cleanly handle building with > different options. > >> While I'm very sympathetic to the use case, it looks like this is working >> against the design of CMake. > > The way Compiler-RT builds for Darwin is certainly against the design of > CMake, but I don’t think the same is true for how the runtimes build works. > > I think the general idea of configure LLVM once, define multiple different > “distributions” to get different groups of targets that you can install into > different root directories and package for separate installation makes a lot > of sense and is useful even if it doesn’t handle distributions that have > different configurations. That isn't what I meant. It's entirely okay for the runtimes to be driven via `AddExternalProject` like the runtimes build does, since that's akin to having a separate CMake invocation for each configuration. That's okay. What I'm saying is that if the next logical step is to also add support for multiple distributions in libc++'s build itself (e.g. adding `LIBCXX_<DISTRIBUTION>_ENABLE_SHARED` & al), then I don't think that's a good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
