[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

hliao added a comment. In D80858#2177104 , @yaxunl wrote: > In D80858#2171266 , @hliao wrote: > >> We may try to solve the issue without RDC firstly, where we don't need to >> change that static variable name (if t

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

hliao added a comment. In D80858#2177159 , @tra wrote: > It's a good point. Perhaps this is one of the cases where we should *not* > follow nvcc. > We can't have our cake (preserve static behavior) and eat it (treat it as > non-static in case something o

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

kbobyrev updated this revision to Diff 281130. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Use more conservative approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84697/new/ https://reviews.llvm.org/D84697 Files: c

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 added inline comments. Comment at: clang/test/Sema/void-argument.cpp:1 +// RUN: not %clang_cc1 %s 2>&1 | FileCheck %s + riccibruno wrote: > These kinds of tests are typically done with a `-verify` test. See the other > tests in `Sema/` for examples. we a

[PATCH] D84703: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Cheers, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84703/new/ https://reviews.llvm.org/D84703 _

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

Szelethus added reviewers: NoQ, vsavchenko. Szelethus accepted this revision. Szelethus added a comment. Lets make sure that we invite others from the community to participate, here and on other patches as well. Otherwise, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad4ab81dccaa: [clang][cmake] Force CMAKE_LINKER for multistage build in case of… (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES

[clang] ad4ab81 - [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

Author: Kristina Bessonova Date: 2020-07-28T10:11:52+02:00 New Revision: ad4ab81dccaa72d9b5137433a0923d325ff76135 URL: https://github.com/llvm/llvm-project/commit/ad4ab81dccaa72d9b5137433a0923d325ff76135 DIFF: https://github.com/llvm/llvm-project/commit/ad4ab81dccaa72d9b5137433a0923d325ff76135.

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM either way Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast1

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

NoQ added a comment. I believe i clarified above how this checker should work. For testing purposes (which is the only reason to ever use the minimal output) i prefer to have it at the end of path, because that tells more about the bug path and therefore more important to test. The question i'

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp:215 // The explicit NULL case. + // We know that 'location' cannot be non-null. This is what + // we call an "explicit" null dereference. Maybe "is defini

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

fpallares accepted this revision. fpallares added a comment. This revision is now accepted and ready to land. Aside from the minor nit below this patch LGTM. Thanks a lot for all the changes @HsiangKai. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

fpallares added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:542 defm VMSGT_V : VALU_IV_X_I<"vmsgt", 0b01>; +} Minor nit: Add comment here (for the other `let RVVConstraint = NoConstraint` blocks below as well). Repository: rG

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for the patch, this LGTM, I think this kind of change should help reduce memory usage and I feel improves the readability. Repository: rG LLVM Github Monorepo CHA

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

riccibruno added a comment. In D84306#2177985 , @MyDeveloperDay wrote: > Thank you for the patch, this LGTM, I think this kind of change should help > reduce memory usage and I feel improves the readability. Thanks for your review! Repository: rG LL

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

riccibruno added inline comments. Comment at: clang/test/Sema/void-argument.cpp:1 +// RUN: not %clang_cc1 %s 2>&1 | FileCheck %s + Jac1494 wrote: > riccibruno wrote: > > These kinds of tests are typically done with a `-verify` test. See the > > other tests in `S

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos updated this revision to Diff 281154. pmatos added a comment. Initial implementation of reference types in the WebAssembly backend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files: .gitlab-ci.

[clang] eb10b06 - [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

Author: Bruno Ricci Date: 2020-07-28T10:30:35+01:00 New Revision: eb10b065f2a870b425dcc2040b9955e0eee464b4 URL: https://github.com/llvm/llvm-project/commit/eb10b065f2a870b425dcc2040b9955e0eee464b4 DIFF: https://github.com/llvm/llvm-project/commit/eb10b065f2a870b425dcc2040b9955e0eee464b4.diff L

[clang] f5acd11 - [clang-format][NFC] Be more careful about the layout of FormatToken.

Author: Bruno Ricci Date: 2020-07-28T10:30:28+01:00 New Revision: f5acd11d2c0ea228452aa5ed3abbc2c502009d56 URL: https://github.com/llvm/llvm-project/commit/f5acd11d2c0ea228452aa5ed3abbc2c502009d56 DIFF: https://github.com/llvm/llvm-project/commit/f5acd11d2c0ea228452aa5ed3abbc2c502009d56.diff L

[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb10b065f2a8: [clang] Pass the NamedDecl* instead of the DeclarationName into many… (authored by riccibruno). Changed prior to commit: https://rev

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5acd11d2c0e: [clang-format][NFC] Be more careful about the layout of FormatToken. (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84

[PATCH] D84599: [clang-index] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

riccibruno added a comment. The overloads of `NamedDecl::printName` are in D84658 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84599/new/ https://reviews.llvm.org/D84599

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

balazske added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/conditional-path-notes.c.plist:270 descriptionDereference of null pointer (loaded from variable 'x') - categoryLogic error + categoryMemory error typeDereference of null pointer -

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

HsiangKai added a comment. Thanks for your review, @fpallares. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80802/new/ https://reviews.llvm.org/D80802 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

russell.gallop added a comment. Hi, It looks like is causing one of the debuginfo-tests: llgdb-tests/nrvo-string.cpp to fail, run on Linux. Failure as below. I don't think the debuginfo-tests are run on any bot (but probably should be!). I bisected the failure back to this change. Please coul

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. Please ignore my `.gitlab-ci.yml`. That's just an internal change that I got uploaded by mistake. I am looking to see this through and start discussion on this with the goal of landing it. At the moment, for example this test crashes: struct { __attribute__((addre

[clang] b81fd5a - [clang-format][NFC] Fix a Wdocumentation warning in TokenAnnotator.cpp

Author: Bruno Ricci Date: 2020-07-28T10:58:52+01:00 New Revision: b81fd5aeecd8047ef62348b67cab2cf9a1577d8e URL: https://github.com/llvm/llvm-project/commit/b81fd5aeecd8047ef62348b67cab2cf9a1577d8e DIFF: https://github.com/llvm/llvm-project/commit/b81fd5aeecd8047ef62348b67cab2cf9a1577d8e.diff L

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. There's also this line of work on opaque types that could be potentially interested but seems far from being landed: https://groups.google.com/g/llvm-dev/c/Dw_DYSXGFto/m/OzzK-CkGAwAJ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D84461: [Concepts] Fix ast dump for immediately declared constraint.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0bd9fa137c2: [Concepts] Fix ast dump for immediately declared constraint. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84461/new/ ht

[clang] c0bd9fa - [Concepts] Fix ast dump for immediately declared constraint.

Author: Haojian Wu Date: 2020-07-28T12:10:03+02:00 New Revision: c0bd9fa137c28a3ef833b46b7f9770b060275281 URL: https://github.com/llvm/llvm-project/commit/c0bd9fa137c28a3ef833b46b7f9770b060275281 DIFF: https://github.com/llvm/llvm-project/commit/c0bd9fa137c28a3ef833b46b7f9770b060275281.diff LO

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

balazske added a comment. Then the current solution is good, print always end of the bug path. A change to the bug reporting component was made that caused reported position of bugs to change. New is the end of the path, old is the location set by the checker (`BugReport::getLocation` value). Th

[PATCH] D84473: Dump Accumulator

jhenderson added a comment. Could the llvm-readobj bit be spun off into a separate review, please. As things stand it doesn't have any of its own testing, which should be added at the same time as adding support in the tool itself. The new option is also lacking any documentation in the llvm-re

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

atrosinenko added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1465 + let Spellings = [Clang<"msp430_builtin">]; + let Documentation = [Undocumented]; +} aaron.ballman wrote: > No new, undocumented attributes, please. Or is this attribute not

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1465 + let Spellings = [Clang<"msp430_builtin">]; + let Documentation = [Undocumented]; +} atrosinenko wrote: > aaron.ballman wrote: > > No new, undocumented attributes, please.

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

atrosinenko added a comment. In D84602#2176584 , @rjmccall wrote: > Is there only one special calling convention, or is there any chance that > different builtin functions would use different conventions? It depends on how to define "builtin calling conv

[PATCH] D84453: [clang-tidy] Suppress one unittest on macOS.

njames93 added a comment. In D84453#2177665 , @NoQ wrote: > In D84453#2171548 , @njames93 wrote: > >> I was having issues with this test case under macos in D82188 >> . >> It would

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

njames93 updated this revision to Diff 281194. njames93 added a comment. Fix new lines in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82898/new/ https://reviews.llvm.org/D82898 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsum

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

saiislam created this revision. saiislam added reviewers: jdoerfert, ABataev, JonChesterfield. Herald added subscribers: cfe-commits, Anastasia. Herald added a project: clang. Harbormaster failed remote builds in B65994: Diff 281183! Harbormaster returned this revision to the author for changes bec

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Let me double down -- just because we let some select people know about an option, I still don't think it should be user facing. I'm strongly against the philosophy that a core

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

JonChesterfield added a reviewer: arsenm. JonChesterfield added a comment. Herald added a subscriber: wdng. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84743/new/ https://reviews.llvm.org/D84743 ___ c

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

atrosinenko updated this revision to Diff 281198. atrosinenko added a comment. Fix some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84602/new/ https://reviews.llvm.org/D84602 Files: clang/include/clang/Basic/Attr.td clang/in

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

aaron.ballman added a comment. In D84602#2178328 , @atrosinenko wrote: > In D84602#2176592 , @aaron.ballman > wrote: > >> To be clear, I also don't have a problem with it, but if users aren't >> supposed to be wri

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

njames93 updated this revision to Diff 281200. njames93 added a comment. Replace if/else logic with switches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82898/new/ https://reviews.llvm.org/D82898 Files: clang-tools-extra/clang-tidy/ClangTidyDi

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 updated this revision to Diff 281202. Jac1494 added a comment. Addressed @riccibruno comments.Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84678/new/ https://reviews.llvm.org/D84678 Files: clang/lib/Sema/SemaType.cpp clang/test/Sema/void-argument.cpp Index: clang

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

JonChesterfield added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:66 + /// for NVPTX. + GV_Warp_Size_32, + /// The number of bits required to represent the max number of threads in warp What's the point of warp_size_32? It's

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. In D81865#2176589 , @dblaikie wrote: > I believe this falls under the (using cppreference ( > https://en.cppreference.com/w/cpp/language/union ) , since it's a bit easier > to read) UB clause: " It's undefined behavior to read fr

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. Related work: https://reviews.llvm.org/D81977 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D84182: [OPENMP]Fix PR46012: declare target pointer cannot be accessed in target region.

ye-luo added a comment. In D84182#2173578 , @grokos wrote: > @ABataev: > > After this patch was committed, I tried to run the following example: > > #include > > int *yptr; > > int main() { > int y[10]; > y[1] = 1; > yptr = &y[0];

[PATCH] D84182: [OPENMP]Fix PR46012: declare target pointer cannot be accessed in target region.

ABataev added a comment. In D84182#2178560 , @ye-luo wrote: > In D84182#2173578 , @grokos wrote: > >> @ABataev: >> >> After this patch was committed, I tried to run the following example: >> >> #include >> >>

[PATCH] D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

labath added a comment. In D84554#2176041 , @logan-5 wrote: > In D84554#2175012 , @labath wrote: > >> Could you elaborate on the lldb issue? I'd like to take a look at that... > > It looks like lldb/unittests/Testin

[clang-tools-extra] 7bae318 - [clang-tidy][NFC] Make OptionsView methods as const where missing

Author: Nathan James Date: 2020-07-28T14:52:43+01:00 New Revision: 7bae3188e08746566733148a4ceccdb3cf24e93b URL: https://github.com/llvm/llvm-project/commit/7bae3188e08746566733148a4ceccdb3cf24e93b DIFF: https://github.com/llvm/llvm-project/commit/7bae3188e08746566733148a4ceccdb3cf24e93b.diff

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

jdoerfert added reviewers: tra, MaskRay. jdoerfert added subscribers: MaskRay, tra. jdoerfert added a comment. I like this. I hope this is the start of splitting the `__cuda` headers into generic and specific code, right? @tra @MaskRay any objections on the direction? Commen

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4609 +// their own llvm.global_dtors entry. +CGM.AddCXXStermFinalizerToGlobalDtor(StermFinalizer, 65535); + else jasonliu wro

[PATCH] D84736: [analyzer][RFC] Handle pointer difference of ElementRegion and SymbolicRegion

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, martong, baloghadamsoftware, ASDenysPetrov, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Herald added a project: clang

[clang] 984cf99 - [clang][NFC] Add some documentation about the use of NamedDecl::getDeclName in diagnostics.

Author: Bruno Ricci Date: 2020-07-28T15:39:17+01:00 New Revision: 984cf99055a292b3afe4535c013d38914a3da880 URL: https://github.com/llvm/llvm-project/commit/984cf99055a292b3afe4535c013d38914a3da880 DIFF: https://github.com/llvm/llvm-project/commit/984cf99055a292b3afe4535c013d38914a3da880.diff L

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet added a comment. In D83224#2133457 , @njames93 wrote: > Do you think there should be a hidden command line option to disable > disabling blacklisted checks, purely to prevent hindering attempts to fix > these problematic checks. I would expect

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:202 + // Use buffered stream to stderr. + llvm::errs().SetBuffered(); expla

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:172 std::vector resolveDependentExprToDecls(const Expr *E) { assert(E->isTypeDependent()); if (const auto *ME = dyn_cast(E)) { @nridge, the assertion is not true anymore, sin

[PATCH] D83088: Introduce CfgTraits abstraction

arsenm added inline comments. Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:50 + + // Clang's CFG contains nullpointers for unreachable succesors, e.g. when an + // if statement's condition is always false, it's 'then' branch is represented Mi

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L updated this revision to Diff 281240. Xiangling_L marked 4 inline comments as done. Xiangling_L added a comment. Created alias for sinit and sterm; Adjusted the testcase accordingly; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84534/new/ https://reviews.llvm.org/D84534 Fi

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

riccibruno added a comment. Note that I am planning two improvements as a follow-up to this patch: - For a parameter `(unnamed variable at {{.*}}:: of type )` -> `(unnamed parameter at {{.*}}:: of type )` - For a lambda: - `(unnamed class at {{.*}}::)` -> `(lambda at {{.*}}::)` - For a capt

[PATCH] D83992: [ASTImporter] Add Visitor for TypedefNameDecl's

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83992/new/ https://reviews.llvm.org/D83992 _

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

whisperity added a comment. In D77150#2149870 , @dkrupp wrote: > Since the analyzer cannot cannot model the size of the containers just yet > (or precisely enough), what we are saying with this checker is to "always > check the return value of the erase(

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringLength.h:43 + ProgramStateRef &State, const Expr *Ex, + SVal Buf, bool Hypothetical = false); +

[PATCH] D83992: [ASTImporter] Add Visitor for TypedefNameDecl's

This revision was automatically updated to reflect the committed changes. Closed by commit rGf761acfb1a73: [ASTImporter] Add Visitor for TypedefNameDecl's (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] f761acf - [ASTImporter] Add Visitor for TypedefNameDecl's

Author: Vince Bridgers Date: 2020-07-28T11:52:29-05:00 New Revision: f761acfb1a737d8a631a5e55b58cdb7c2215baad URL: https://github.com/llvm/llvm-project/commit/f761acfb1a737d8a631a5e55b58cdb7c2215baad DIFF: https://github.com/llvm/llvm-project/commit/f761acfb1a737d8a631a5e55b58cdb7c2215baad.diff

[PATCH] D84315: [libTooling] Add a `between` range-selector combinator.

ymandel updated this revision to Diff 281268. ymandel added a comment. updated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84315/new/ https://reviews.llvm.org/D84315 Files: clang/include/clang/Tooling/Transformer/RangeSelector.h clan

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

dblaikie added a comment. In D81865#2178542 , @froydnj wrote: > In D81865#2176589 , @dblaikie wrote: > >> I believe this falls under the (using cppreference ( >> https://en.cppreference.com/w/cpp/language/union ) ,

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

ABataev created this revision. ABataev added reviewers: jdoerfert, ye-luo, RaviNarayanaswamy, grokos. Herald added subscribers: openmp-commits, guansong, yaxunl. Herald added projects: clang, OpenMP. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Need to map the ba

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added a comment. Ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80391/new/ https://reviews.llvm.org/D80391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

dblaikie added a subscriber: echristo. dblaikie added a comment. In D79147#2178104 , @russell.gallop wrote: > Hi, > > It looks like is causing one of the debuginfo-tests: > llgdb-tests/nrvo-string.cpp to fail, run on Linux. Failure as below. I don't > t

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

steakhal added a comment. Thanks for checking this @balazske. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringLength.h:43 + ProgramStateRef &State, const Expr *Ex, + SVal Buf, bool Hypot

[clang] 04a2131 - [libTooling] Add a `between` range-selector combinator.

Author: Yitzhak Mandelbaum Date: 2020-07-28T17:26:12Z New Revision: 04a21318b55756d50836f6e40f2d209f18cce417 URL: https://github.com/llvm/llvm-project/commit/04a21318b55756d50836f6e40f2d209f18cce417 DIFF: https://github.com/llvm/llvm-project/commit/04a21318b55756d50836f6e40f2d209f18cce417.diff

[PATCH] D84315: [libTooling] Add a `between` range-selector combinator.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04a21318b557: [libTooling] Add a `between` range-selector combinator. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D84774: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

ychen created this revision. ychen added reviewers: asbirlea, aeubanks, hans. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, zzheng, hiraditya. Herald added projects: clang, LLVM. ychen requested review of this revision. Problem: Right now, our "Running pass" is not a

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

ABataev updated this revision to Diff 281290. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84457/new/ https://reviews.llvm.org/D84457 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D84774: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

asbirlea added a comment. Does it make sense to have the option to enable seeing where the adaptors are run? Otherwise this looks good, it's nice to have the "Starting" and "Finished" match now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84774

[PATCH] D84736: [analyzer][RFC] Handle pointer difference of ElementRegion and SymbolicRegion

xazax.hun added a comment. I think adding code snippets that are affected by this patch would make it much easier to evaluate the changes and whether this is a good idea or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84736/new/ https://revi

[PATCH] D84774: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

ychen added a comment. In D84774#2179410 , @asbirlea wrote: > Does it make sense to have the option to enable seeing where the adaptors are > run? Adding a static:cl at the top of StandardInstrumentation.cpp should do it. Do you want me to add it now or

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 281296. yaxunl added a comment. Make IEEE single and double type as supported for fp atomics in all targets by default. This is based on the assumption that AtomicExpandPass or its ongoing work is sufficient to support fp atomics for all targets. This is to f

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

tra added a comment. I'm not sure it's particularly useful, to be honest. CUDA code still needs to be compatible with NVCC so it can't be used in portable code like TF or other currently used CUDA libraries. It could be useful internally, though, so I'm fine with it for that purpose.

[PATCH] D84774: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. I'm ok if this is added in either this or a follow-up patch. I think it's useful to have it in the codebase now, with one test to showcase it (e.g. do another run line in `new-pass-manager.

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8686 +CodeGenFunction &CGF, MappableExprsHandler::MapCombinedInfoTy &CombinedInfo, +CGOpenMPRuntime::TargetDataInfo &Info, bool SeparateBeginEnd) { CodeGenModule &CGM = CGF.CGM; -

[PATCH] D84710: [OpenMP][NFC] Consolidate `to` and `from` clause modifiers

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84710/new/ https://reviews.llvm.org/D84710 ___ c

[clang] 394db22 - Revert "Switch to using -debug-info-kind=constructor as default (from =limited)"

Author: Amy Huang Date: 2020-07-28T11:23:59-07:00 New Revision: 394db2259575ef3cac8d3d37836b11eb2373c435 URL: https://github.com/llvm/llvm-project/commit/394db2259575ef3cac8d3d37836b11eb2373c435 DIFF: https://github.com/llvm/llvm-project/commit/394db2259575ef3cac8d3d37836b11eb2373c435.diff LOG

[PATCH] D83997: [os_log] Improve the way we extend the lifetime of objects passed to __builtin_os_log_format

rjmccall added a comment. In D83997#2169745 , @ahatanak wrote: > The use case for this is a macro in which the call to > `__builtin_os_log_format` that writes to the buffer and the call that uses > the buffer appear in two different statements. For examp

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringLength.h:43 + ProgramStateRef &State, const Expr *Ex, + SVal Buf, bool Hypothetical = false); +

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:73-74 .Default(OMPC_MOTION_MODIFIER_unknown); +if (OpenMPVersion < 51 && Type != OMPC_MOTION_MODIFIER_mapper) + return OMPC_MOTION_MODIFIER_unknown; +return Type; Bet

[PATCH] D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733

zahiraam created this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, AlexeySotkin, msifontes, jurahul, Kayjukh, grosul1, bader, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini, hiraditya, mgorny. He

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few style nits. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:629 Priority = std::make_tuple(Begin, Type, -End,

[PATCH] D84781: Use PointerUnion instead of inheritance for alternative clauses in NNS

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84781 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/include/clang/T

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:78 + char getOpenDelimiter() const { return MSVCFormatting ? '`' : '('; } + char getCloseDelimiter() const { return MSVCFormatting ? '\'' : ')'; } These names a bit too g

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

tlively added a comment. In D66035#2178105 , @pmatos wrote: > Please ignore my `.gitlab-ci.yml`. That's just an internal change that I got > uploaded by mistake. > I am looking to see this through and start discussion on this with the goal > of landing i

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

tra added a comment. I think Sam's approach is reasonable. The ability to supply CUID to sub-compilations is useful by itself and should probably be split into a separate patch as it's largely independent of the externalization of file-scope static vars. CHANGES SINCE LAST ACTION https://re

[PATCH] D84202: [clang][noderef] Enable -Wnoderef warning for CXX C-style casts

aaron.ballman added a comment. > users can still disable the warning on line granularity with pragmas. This makes me a bit uncomfortable because those pragmas extremely ugly (and not easily portable). Also, this will break code for users who were previously doing something that was explicitly a

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 281311. guiand added a comment. Incorporate C++'s more conservative checks for omitted return values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files: clang/inclu

[PATCH] D84774: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

aeubanks accepted this revision. aeubanks added a comment. Thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84774/new/ https://reviews.llvm.org/D84774 ___ cfe-commits mailing list cfe

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 281322. simoll added a comment. - Rebased - Implement `EmitFromMemory` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, looks good to me with a small test addition. Comment at: clang/test/CodeGen/builtins-overflow.c:123 + // CHECK: br i1 [[C2]] + int r; + if (__builtin_mul_overflow(x, y,

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 281323. guiand edited the summary of this revision. guiand added a comment. Fixes regression; allows emitting noundef for non-FunctionDecls as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https

  1   2   3   >