aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a few style nits.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:629
Priority = std::make_tuple(Begin, Type, -End, -ErrorSize, ErrorId);
- else
+ return;
+ case ET_Insert:
----------------
I'd drop these `return` statements and the unreachable, below. The switch is
fully-covered, so we'll get a diagnostic if any new enumerations are added and
we forget to update this switch.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:703
+ Apply[Event.ErrorId] = false;
+ continue;
+ case Event::ET_Insert:
----------------
Similar here with `continue` and the unreachable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82898/new/
https://reviews.llvm.org/D82898
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
