aaron.ballman added inline comments.
================
Comment at: clang/include/clang/AST/PrettyPrinter.h:78
+ char getOpenDelimiter() const { return MSVCFormatting ? '`' : '('; }
+ char getCloseDelimiter() const { return MSVCFormatting ? '\'' : ')'; }
----------------
These names a bit too generic: open/close delimiter for *what* (there's a lot
of paired delimiters to consider when pretty printing). Perhaps
`getUnnamedIdentOpenDelimiter()` or something to make it more clear that this
isn't, say, an attribute delimiter?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84658/new/
https://reviews.llvm.org/D84658
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
