[PATCH] D83099: Revert "[clangd] Store index in '.clangd/index' instead of '.clangd-index'"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9b55bc4d1197: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index' (authored by sammccall). Changed

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:42 - /// *outlined_function, int16_t - /// IsOMPRuntimeInitialized); OMPRTL_NVPTX__kmpc_kernel_prepare_parallel, I think, instead the optimizer can try to detect if the run

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

kbobyrev updated this revision to Diff 276030. kbobyrev added a comment. Add assertions for ensuring paths have UNIX slashes during deserialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82938/new/ https://reviews.llvm.org/D82938 Files:

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

JonChesterfield added a comment. I'm not sure we have a consensus on api stability. Usually llvm allows mixing libraries and compilers from different sources, e.g. the various libunwind or compiler-rt vs libgcc. Libomptarget in general appears to be considered fixed and has external users (int

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Aside from the API stability concern this looks uncontentious. Removes dead arguments, generally makes things simpler. Thus LGTM. @Hahnfeld @ABataev - are you sufficiently pe

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

ABataev added a comment. In D83268#2135930 , @JonChesterfield wrote: > Aside from the API stability concern this looks uncontentious. Removes dead > arguments, generally makes things simpler. Thus LGTM. > > @Hahnfeld @ABataev - are you sufficiently persu

[clang] 41bbb87 - [NFC] Use hasAnyName matcher in place of anyOf(hasName()...)

Author: Nathan James Date: 2020-07-07T14:31:04+01:00 New Revision: 41bbb875e4da392ae37300d3a6282b6595f14503 URL: https://github.com/llvm/llvm-project/commit/41bbb875e4da392ae37300d3a6282b6595f14503 DIFF: https://github.com/llvm/llvm-project/commit/41bbb875e4da392ae37300d3a6282b6595f14503.diff

[PATCH] D83242: [RFC][BPF] support expr with typedef type for FIELD_EXISTENCE reloc

jrfastab added a comment. Agreed also useful for us. I can pull it in and test if that is useful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83242/new/ https://reviews.llvm.org/D83242 ___ cfe-commit

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert marked an inline comment as done. jdoerfert added a comment. > I don't think gcc can be using this runtime library for nvptx. Yes, and: We are (going to) use clang specific intrinsics to avoid CUDA (soon). > Use of the new library with the previous version of the compiler. Except that

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

JonChesterfield added a comment. In D83268#2135938 , @ABataev wrote: > > @Hahnfeld @ABataev - are you sufficiently persuaded that preserving the > > current interface is not worth the development cost? > > No, I'm not. Long before that, we relied on the A

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille added a comment. Some nit-picking, lgtm otherwise. Please wait for @calixte review though :-) Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush");

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert added a comment. > Especially taking into account, that libomp can be built separately. This is *not* affecting libomp in any way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83268/new/ https://reviews.llvm.org/D83268 __

[PATCH] D82930: [HIP] Fix rocm detection

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) yaxunl wrote: > yaxunl wrote: > > yaxunl wrote: > > > tra wrote:

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:13791 + // Ensure that the load from the narrow width is being zero extended to i128. + if ((!ValidLDType) || (LD->getValueType(0) != MVT::i128) || + (LD->getExtensionType() != ISD::ZEXTLOAD

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

jmorse updated this revision to Diff 276040. jmorse added a comment. (Rebase, only affecting LiveDebugValues.cpp) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83048/new/ https://reviews.llvm.org/D83048 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/

[PATCH] D83301: [clang-tidy] More strict on matching the standard memset function in memset-usage check.

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. Herald added a project: clang. The check assumed the matched function call has 3 arguments, but the matcher didn't guaranteed that. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

ABataev added a comment. In D83268#2135955 , @jdoerfert wrote: > > Especially taking into account, that libomp can be built separately. > > This is *not* affecting libomp in any way. libomptarget and device runtimes are part of libomp. If you're going to

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

ABataev added a comment. In D83268#2135954 , @JonChesterfield wrote: > In D83268#2135938 , @ABataev wrote: > > > > @Hahnfeld @ABataev - are you sufficiently persuaded that preserving the > > > current interface is

[clang] ed39bec - [OpenMP][NFC] Remove hard-coded line numbers from more tests

Author: Joel E. Denny Date: 2020-07-07T09:48:22-04:00 New Revision: ed39becd274dae5537c24b2107737d718527e718 URL: https://github.com/llvm/llvm-project/commit/ed39becd274dae5537c24b2107737d718527e718 DIFF: https://github.com/llvm/llvm-project/commit/ed39becd274dae5537c24b2107737d718527e718.diff

[PATCH] D83057: [OpenMP][NFC] Remove hard-coded line numbers from more tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGed39becd274d: [OpenMP][NFC] Remove hard-coded line numbers from more tests (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83057/new/ ht

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SufficientSizeArrayIndexingChecker.cpp:27 +: public Checker> { + mutable std::unique_ptr BT; + The bug type can be initialized here: `BT{this, "...", "..."}` How did this compile

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert added a comment. In D83268#2135989 , @ABataev wrote: > In D83268#2135954 , @JonChesterfield > wrote: > > > What can libomp be built by separately? Nvcc and gcc don't use this > > runtime. That leaves us

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert added a comment. In D83268#2135988 , @ABataev wrote: > In D83268#2135955 , @jdoerfert wrote: > > > > Especially taking into account, that libomp can be built separately. > > > > This is *not* affecting lib

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

ABataev added a comment. In D83268#2136021 , @jdoerfert wrote: > In D83268#2135988 , @ABataev wrote: > > > In D83268#2135955 , @jdoerfert > > wrote: > > > > > > Especially t

[PATCH] D83057: [OpenMP][NFC] Remove hard-coded line numbers from more tests

jdenny added a comment. Thanks for the quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83057/new/ https://reviews.llvm.org/D83057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

ABataev added a comment. In D83268#2135951 , @jdoerfert wrote: > > I don't think gcc can be using this runtime library for nvptx. > > Yes, and: We are (going to) use clang specific intrinsics to avoid CUDA > (soon). > > > Use of the new library with the p

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert added a comment. In D83268#2136031 , @ABataev wrote: > There is still compatibility between clang10 and clang11. Or they are > incompatible in LLVM IR level? That is the point. They might or might not be, right? There is no guarantee they are

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert added a comment. In D83268#2136029 , @ABataev wrote: > `llvm-project/openmp/libomptarget` Please use more words. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83268/new/ https://reviews.llvm.org

[PATCH] D83057: [OpenMP][NFC] Remove hard-coded line numbers from more tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGed39becd274d: [OpenMP][NFC] Remove hard-coded line numbers from more tests (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83057/new/ ht

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

ABataev added a comment. In D83268#2136054 , @jdoerfert wrote: > In D83268#2136029 , @ABataev wrote: > > > `llvm-project/openmp/libomptarget` > > > Please use more words. libomptarget is part of libomp Repositor

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

ABataev added a comment. In D83268#2136049 , @jdoerfert wrote: > In D83268#2136031 , @ABataev wrote: > > > There is still compatibility between clang10 and clang11. Or they are > > incompatible in LLVM IR level? >

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert added a comment. In D83268#2136055 , @ABataev wrote: > In D83268#2136054 , @jdoerfert wrote: > > > In D83268#2136029 , @ABataev wrote: > > > > > `llvm-project/openm

[PATCH] D80301: [yaml][clang-tidy] Fix multiline YAML serialization

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, this seems like a pretty clean solution. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.ll

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

jdoerfert updated this revision to Diff 276053. jdoerfert marked an inline comment as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80897/new/ https://reviews.llvm.org/D80897 Files: clang/lib/H

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

Hahnfeld added a comment. In D83268#2135930 , @JonChesterfield wrote: > Aside from the API stability concern this looks uncontentious. Removes dead > arguments, generally makes things simpler. Thus LGTM. > > @Hahnfeld @ABataev - are you sufficiently pers

[clang] 85f5d12 - [ASTImporter] Corrected import of repeated friend declarations.

Author: Balázs Kéri Date: 2020-07-07T16:24:24+02:00 New Revision: 85f5d1261c9a3f0abc4ae370005a1127174f2ce1 URL: https://github.com/llvm/llvm-project/commit/85f5d1261c9a3f0abc4ae370005a1127174f2ce1 DIFF: https://github.com/llvm/llvm-project/commit/85f5d1261c9a3f0abc4ae370005a1127174f2ce1.diff L

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG85f5d1261c9a: [ASTImporter] Corrected import of repeated friend declarations. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:523 + if (isa(RT->getDecl())) { +if (!(AllowNoUniqueAddr && FD->hasAttr())) + return false; Minor nit: The nested `if` could be merged with the outer one: ``` i

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG85f5d1261c9a: [ASTImporter] Corrected import of repeated friend declarations. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a testing request. Comment at: clang-tools-extra/clang-tidy/bugprone/NoEscapeCheck.cpp:34 + const BlockDecl *EscapingBlockDecl = MatchedEscapingBlock

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

arichardson added a comment. @MaskRay are you okay with me committing this change and delaying the global search-replace? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478 _

[PATCH] D81552: [ASTMatchers] Added hasDirectBase Matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a whitespace nit. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2895 + BaseSpecMatcher) { + + return Node.hasDefinition() &&

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

balazske added a comment. Ping This is a better fix for the previous problem, and makes the code better too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81061/new/ https://reviews.llvm.org/D81061 ___

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-no-escape.m:1 +// RUN: %check_clang_tidy %s bugprone-no-escape %t + aaron.ballman wrote: > Can you add an additional RUN line so we get coverage of the blocks-enabled

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert added a comment. In D83268#2136060 , @ABataev wrote: > Better to ask the users. Maybe, send an RFC to openmp-devs? Sure: http://lists.llvm.org/pipermail/openmp-dev/2020-July/003531.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened marked an inline comment as done. greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source') parser

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. The original plan was to enable the check for the functions listed in ERR33-C . But there are many other functions that work in similar way (like `mmap` that is not in the

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev accepted this revision. ABataev added a comment. LGTM with a nit. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2787 + if (getLangOpts().OpenMP < 51 && Kind == OMPC_default && + static_cast(Val.getValue().Type) == + OMP_DEFAULT_firstprivate) { -

[PATCH] D82278: Fix traversal over CXXConstructExpr in Syntactic mode

aaron.ballman added reviewers: rsmith, sammccall. aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp:80 auto Matches = - match(expr(hasDescendant(typeLoc().bind("t"))), *E, *Result.Context); + match(traverse(TK_

[clang] b0d3ea1 - [ASTMatchers] Added hasDirectBase Matcher

Author: Nathan James Date: 2020-07-07T16:05:11+01:00 New Revision: b0d3ea171bd56b3b079be9213935925e1499df15 URL: https://github.com/llvm/llvm-project/commit/b0d3ea171bd56b3b079be9213935925e1499df15 DIFF: https://github.com/llvm/llvm-project/commit/b0d3ea171bd56b3b079be9213935925e1499df15.diff

[PATCH] D81552: [ASTMatchers] Added hasDirectBase Matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0d3ea171bd5: [ASTMatchers] Added hasDirectBase Matcher (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D81552?vs=275991&id=276073#toc Repository: rG LLVM Github Monorepo C

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

ABataev added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' You need to insert an additional check for `OMPClauseKind == llvm::omp::Clause::OM

[clang] 1a2f482 - [Clang] Handle AIX Include management in the driver

Author: Shuhong Liu Date: 2020-07-07T11:15:06-04:00 New Revision: 1a2f4824cb2d472649e65f845510ac0e47ca98c1 URL: https://github.com/llvm/llvm-project/commit/1a2f4824cb2d472649e65f845510ac0e47ca98c1 DIFF: https://github.com/llvm/llvm-project/commit/1a2f4824cb2d472649e65f845510ac0e47ca98c1.diff L

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a2f4824cb2d: [Clang] Handle AIX Include management in the driver (authored by ShuhongL, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 276076. oontvoo marked 2 inline comments as done. oontvoo added a comment. prevent diagnostics for dependent types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 276077. oontvoo added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/attr-trivial-abi.cpp

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 276084. oontvoo added a comment. one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/attr-trivial

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor added a comment. I think we are talking about different things. My question was why is this a 'Shell' test (like, a test in the `Shell` directory that uses FileCheck) and not a test in the `API` directory (using Python). An 'API' test could use the proper expression testing tools. And

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb0d3ea171bd5: [ASTMatchers] Added hasDirectBase Matcher (authored by njames93). Changed prior to commit: https://review

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a2f4824cb2d: [Clang] Handle AIX Include management in the driver (authored by ShuhongL, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

sammccall added a comment. This looks better to me but: - i think we need to consider what happens when paths are not under the expected path, and handle that in some appropriate way - I find it hard to see what the tests are actually testing - would be good to make them more explicit, using a

[PATCH] D83233: [clangd] Enable reading config from files by default.

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:436 +"Project config is from a .clangd file in the project directory.\n" +"User config is from clangd/config.yaml in the following

[PATCH] D83315: Turn arcmt-* options into a single option

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. - The new option, -arcmt-action, is a simple enum based option. - The driver is modified to translate the existing -ccc-acmt-* options

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

nikic added inline comments. Comment at: llvm/test/Other/opt-O2-pipeline.ll:289 +; CHECK-NEXT: Branch Probability Analysis +; CHECK-NEXT: Block Frequency Analysis ; CHECK-NEXT: FunctionPass Manager hans wrote: > nikic wrote: > > Is it possibl

[PATCH] D83317: [Sema] Teach -Wcast-align to compute alignment of CXXThisExpr

ahatanak created this revision. ahatanak added reviewers: rjmccall, jyknight. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. This fixes https://bugs.llvm.org/show_bug.cgi?id=46605. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83317

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. Possible improvements (this is at least a note for me): - The checker can try to find a check for error-return value until the symbol (to check) is released. The warning is generated only if no check for error-return was found. This way works for functions that return

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

ebevhan added a comment. I know this is some really late feedback on this patch. I struck upon some issues with while rebasing D62574 . Comment at: clang/lib/Sema/SemaExprCXX.cpp:4106 + NewToType = Context.getAddrSpaceQualType(NewToType, +

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis updated this revision to Diff 276095. ellis added a comment. Add RUN line to test in C Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82904/new/ https://reviews.llvm.org/D82904 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan added a comment. It seems that D70605 attempted to ameliorate the issues that I observed (pointer-conversion doing too much), but it didn't manage to solve the problem fully. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://rev

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:647-653 CmdLineOption ]>, baloghadamsoftware wrote: > Szelethus wrote: > > Szelethus wrote: > > > NoQ wrote: > > > > baloghadamsoftware wrote: > > > > > Szeleth

[PATCH] D83254: [X86] Enabled a bunch of 64-bit Interlocked* functions intrinsics on 32-bit Windows to match recent MSVC

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83254/new/ https://reviews.llvm.org/D83254 ___ cfe-commits mailing list cfe-commits

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

tra accepted this revision. tra added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80897/new/ https://reviews.llvm.org/D80897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 276106. fpetrogalli added a comment. Removed the unrelated change of the empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83079/new/ https://reviews.llvm.org/D83079 Files: clang/lib/Driver/ToolC

[PATCH] D62574: Initial draft of target-configurable address spaces.

danilaml added a comment. In D62574#2135662 , @ebevhan wrote: > It's generally not safe to alter address spaces below the top level. C is > just very permissive about it. Isn't that also true for the top-level casts? Unless when it is. And the target s

[PATCH] D83145: [HIP] Use default triple in llvm-mc for system ld

This revision was automatically updated to reflect the committed changes. Closed by commit rGc64bb3f7367a: [HIP] Use default triple in llvm-mc for system ld (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES S

[clang] c64bb3f - [HIP] Use default triple in llvm-mc for system ld

Author: Aaron En Ye Shi Date: 2020-07-07T16:44:51Z New Revision: c64bb3f7367a924e9d17dfc1c92897e6cbe1 URL: https://github.com/llvm/llvm-project/commit/c64bb3f7367a924e9d17dfc1c92897e6cbe1 DIFF: https://github.com/llvm/llvm-project/commit/c64bb3f7367a924e9d17dfc1c92897e6cbe1.diff LO

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

shafik added a comment. In D83008#2136303 , @teemperor wrote: > I think we are talking about different things. My question was why is this a > 'Shell' test (like, a test in the `Shell` directory that uses FileCheck) and > not a test in the `API` director

[PATCH] D83317: [Sema] Teach -Wcast-align to compute alignment of CXXThisExpr

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83317/new/ https://reviews.llvm.org/D83317 ___

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: llvm/test/Other/opt-O2-pipeline.ll:289 +; CHECK-NEXT: Branch Probability Analysis +; CHECK-NEXT: Block Frequency Analysis ; CHECK-NEXT: FunctionPass Manager ---

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

svenvh marked an inline comment as done. svenvh added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4106 + NewToType = Context.getAddrSpaceQualType(NewToType, + FromPteeType.getAddressSpace()); + if (ToType->is

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

ebevhan added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4106 + NewToType = Context.getAddrSpaceQualType(NewToType, + FromPteeType.getAddressSpace()); + if (ToType->isObjCObjectPointerType()) ---

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis updated this revision to Diff 276118. ellis added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82904/new/ https://reviews.llvm.org/D82904 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D83145: [HIP] Use default triple in llvm-mc for system ld

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc64bb3f7367a: [HIP] Use default triple in llvm-mc for system ld (authored by ashi1). Herald added a project: clang. Herald

[PATCH] D82930: [HIP] Fix rocm detection

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > yaxunl wrote: > > yaxunl wrote: > > > yaxunl wrote:

[clang] 6cf0dac - orrectly generate invert xor value for Binary Atomics of int size > 64

Author: Jennifer Yu Date: 2020-07-07T10:20:14-07:00 New Revision: 6cf0dac1ca3fd56c51f6a60f0be01cc25a1a2c6a URL: https://github.com/llvm/llvm-project/commit/6cf0dac1ca3fd56c51f6a60f0be01cc25a1a2c6a DIFF: https://github.com/llvm/llvm-project/commit/6cf0dac1ca3fd56c51f6a60f0be01cc25a1a2c6a.diff L

[PATCH] D82832: Correctly generate invert xor value for Binary Atomics of int size > 64

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cf0dac1ca3f: orrectly generate invert xor value for Binary Atomics of int size > 64 (authored by jyu2). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis added a comment. Hey @aaron.ballman, thanks for accepting my diff! Would you mind landing my diff since I don't have commit access yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82904/new/ https://reviews.llvm.org/D82904 _

[clang] 7437a94 - [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

Author: Erik Pilkington Date: 2020-07-07T13:29:54-04:00 New Revision: 7437a9496528b838e6939dbcbb69a0acb5e1332d URL: https://github.com/llvm/llvm-project/commit/7437a9496528b838e6939dbcbb69a0acb5e1332d DIFF: https://github.com/llvm/llvm-project/commit/7437a9496528b838e6939dbcbb69a0acb5e1332d.dif

[clang] 2f71cf6 - [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

Author: Erik Pilkington Date: 2020-07-07T13:29:54-04:00 New Revision: 2f71cf6d77c5cc679968851080d0513d84ddccb6 URL: https://github.com/llvm/llvm-project/commit/2f71cf6d77c5cc679968851080d0513d84ddccb6 DIFF: https://github.com/llvm/llvm-project/commit/2f71cf6d77c5cc679968851080d0513d84ddccb6.dif

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

This revision was automatically updated to reflect the committed changes. Closed by commit rG7437a9496528: [SemaObjC] Add a warning for @selector expressions that potentially refer to… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2f71cf6d77c5: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional… (authored by erik.pilkingto

[PATCH] D83315: Turn arcmt-* options into a single option

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. I have a slight preference for `-arcmt-action=`, but up to you if you want to change it. Otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang-tools-extra] dfa0db7 - Warn pointer captured in async block

Author: Ellis Hoag Date: 2020-07-07T13:31:14-04:00 New Revision: dfa0db79d0e37d5cf24a63d1e2b7ba5f40617574 URL: https://github.com/llvm/llvm-project/commit/dfa0db79d0e37d5cf24a63d1e2b7ba5f40617574 DIFF: https://github.com/llvm/llvm-project/commit/dfa0db79d0e37d5cf24a63d1e2b7ba5f40617574.diff LO

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

aaron.ballman closed this revision. aaron.ballman added a comment. In D82904#2136686 , @ellis wrote: > Hey @aaron.ballman, thanks for accepting my diff! Would you mind landing my > diff since I don't have commit access yet? Gladly -- I've committed on y

[PATCH] D83325: [Sema] Be more thorough when unpacking the AS-qualified pointee for a pointer conversion.

ebevhan created this revision. ebevhan added reviewers: svenvh, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. When performing a pointer conversion as the second conversion in an SCS where the conversion is a derived-to-base and the address space of the type wants

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan added a comment. In D62574#2136553 , @danilaml wrote: > In D62574#2135662 , @ebevhan wrote: > > > It's generally not safe to alter address spaces below the top level. C is > > just very permissive about it.

[PATCH] D82574: Merge TableGen files used for clang options

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. We can look at splitting it up again once we know what the dependencies are. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82574/new

[PATCH] D82832: Correctly generate invert xor value for Binary Atomics of int size > 64

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cf0dac1ca3f: orrectly generate invert xor value for Binary Atomics of int size > 64 (authored by jyu2). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. erik.pilkington marked an inline comment as done. Closed by commit rG7437a9496528: [SemaObjC] Add a warning for @selector expressions that po

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2f71cf6d77c5: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional… (authored by erik.pilkingto

<    1   2   3   >