hubert.reinterpretcast added inline comments.
================ Comment at: clang/lib/CodeGen/TargetInfo.cpp:523 + if (isa<CXXRecordDecl>(RT->getDecl())) { + if (!(AllowNoUniqueAddr && FD->hasAttr<NoUniqueAddressAttr>())) + return false; ---------------- Minor nit: The nested `if` could be merged with the outer one: ``` if (isa<CXXRecordDecl>(RT->getDecl()) && !(AllowNoUniqueAddr && FD->hasAttr<NoUniqueAddressAttr>())) return false; ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81583/new/ https://reviews.llvm.org/D81583 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits