[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet updated this revision to Diff 226619. kadircet added a comment. - Don't rename if parameters have the same name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937 Files: clang-tools-extra/clangd/ref

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov updated this revision to Diff 226620. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Update the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69382/new/ https://reviews.llvm.org/D69382 Files:

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:483 bool EnableFunctionArgSnippets; + bool CompleteArgumentList; }; kadircet wrote: > kadircet wrote: > > maybe rather use `GenerateSnippets`? Since this doesn't gener

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

merge_guards_bot added a comment. Build result: fail - 59587 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[clang-tools-extra] d9971d0 - [clangd] Do not insert parentheses when completing a using declaration

Author: Ilya Biryukov Date: 2019-10-28T09:45:10+01:00 New Revision: d9971d0b2e34a6a5ca182089d019c9f079f528af URL: https://github.com/llvm/llvm-project/commit/d9971d0b2e34a6a5ca182089d019c9f079f528af DIFF: https://github.com/llvm/llvm-project/commit/d9971d0b2e34a6a5ca182089d019c9f079f528af.diff

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9971d0b2e34: [clangd] Do not insert parentheses when completing a using declaration (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 accepted this revision. vit9696 added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ https://reviews.llvm.org/D67787 __

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

merge_guards_bot added a comment. Build result: pass - 59695 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:233 - bool VisitTypeLoc(TypeLoc TL) { -if (auto K = kindForType(TL.getTypePtr())) as we are not visiting this base `TypeLoc` in this patch, will we miss any intere

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:233 - bool VisitTypeLoc(TypeLoc TL) { -if (auto K = kindForType(TL.getTypePtr())) hokein wrote: > as we are not visiting this base `TypeLoc` in this patch, w

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:233 - bool VisitTypeLoc(TypeLoc TL) { -if (auto K = kindForType(TL.getTypePtr())) il

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGda720a38b9f2: [AArch64][SVE] Implement masked load intrinsics (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D68877?vs=226123&id=226628#toc Repository: rG LLVM Github Mo

Re: r375125 - [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object

Since we ran into a couple of errors in Chromium when rolling past this, would you like to add a note about it in the release notes since it's possible that others will be affected too? On Thu, Oct 17, 2019 at 5:24 PM James Y Knight via cfe-commits wrote: > > Author: jyknight > Date: Thu Oct 17 0

[clang] 5d35b7d - [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

Author: vhscampos Date: 2019-10-28T10:59:18Z New Revision: 5d35b7d9e1a34b45c19609f754050e4263bee4ce URL: https://github.com/llvm/llvm-project/commit/5d35b7d9e1a34b45c19609f754050e4263bee4ce DIFF: https://github.com/llvm/llvm-project/commit/5d35b7d9e1a34b45c19609f754050e4263bee4ce.diff LOG: [AR

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d35b7d9e1a3: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64 (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

ilya-biryukov added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69431/new/ https://reviews.llvm.org/D69431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang-tools-extra] c814f4c - [clangd] Do not highlight keywords in semantic highlighting

Author: Ilya Biryukov Date: 2019-10-28T12:03:09+01:00 New Revision: c814f4c4592cf0a6049a56b09442369d8e6eb9d7 URL: https://github.com/llvm/llvm-project/commit/c814f4c4592cf0a6049a56b09442369d8e6eb9d7 DIFF: https://github.com/llvm/llvm-project/commit/c814f4c4592cf0a6049a56b09442369d8e6eb9d7.diff

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit rGc814f4c4592c: [clangd] Do not highlight keywords in semantic highlighting (authored by ilya-biryukov). Changed prior to commit: https://reviews.llvm.org/D69431?vs=226419&id=226632#toc Repository: rG

[clang-tools-extra] 3cb5764 - [clangd] Flush streams when printing HoverInfo Name and Definition

Author: Kadir Cetinkaya Date: 2019-10-28T12:05:03+01:00 New Revision: 3cb5764f900284666dbb0342c487edb1fde4d7fc URL: https://github.com/llvm/llvm-project/commit/3cb5764f900284666dbb0342c487edb1fde4d7fc DIFF: https://github.com/llvm/llvm-project/commit/3cb5764f900284666dbb0342c487edb1fde4d7fc.dif

[clang] f6e11a3 - [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE

Author: vhscampos Date: 2019-10-28T11:06:58Z New Revision: f6e11a36c49c065cd71e9c54e4fba917da5bbf2e URL: https://github.com/llvm/llvm-project/commit/f6e11a36c49c065cd71e9c54e4fba917da5bbf2e DIFF: https://github.com/llvm/llvm-project/commit/f6e11a36c49c065cd71e9c54e4fba917da5bbf2e.diff LOG: [AR

[PATCH] D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6e11a36c49c: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D69378: [AArch64][SVE] Implement masked store intrinsics

kmclaughlin updated this revision to Diff 226640. kmclaughlin added a reviewer: sdesmalen. kmclaughlin added a comment. - Split functions in sve-masked-ldst-nonext.ll into separate load & store tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69378/new/ https://reviews.llvm.org/D6937

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:269 +cat(Features), +desc("Enable cross-file rename feature."), +init(false), ilya-biryukov wrote: > Could you document that the feature is highly experimental and

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 226641. hokein marked 3 inline comments as done. hokein added a comment. address comments: - make the command-line flag hidden; - use the gtesting matcher; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new

Re: Zorg migration to GitHub/monorepo

Hi Galina, It seems that our libcxx bots are now triggering builds for any changes to llvm: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux/builds/2434 Should I file a bug report for this? Thanks, Diana On Sat, 19 Oct 2019 at 11:36, Galina Kistanova via cfe-commits w

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. Roman, could you please take another look at it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D69391: Add #pragma clang loop ivdep

YashasAndaluri updated this revision to Diff 226644. YashasAndaluri edited the summary of this revision. YashasAndaluri changed the edit policy from "Administrators" to "All Users". YashasAndaluri added a comment. Removed disable argument for ivdep Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:22 + +bool CheckPotentiallyTriviallyDestructible(const CXXDestructorDecl *Dtor) { + if (Dtor->isFirstDecl() || !Dtor->isExplicitlyDefaulted())

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: pass - 59701 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69506: [clangd] Add missing highlights for using decls.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69506 Files: clang-tools-extra/clangd/SemanticHighligh

[PATCH] D69266: [clangd] Define out-of-line availability checks

hokein accepted this revision. hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1549 + + // Not available for out-of-line metohds. + EXPECT_UNAVAILABLE(R"cpp( nit: metohds => methods. Repository: rG LLVM Github Mon

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:55 + // Include template parameter list. + if (auto *FTD = FD->getDescribedFunctionTemplate()) +return FTD->getBeginLoc(); Could you confirm the code handle

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 226648. abelkocsis added a comment. Small fix in documentation Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-tools-extra/clang-tidy/bugprone/BadSigna

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:278 +const auto *Target = +llvm::dyn_cast(Ref.Targets.front()->getCanonicalDecl()); +auto It = Pa

[PATCH] D69506: [clangd] Add missing highlights for using decls.

merge_guards_bot added a comment. Build result: pass - 59702 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Otherwise every client dealing with name location should handle anonymous names in a special manner. This seems to

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

kousikk added a comment. I discussed with @klimek about this. The conclusion we arrived at was: Allowing override of `resource-dir` for all tools is not something we should do (for reasons that @klimek has outlined above). However, the dependency scanner tool can choose to override `resource-di

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

ilya-biryukov added a comment. Stumbled upon it when trying to move semantic highlight to use `findExplicitReferences`. This will create some trouble for D68937 , but I believe it's actually worth it. `NameLoc` was never intended to point outside the name token.

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindTarget.cpp:454 + if (ND->getDeclName().isIdentifier() && + !ND->getDeclName().getAsIdentifierInfo()) +retur

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet updated this revision to Diff 226655. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937 Files: clang-tools-ex

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

hokein added a comment. Thanks, I'm fine with the current approach, feel free to add unittests. Comment at: clang-tools-extra/clangd/Protocol.h:1212 std::string Tokens; + /// Is the line in an inactive preprocessor branch? + bool IsInactive = false; could

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:453 + // and the clients are not prepared to handle that. + if (ND->getDeclName().isIdentifier() && + !ND->getDeclName().getAsIdentifierInfo()) i believe this w

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

merge_guards_bot added a comment. Build result: pass - 59699 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c430a7c6f6b: [clangd] Do not report anonymous entities in findExplicitReferences (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang-tools-extra] 4c430a7 - [clangd] Do not report anonymous entities in findExplicitReferences

Author: Ilya Biryukov Date: 2019-10-28T14:41:34+01:00 New Revision: 4c430a7c6f6b11105963c6a0ff1e6ee31517a1c8 URL: https://github.com/llvm/llvm-project/commit/4c430a7c6f6b11105963c6a0ff1e6ee31517a1c8 DIFF: https://github.com/llvm/llvm-project/commit/4c430a7c6f6b11105963c6a0ff1e6ee31517a1c8.diff

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:453 + // and the clients are not prepared to handle that. + if (ND->getDeclName().isIdentifier() && + !ND->getDeclName().get

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

ilya-biryukov added a comment. D69511 broke the anonymous parameters. Sorry about that, I hope that's for the best in the long run :-) We'll need some code to update this patch. Other than that, I think this patch is good to go! Repository: rG LLVM Github Mo

[PATCH] D69506: [clangd] Add missing highlights for using decls.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:51 } + if (auto *UD = dyn_cast(D)) { +if (UD->shadow_size() == 0) Could we reuse `kindForCandidateDecls` instead? It's best to keep one way to highlight mul

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:233 +bool fillTemplateParameterMapping( +const FunctionDecl *Dest, const FunctionDecl *Source, +llvm::DenseMap &ParamToNewName) { NIT: instead of re

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

6yearold added a comment. I'm seeing quite similar errors on FreeBSD with Clang 8 and 9: In file included from :1: In file included from /usr/local/llvm90/lib/clang/9.0.0/include/__clang_cuda_runtime_wrapper.h:204: /usr/home/arr/cuda/var/cuda-repo-10-0-local-10.0.130-410.48/usr/local/cuda

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

thakis added a comment. After this, Class can no longer be used as a key type in an Obj-C dictionary literal. Is that intentional? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67983/new/ https://reviews.llvm.org/D67983

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

merge_guards_bot added a comment. Build result: fail - 59657 tests passed, 2 failed and 805 were skipped. failed: libc++.libcxx/thread/thread_threads/thread_thread_this/sleep_for.pass.cpp failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

Eugene.Zelenko added a comment. You should also add actual alias code to //cert// module. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 ___ cfe-commits mailing

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

emankov added a comment. In D60220#1723350 , @6yearold wrote: > I'm seeing quite similar errors on FreeBSD with Clang 8 and 9: > Any idea how to fix this? It looks like CUDA doesn't support `double` argument for device function __isnan on FreeBSD. 1.

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd157a9bc8ba1: Add Windows Control Flow Guard checks (/guard:cf). (authored by ajpaverd, committed by theraven). Repositor

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

jyknight added a comment. In D67983#1723376 , @thakis wrote: > After this, Class can no longer be used as a key type in an Obj-C dictionary > literal. Is that intentional? Such code was already an on by default incompatible-pointer-types warning in Obj

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

Yi-Hong.Lyu added a comment. Seem this commit broke buildbot http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6881 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68877/new/ https://reviews.llvm.org/D68877

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:75 +// and if found, extend the SourceRange to start at 'Name'. +std::pair +CtorSourceRange(const MatchFinder::MatchResult &Result, You can dro

[PATCH] D69506: [clangd] Add missing highlights for using decls.

hokein updated this revision to Diff 226673. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69506/new/ https://reviews.llvm.org/D69506 Files: clang-tools-extra/cla

[PATCH] D69498: IR: Invert convergent attribute handling

rjmccall added a comment. This certainly seems like a more tractable representation, although I suppose it'd be a thorn in the side of (IR-level) outlining. A note on spelling: the `no` prefix seems to be used largely with verbs; it's weird to use it here with an adjective, especially since `no

[PATCH] D69506: [clangd] Add missing highlights for using decls.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:51 } + if (auto *UD = dyn_cast(D)) { +if (UD->shadow_size() == 0) ilya-biryukov wrote: > Could we reuse `kindForCandidateDecls` instead? > It's best to keep one wa

[PATCH] D68028: [clang] Add no_builtin attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the patch, and welcome! LGTM aside from a minor nit. Do you need someone to commit this on your behalf? Comment at: clang-tidy/modernize/UseNodis

[PATCH] D69517: [clangd] Add a hidden tweak to dump symbol under the curosr.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This provides a convenient way to see the SymbolID/USR of the symbol, mainly for debugging purpose. Repository: rG LLV

[PATCH] D69498: IR: Invert convergent attribute handling

rjmccall added a comment. In D69498#1723553 , @rjmccall wrote: > This certainly seems like a more tractable representation, although I suppose > it'd be a thorn in the side of (IR-level) outlining. Sorry, I mis-clicked and sent this review while I was s

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

aaron.ballman added a comment. In D69145#1720254 , @poelmanc wrote: > What do @malcolm.parsons, @alexfh, @hokein, @aaron.ballman, @lebedev.ri think > of @mgehre's suggestion to enable `IgnoreBaseInCopyConstructors` as the > default setting, so gcc users

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet added a comment. In D68028#1723568 , @aaron.ballman wrote: > LGTM! Thx a lot for bearing with me and for your valuable comments ! Really appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D69506: [clangd] Add missing highlights for using decls.

merge_guards_bot added a comment. Build result: pass - 59702 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69506: [clangd] Add missing highlights for using decls.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. See the NITs, though Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:51 } + if (auto *USD = dyn_cast(D)) +return kindForDecl(USD->ge

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

aaron.ballman added a comment. In D69292#1722162 , @thakis wrote: > This is imho basic enough that it doesn't need a test. A test for this > doesn't add any value that I can see. The value comes from having an explicit test to demonstrate the behavior i

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

sedykh.eugene updated this revision to Diff 226677. sedykh.eugene added a comment. I removed using. Not a big deal. Thank you for the reviews! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69388/new/ https://reviews.llvm.org/D69388 Files: clang-t

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 📋

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69414/new/ https://reviews.llvm.org/D69414

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

sedykh.eugene added a comment. In D69388#1723589 , @aaron.ballman wrote: > Thank you for the patch, and welcome! LGTM aside from a minor nit. Do you > need someone to commit this on your behalf? Thank you. You mean I don't rights? Then, yes, I need som

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

aaron.ballman added a comment. Do you need someone to commit this on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 ___ cfe-commits mailing list c

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

aaron.ballman added a comment. Does this analysis require CFG support or have a high false positive rate? We typically keep those out of `-Wall` because of performance concerns, so I am wondering if the diagnostic was kept out of `-Wall` for a reason. CHANGES SINCE LAST ACTION https://review

[PATCH] D69517: [clangd] Add a hidden tweak to dump symbol under the curosr.

merge_guards_bot added a comment. Build result: fail - 59659 tests passed, 2 failed and 805 were skipped. failed: libc++.libcxx/thread/thread_threads/thread_thread_this/sleep_for.pass.cpp failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

thakis added a comment. > While the default metaclass does in fact implement the one method NSCopying > declares, it's not possible within the language to declare that the Class -- > itself, as an instance -- implements the instance methods from the NSCopying > protocol. Should the compiler ju

[clang] bd87916 - [clang] Add no_builtin attribute

Author: Guillaume Chatelet Date: 2019-10-28T17:30:11+01:00 New Revision: bd87916109483d33455cbf20da2309197b983cdd URL: https://github.com/llvm/llvm-project/commit/bd87916109483d33455cbf20da2309197b983cdd DIFF: https://github.com/llvm/llvm-project/commit/bd87916109483d33455cbf20da2309197b983cdd.

[PATCH] D68028: [clang] Add no_builtin attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd8791610948: [clang] Add no_builtin attribute (authored by gchatelet). Changed prior to commit: https://reviews.llvm.org/D68028?vs=225618&id=226687#toc Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

rjmccall added a comment. We could probably do a quick check to see if the class informally conforms to the protocol. `+copyWithZone` seems to be marked unavailable in ARC; not sure if that would cause problems for such a check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 93a3128 - Remove extra ';'. NFCI.

Author: Simon Pilgrim Date: 2019-10-28T16:32:02Z New Revision: 93a3128a67cc4372696eb3199bed23d7bac4a183 URL: https://github.com/llvm/llvm-project/commit/93a3128a67cc4372696eb3199bed23d7bac4a183 DIFF: https://github.com/llvm/llvm-project/commit/93a3128a67cc4372696eb3199bed23d7bac4a183.diff LOG:

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor testing nit. Comment at: clang/test/CodeGen/memccpy-libcall.c:13 +// CHECK: attributes #2 = { nobuiltin } \ No newline at end of file -

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

aaron.ballman added a comment. I sort of feel like we don't want to go this route because we want to avoid calling `runWithSufficientStackSpace` whenever possible, but I am not strongly opposed to this patch. It should be combined with the usage of the new functionality, however, so that it get

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 requested changes to this revision. xbolva00 added a comment. This revision now requires changes to proceed. >> Does this analysis require CFG support https://reviews.llvm.org/D69292 also requires CFG support. Generally, is CFG support ok for -Wall if the warning has few false positives

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

xbolva00 added a comment. Just use // RUN: %clang_cc1 -fsyntax-only -verify -Wall %s // RUN: %clang_cc1 -fsyntax-only -verify -Wtautological-bitwise-compare %s in clang/test/SemaCXX/warn-bitwise-compare.cpp ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.l

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

aaron.ballman added a comment. In D68912#1723691 , @xbolva00 wrote: > >> Does this analysis require CFG support > > https://reviews.llvm.org/D69292 also requires CFG support. Yes, it does. > Generally, is CFG support ok for -Wall if the warning has few

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

aaron.ballman added a comment. In D69292#1723720 , @xbolva00 wrote: > Just use > > // RUN: %clang_cc1 -fsyntax-only -verify -Wall %s > // RUN: %clang_cc1 -fsyntax-only -verify -Wtautological-bitwise-compare %s > > > in > > clang/test/SemaCXX/warn-bitwi

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 added a comment. In D68539#1723629 , @aaron.ballman wrote: > Do you need someone to commit this on your behalf? Yes I would like to. Thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68

[PATCH] D68733: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

liaoyuke added a comment. In D68733#1702609 , @vsk wrote: > Thanks, lgtm! > > In PR43614 I mentioned adding an extra argument to llvm-cov to specify the > base directory. On second thought, the existing `-path-equivalence` option > should make that unnec

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

Eugene.Zelenko added a comment. Please take a look on PR43827. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://reviews.llvm.org/D67567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc updated this revision to Diff 226695. poelmanc added a comment. Remove extra `const`, braces for one-line `if` statements, and `clang::`. Added a comment explaining the need for a regex on a warning test line. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://re

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc marked 5 inline comments as done. poelmanc added a comment. Thanks for the feedback, the new patch removes the extra `const`, `clang::`, and braces on one-line `if` statements, and now explains the regex in readability-redundant-string-init.cpp. Comment at: clang-to

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

tra added a comment. In D60220#1723458 , @emankov wrote: > In D60220#1723350 , @6yearold wrote: > > > I'm seeing quite similar errors on FreeBSD with Clang 8 and 9: > > Any idea how to fix this? > > > It looks like

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69518 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaExprCXX.cpp

[clang] 7c86069 - [OPENMP]Fix PR43771: Do not capture contexprs variables.

Author: Alexey Bataev Date: 2019-10-28T13:29:02-04:00 New Revision: 7c860698208aee32df1883601b94924fa4a3d531 URL: https://github.com/llvm/llvm-project/commit/7c860698208aee32df1883601b94924fa4a3d531 DIFF: https://github.com/llvm/llvm-project/commit/7c860698208aee32df1883601b94924fa4a3d531.diff

[PATCH] D69493: Add -fconvergent-functions flag

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. > The CUDA builtin library is apparently compiled in C++ mode, so the > assumption of convergent needs to be made in a typically non-SPMD > language. I think the key here is that we sometime

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm marked an inline comment as done. arsenm added a comment. In D69498#1723606 , @rjmccall wrote: > A note on spelling: the no prefix seems to be used largely with verbs; it's > weird to use it here with an adjective, especially since noncovergent is

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:3679 + CallExpr *Call = dyn_cast(CondExpr->IgnoreParens()); + if (IsConstexpr && Call && Call->isCallToStdIsConstantEvaluated()) +Diag(Call->getBeginLoc(),

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

emankov added a comment. >> It looks like CUDA doesn't support `double` argument for device function >> __isnan on FreeBSD. > > It's actually the opposite -- FreeBSD does not provide *host*-side > `__isnan(double)` -- the error complains that it's the host code that tried > to use `__isnan` an

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie created this revision. jdoerrie added reviewers: mclow.lists, ldionne. Herald added a reviewer: EricWF. Herald added subscribers: libcxx-commits, dexonsmith, christof. [libc++] Disallow dynamic -> static span conversions This change disallows dynamic to static span conversions. This comp

  1   2   >