hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/FindTarget.cpp:454 + if (ND->getDeclName().isIdentifier() && + !ND->getDeclName().getAsIdentifierInfo()) + return; ---------------- nit: I think `if (!ND->getDeclName().getAsIdentifierInfo())` is enough, getAsIdentifierInfo returns null if the name is not an identifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69511/new/ https://reviews.llvm.org/D69511 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
