aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
Thank you for the patch, and welcome! LGTM aside from a minor nit. Do you need someone to commit this on your behalf? ================ Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:97 + using clang::attr::WarnUnusedResult; + ---------------- I'd just sink this down into the matcher itself rather than use a `using` declaration for it. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69388/new/ https://reviews.llvm.org/D69388 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
