[PATCH] D68683: ARM] Fix arm_neon.h with -flax-vector-conversions=none

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Nice one, thanks for fixing! I didn't have the bandwidth to look into this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68683/new/ https://review

[PATCH] D68682: Clang-tidy fixes should avoid creating new blank lines

MyDeveloperDay added a comment. Sorry, I'm going to give a drive-by comment (which you can ignore), mainly by because you mentioned `clang-format`. This seems like a good idea as obviously it solves this problem, however, isn't rather like trying to fix it after the fact? what if (I'm sure the

[PATCH] D68682: Clang-tidy fixes should avoid creating new blank lines

gribozavr added a reviewer: gribozavr. gribozavr requested changes to this revision. gribozavr added a comment. This revision now requires changes to proceed. +1 to what MyDeveloperDay said. The infrastructure can't know whether the newlines are intentional or not. Checks that edit the source cod

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

ilya-biryukov added a comment. In D67536#1700872 , @nridge wrote: > > It also lets them consistently highlight part of the line (e.g. dead > > expressions or statements can be marked in gray even if they are on the > > same line). > > Highlighting part o

Re: r374006 - Reland 'Add VFS support for sanitizers' blacklist'

Hi Jan, This patch seems to assume VFS will only re-map some paths, but still point into the physical filesystem. This may not be the case, e.g. in unit tests. This also manages to break some of our internal clang-tidy integrations for obscure reasons. Can we instead just pass VFS instance to th

r374148 - Unify the two CRC implementations

Author: hans Date: Wed Oct 9 02:06:30 2019 New Revision: 374148 URL: http://llvm.org/viewvc/llvm-project?rev=374148&view=rev Log: Unify the two CRC implementations David added the JamCRC implementation in r246590. More recently, Eugene added a CRC-32 implementation in r357901, which falls back t

[PATCH] D68570: Unify the two CRC implementations

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e1e3ba2526e: Unify the two CRC implementations (authored by hansw). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

r374151 - Revert r374006: Reland 'Add VFS support for sanitizers' blacklist'

Author: ibiryukov Date: Wed Oct 9 02:40:22 2019 New Revision: 374151 URL: http://llvm.org/viewvc/llvm-project?rev=374151&view=rev Log: Revert r374006: Reland 'Add VFS support for sanitizers' blacklist' Also revert follow-up changes to the test. Reason: the patch breaks our internal clang-tidy in

Re: r374006 - Reland 'Add VFS support for sanitizers' blacklist'

Reverted in r374151. On Wed, Oct 9, 2019 at 11:03 AM Ilya Biryukov wrote: > Hi Jan, > > This patch seems to assume VFS will only re-map some paths, but still > point into the physical filesystem. > This may not be the case, e.g. in unit tests. > > This also manages to break some of our internal

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

ilya-biryukov added a comment. In D64799#1688293 , @dgoldman wrote: > In D64799#1605514 , @ilya-biryukov > wrote: > > > Tried the suggested approach and ran into the issue described above. > > Either we make the d

r374152 - [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

Author: ibiryukov Date: Wed Oct 9 03:00:05 2019 New Revision: 374152 URL: http://llvm.org/viewvc/llvm-project?rev=374152&view=rev Log: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU Summary: Instead of asserting all typos are corrected in the sema destructor. The sema de

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/Sema.cpp:916 + // cases in practice. + for (const auto &Typo : DelayedTypos) { +// We pass an empty TypoCorrection to indicate no correction was performed. sammccall wrote: > If you like, `DEBU

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

This revision was automatically updated to reflect the committed changes. Closed by commit rGaeae71cd96c3: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU (authored by ilya-biryukov). Changed prior to commit: https://reviews.llvm.org/D64799?vs=210338&id=224005#toc Reposi

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:87 +return false; + if (const Decl *ParentDecl = Node->Parent->ASTNode.get()) +return llvm::isa(ParentDecl); Can we use `ASTNode.get()` to

[PATCH] D67004: [DebugInfo] Enable call site parameter debug info for ARM and AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rGf71bac6f4351: [DebugInfo] Enable call site debug info for ARM and AArch64 (authored by NikolaPrica). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

ilya-biryukov added a comment. Just noticed the next version of LSP added diagnostic tags for things like "unused field" or "dead code": https://microsoft.github.io/language-server-protocol/specifications/specification-3-15, search for `DiagnosticTag`. So I guess we won't need ever add range-ba

r374154 - [mips] Set default float ABI to "soft" on FreeBSD

Author: atanasyan Date: Wed Oct 9 03:38:03 2019 New Revision: 374154 URL: http://llvm.org/viewvc/llvm-project?rev=374154&view=rev Log: [mips] Set default float ABI to "soft" on FreeBSD Initial patch by Kyle Evans. Fix PR43596 Modified: cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp cfe/

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4657 + Builder.GetInsertBlock()->getParent(), PtrTy->getPointerAddressSpace()); + // Check for overflows unless the GEP got constant-folded, + // and only in the default address space

[PATCH] D68694: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun created this revision. vladimir.plyashkun added a reviewer: JonasToth. vladimir.plyashkun added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. Hi! Clang-Tidy has been integrated in CLion some time ago, but a lot of use

[PATCH] D68634: [ASTImporter] Imported FunctionDecls inherit attributes from existing functions

martong marked an inline comment as done. martong added a comment. In D68634#1700591 , @a_sidorin wrote: > Hello Balasz, > In my opinion, importing and setting the attributes should be handled by the > stuff used in InitializeImportedDecl(). Can we exten

[PATCH] D68634: [ASTImporter] Imported FunctionDecls inherit attributes from existing functions

martong added a comment. In D68634#1701192 , @martong wrote: > In D68634#1700591 , @a_sidorin wrote: > > > Hello Balasz, > > In my opinion, importing and setting the attributes should be handled by > > the stuff u

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir added reviewers: AndWass, MyDeveloperDay. r373165 fixed an issue where a templated noexcept member function with a reference qualifier would be indented more than expected: // Formatt

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: unittests/Format/FormatTest.cpp:7093 " template \n" - " int& foo(const std::string& str) const & noexcept {}\n" + " int& foo(const std::string& st

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

MyDeveloperDay added a comment. Only because I had problem finding the commit, this is as a consequence of D68072: [clang-format] Reference qualifiers in member templates causing extra indentation. Repository: rC Clang CHANGES SINCE LAST ACTION https://re

[clang-tools-extra] r374163 - [clangd] Propagate context into reply handlers

Author: kadircet Date: Wed Oct 9 05:48:41 2019 New Revision: 374163 URL: http://llvm.org/viewvc/llvm-project?rev=374163&view=rev Log: [clangd] Propagate context into reply handlers Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.h Modified: clang-tools-extra/trunk/clangd/ClangdLSPS

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for fixing this, I'm sorry my review probably wasn't thorough enough in the first place, this LGTM and thank you for the very thorough description as this really help

Re: [clang-tools-extra] r374163 - [clangd] Propagate context into reply handlers

Looks like this breaks three clangd tests on macOS: Failing Tests (3): Clangd :: code-action-request.test Clangd :: execute-command.test Clangd :: tweaks-format.test libc++abi.dylib: terminating with uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argumen

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

krasimir marked 3 inline comments as done. krasimir added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1499 +} else if (Current.isOneOf(tok::identifier, tok::kw_const, + tok::kw_noexcept) && Current.Previous && -

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham updated this revision to Diff 224031. simon_tatham added a comment. Rebased to current master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160 Files: clang/lib/Driver/ToolChains/Clang.cpp c

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

simon_tatham updated this revision to Diff 224030. simon_tatham added a comment. Rebased to current master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67159/new/ https://reviews.llvm.org/D67159 Files: clang/include/clang/Basic/Attr.td clang

[PATCH] D68701: Adds a isDefinitionKind to FunctionDecl

gchatelet created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tentatively fixing the bug described in https://reviews.llvm.org/D68028#inline-614831. This is not a good solution though since `isThisDeclarationADefinition` still doesn't work as expected.

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1098-1099 + + if (D->hasAttr()) +D->dropAttr(); + gchatelet wrote: > aaron.ballman wrote: > > gchatelet wrote: > > > gchatelet wrote: > >

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:219 + bool VisitDependentNameTypeLoc(DependentNameTypeLoc L) { +addToken(L.getNameLoc(), HighlightingKind::DependentType); +return true; nridge wrote: > ilya-biry

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

kristof.beyls added a comment. Would it still make sense to have this patch after D68683 lands? At first sight, it seems this patch might no longer make sense then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

MyDeveloperDay added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1499 +} else if (Current.isOneOf(tok::identifier, tok::kw_const, + tok::kw_noexcept) && Current.Previous && krasimir wrote: > MyDevel

Re: [clang-tools-extra] r374163 - [clangd] Propagate context into reply handlers

thanks! sent out D68702. On Wed, Oct 9, 2019 at 2:56 PM Nico Weber wrote: > Looks like this breaks three clangd tests on macOS: > > Failing Tests (3): > Clangd :: code-action-request.test > Clangd :: execute-command.test > Clangd :: tweaks-format.test > > libc++abi.dylib: terminating

[PATCH] D68702: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. After rL374163 , replycallbacks might have a cancellable context, w

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:87 +return false; + if (const Decl *ParentDecl = Node->Parent->ASTNode.get()) +return llvm::isa(ParentDecl); ilya-biryukov wrote: > Can we use

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 224038. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Make action unavailable if the namespace contains a using namespace decl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { -

[PATCH] D68702: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:429 + // for cases where LSP clients don't reply for the request. + static constexpr int MaxReplayCallbacks = 100; + mutable std::mutex CallMutex; Please document tha

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

dmgreen added a comment. Yes.. My understanding is that the default is still -flax-vector-convertions=all (the old clang behaviour), but the plan is to change it (for all architectures) to none. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/

[PATCH] D68702: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex

thakis added a comment. Maybe inline the error from the bot. Right now stuff on 45.33.8.238 is very in flux. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68702/new/ https://reviews.llvm.org/D68702 __

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

Quuxplusone added inline comments. Comment at: test/std/containers/unord/unord.map/unord.map.cnstr/deduct.pass.cpp:70 +#pragma warning(disable: 4244) // '%s': conversion from '%s' to '%s', possible loss of data +#endif // TEST_COMPILER_C1XX + Alternatively, if

r374167 - [clang-offload-bundler] Support `.cui` and `.d`.

Author: hliao Date: Wed Oct 9 06:53:37 2019 New Revision: 374167 URL: http://llvm.org/viewvc/llvm-project?rev=374167&view=rev Log: [clang-offload-bundler] Support `.cui` and `.d`. Reviewers: tra, yaxunl Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D686

[PATCH] D68663: [clang-offload-bundler] Support `.cui` and `.d`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ae54aba03f2: [clang-offload-bundler] Support `.cui` and `.d`. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D68663?vs=223932&id=224044#toc Repository: rG LLVM Github Monorep

Re: r374006 - Reland 'Add VFS support for sanitizers' blacklist'

FWIW reverting a patch for it breaking some internal system seems like poor form to me. It's really hard to reland in that case. Please make a reduced repro next time. On Wed, Oct 9, 2019 at 5:38 AM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Reverted in r374151. > > On W

[clang-tools-extra] r374168 - [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex

Author: kadircet Date: Wed Oct 9 06:59:31 2019 New Revision: 374168 URL: http://llvm.org/viewvc/llvm-project?rev=374168&view=rev Log: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex Summary: After rL374163, replycallbacks might have a cancellable context, which will

[PATCH] D68702: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a3a87d18975: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk added a comment. @arphaman I don't mind changing this if there are race conditions as you say, but isn't the assumption of the tool that the filesystem remains unchanged for a single run of the tool? If so, should we actually throw error conditions instead of crashing in those cases?

[PATCH] D68702: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex

kadircet updated this revision to Diff 224045. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68702/new/ https://reviews.llvm.org/D68702 Files: clang-tools-ex

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. The direction is good and I believe all the feedback from D64943 has already been incorporated. LGTM, thanks. CHANGES SINCE LAST ACTION h

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

ilya-biryukov added a comment. Many thanks, this LG overall, just a few NITs and documentation requests. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:31 +/// std::vector foo(std::map); +class RemoveUsingNamespace : public Tweak { +public:

Re: r374006 - Reland 'Add VFS support for sanitizers' blacklist'

Fair enough, sorry about that. Nevertheless, I wanted to re-raise concerns about the approach taken in the patch. It seems to assume invariants about VFS that don't necessarily hold for filesystems outside those tested in upstream LLVM. PTAL at the original patch - calling `getRealPath` on the FS

-isysem path

Hello, I have created one visual studio application by using LibTooling library. I am dumping the AST and all LLVM Types. I want to pass the isystem path to the clangTool object. I have declared the isystem path in the Command Arguments (Project->Properties->Debugging->Command Arguments) input.c

r374153 - [DebugInfo] Enable call site debug info for ARM and AArch64

Author: nikolaprica Date: Wed Oct 9 03:14:15 2019 New Revision: 374153 URL: http://llvm.org/viewvc/llvm-project?rev=374153&view=rev Log: [DebugInfo] Enable call site debug info for ARM and AArch64 ARM and AArch64 SelectionDAG support for tacking parameter forwarding register is implemented so we

r374172 - [clang-format] Update noexcept reference qualifiers detection

Author: krasimir Date: Wed Oct 9 07:46:08 2019 New Revision: 374172 URL: http://llvm.org/viewvc/llvm-project?rev=374172&view=rev Log: [clang-format] Update noexcept reference qualifiers detection Summary: r373165 fixed an issue where a templated noexcept member function with a reference qualifie

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

This revision was automatically updated to reflect the committed changes. krasimir marked an inline comment as done. Closed by commit rGae1b7859cbd6: [clang-format] Update noexcept reference qualifiers detection (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D68695?vs

r374174 - [NFC] Test commit.

Author: mitchell Date: Wed Oct 9 08:11:34 2019 New Revision: 374174 URL: http://llvm.org/viewvc/llvm-project?rev=374174&view=rev Log: [NFC] Test commit. Testing llvm commit access only. Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst

r374175 - [NFC] Reverting changes from test commit.

Author: mitchell Date: Wed Oct 9 08:12:22 2019 New Revision: 374175 URL: http://llvm.org/viewvc/llvm-project?rev=374175&view=rev Log: [NFC] Reverting changes from test commit. llvm commit access test succeeded. Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst Modified: cfe/trunk/docs/Cl

[PATCH] D68590: [clangd] Improve hover support for Objective-C

sammccall added a comment. Thanks! This generally looks good, just need to find the right home for some of the logic. Comment at: clangd/XRefs.cpp:455 +static std::string getNameForObjCMethod(const ObjCMethodDecl *Method) { + std::string Name; XRefs.cpp isn

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. In D67536#1701038 , @ilya-biryukov wrote: > In D67536#1700872 , @nridge wrote: > > > > It also lets them consistently highlight part of the line (e.g. dead > > > expressions or statements c

[PATCH] D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, STL_MSFT, klimek, krasimir. MyDeveloperDay added projects: clang-format, clang-tools-extra. Herald added a project: clang. MyDeveloperDay edited the summary of this revision. An incorrect assertion is thrown wh

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham added a comment. Yes, the commit message in rL371817 mentions that the long-term aim is to change the default to `none` for everyone. If that change happens before I manage to land this patch, then this patch certainly will become unnecessary. B

[PATCH] D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

mitchell-stellar added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:847 case tok::kw_while: - assert(!Line.startsWith(tok::hash)); - if (Tok->is(tok::kw_if) && CurrentToken && - CurrentToken->isOneOf(tok::kw_constexpr, tok::identifier))

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 224067. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Added documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/ https://reviews.llvm.org/D68562 Files: clang-too

[PATCH] D68710: Remove time-trace message as it inconsistent style

russell.gallop created this revision. russell.gallop added reviewers: anton-afanasyev, sylvestre.ledru. Herald added a project: clang. https://reviews.llvm.org/D68260 removed some of the message that -ftime-trace prints out. Running large builds still prints out a lot of "Time trace json-file du

[PATCH] D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

MyDeveloperDay updated this revision to Diff 224075. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. I'm not even sure if the assertion is valid? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68707/new/ https://reviews.llvm.org/D68707 Files: clang/lib

[PATCH] D68710: Remove time-trace message as it is inconsistent style

sylvestre.ledru added inline comments. Comment at: clang/include/clang/Driver/Options.td:1797 + HelpText<"Turn on time profiler. Generates JSON file based on output filename. " + "Results can be analyzed with chrome://tracing or `Speedscope App " + "

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 224082. gchatelet added a comment. - Address aaron ballman comments - Checks function name validity and errors when passed 0 argument. - Update documentation and rebase - Rewrote mergeNoBuiltinAttr - Address comments Repository: rG LLVM Github Monorepo

[PATCH] D68710: Remove time-trace message as it is inconsistent style

sylvestre.ledru added a comment. besides that, I think we should do it; thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68710/new/ https://reviews.llvm.org/D68710 ___ cfe-commits mailing list c

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 224085. gchatelet added a comment. - Remove leftovers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/clang/Basic/Attr.td clang/include/clang

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

dkrupp updated this revision to Diff 224088. dkrupp marked 9 inline comments as done. dkrupp added a comment. @Szelethus thanks for your review. I fixed your suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66049/new/ https://reviews.llvm.org/D66049 Files: clang/lib/StaticA

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

dkrupp added a comment. I also analyzed openssl with the baseline and this version, but did not find any new warnings. See: http://codechecker-demo.eastus.cloudapp.azure.com/Default/#run=D66049_baseline&newcheck=D66049_improved&review-status=Unreviewed&review-status=Confirmed&detection-status=New

[PATCH] D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

mitchell-stellar added a comment. To me, whether or not the assertion was valid is irrelevant. That assertion was intentionally added, and its replacement with an `if()` statement materially changes the inputs and outputs of the function. I'm questioning whether the input of a "while" token wit

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

dkrupp updated this revision to Diff 224090. dkrupp added a comment. Fixing minor capitalization issue and removing an extra newline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66049/new/ https://reviews.llvm.org/D66049 Files: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

hliao created this revision. hliao added reviewers: rsmith, eli.friedman. Herald added a project: clang. Herald added a subscriber: cfe-commits. - [Itanium C++ ABI][1], for certain contexts like default parameter and etc., mangling numbering will be local to the particular argument in which it ap

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

aaronpuchert added a comment. Herald added a project: LLVM. This change breaks the following code that worked before: task f(MoveOnly &value) { co_return value; } The error message is: clang/test/SemaCXX/coroutine-rvo.cpp:60:13: error: call to deleted constructor of 'MoveOnly' co

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

CaseyCarter added inline comments. Comment at: test/std/containers/unord/unord.map/unord.map.cnstr/deduct.pass.cpp:70 +#pragma warning(disable: 4244) // '%s': conversion from '%s' to '%s', possible loss of data +#endif // TEST_COMPILER_C1XX + Quuxplusone wrote:

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

CaseyCarter updated this revision to Diff 224092. CaseyCarter edited the summary of this revision. CaseyCarter added a comment. Avoid rather than suppress truncation warnings in `unordered_meow` deduction guide tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68681/new/ https://rev

[PATCH] D68683: ARM] Fix arm_neon.h with -flax-vector-conversions=none

rsmith accepted this revision. rsmith added a comment. Thank you! We also have a hack in the ARM and AArch64 target info to set the default for lax vector conversions back to "all" when NEON is enabled that can now be removed. Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D68694: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. > In my opinion this check should be disabled in case of integer literals, > since there are a lot of existing code (even in system libraries) where user > can do nothing, e.g.: I think that this check should behave h

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

Quuxplusone added inline comments. Comment at: test/std/containers/unord/unord.map/unord.map.cnstr/deduct.pass.cpp:70 +#pragma warning(disable: 4244) // '%s': conversion from '%s' to '%s', possible loss of data +#endif // TEST_COMPILER_C1XX + CaseyCarter wrote:

[PATCH] D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:847 case tok::kw_while: - assert(!Line.startsWith(tok::hash)); - if (Tok->is(tok::kw_if) && CurrentToken && - CurrentToken->isOneOf(tok::kw_constexpr, tok::identifier)) -

[PATCH] D68581: Include leading attributes in DeclStmt's SourceRange

aaron.ballman added a comment. I think this seems like reasonable behavior (for instance, we include the location of a storage class specifier already), but I am curious if @rsmith agrees. > Is there a good way to write a test for this? Yes, you can put an AST dumping test into the test\AST di

r374189 - [WebAssembly] Add builtin and intrinsic for v8x16.swizzle

Author: tlively Date: Wed Oct 9 10:45:47 2019 New Revision: 374189 URL: http://llvm.org/viewvc/llvm-project?rev=374189&view=rev Log: [WebAssembly] Add builtin and intrinsic for v8x16.swizzle Summary: This clang builtin and corresponding LLVM intrinsic are necessary to expose the exact semantics

[PATCH] D68531: [WebAssembly] Add builtin and intrinsic for v8x16.swizzle

This revision was automatically updated to reflect the committed changes. Closed by commit rG3419e90dc1a2: [WebAssembly] Add builtin and intrinsic for v8x16.swizzle (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68531/new/ http

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55125/new/ https://reviews.llvm.org/D55125 ___ cfe-commits mailing lis

[PATCH] D68665: [HIP] Fix -save-temps

yaxunl marked 8 inline comments as done. yaxunl added inline comments. Comment at: lib/Driver/Driver.cpp:4400 + // HIP image for device compilation with -fno-gpu-rdc is per compilation + // unit. + bool IsHIPNoRDC = JA.getOffloadingDeviceKind() == Action::OFK_HIP &

[PATCH] D68581: Include leading attributes in DeclStmt's SourceRange

rsmith added a comment. In D68581#1701787 , @aaron.ballman wrote: > I think this seems like reasonable behavior (for instance, we include the > location of a storage class specifier already), but I am curious if @rsmith > agrees. Yes, I do agree. Thou

[PATCH] D68716: [clang] prevent crash for nonnull attribut in constant context (Bug 43601)

Tyker created this revision. Tyker added a reviewer: rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. bug : https://bugs.llvm.org/show_bug.cgi?id=43601 Repository: rC Clang https://reviews.llvm.org/D68716 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX

[PATCH] D68665: [HIP] Fix -save-temps

ashi1 accepted this revision. ashi1 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68665/new/ https://reviews.llvm.org/D68665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Okay. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68707/new/ https://reviews.llvm.org/D68707 ___ cfe-commit

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

tamur added a comment. It seems that with this patch, llvm-ifs starts to depend on yaml2obj, which as far as I know, was only used for testing purposes until now. Is this intended? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/

[PATCH] D68551: [clang-format] [NFC] Ensure clang-format is itself clang-formatted.

Meinersbur added a comment. In D68551#1697842 , @mitchell-stellar wrote: > I agree that a system in place that either enforces clang-formatting on > commit or after the fact would be ideal. Otherwise, I don't see a need to > have to approve these NFC co

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

efriedma added a comment. The refactoring of the getCurrentMangleNumberContext API mixed with functional changes makes this much harder to review quickly. Please separate it out. Comment at: clang/lib/Sema/SemaLambda.cpp:353 + Mangling

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, dschuff. Herald added projects: clang, LLVM. Implement protection against the stack clash attack [0]. Probe stack allocation every PAGE_SIZE during frame lowering or dynamic allocation to mak

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked 3 inline comments as done. plotfi added a comment. In D63978#1701864 , @tamur wrote: > It seems that with this patch, llvm-ifs starts to depend on yaml2obj, which > as far as I know, was only used for testing purposes until now. Is this > i

r374198 - [HIP] Fix -save-temps

Author: yaxunl Date: Wed Oct 9 11:46:43 2019 New Revision: 374198 URL: http://llvm.org/viewvc/llvm-project?rev=374198&view=rev Log: [HIP] Fix -save-temps Currently clang does not save some of the intermediate file generated during device compilation for HIP when -save-temps is specified. This

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

hliao updated this revision to Diff 224115. hliao added a comment. remove refactoring code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68715/new/ https://reviews.llvm.org/D68715 Files: clang/include/clang/AST/ASTContext.h clang/include/clang

  1   2   3   >