ilya-biryukov added inline comments.
================
Comment at: clang/lib/Sema/Sema.cpp:916
+ // cases in practice.
+ for (const auto &Typo : DelayedTypos) {
+ // We pass an empty TypoCorrection to indicate no correction was performed.
----------------
sammccall wrote:
> If you like, `DEBUG_WITH_TYPE("DelayedTypos", ...)` would still let people
> who want to fix these see them. In practice, I suspect nobody actually wants
> to fix these, though :-(
I've left it out for now, not sure what's the best way to report those: crash?
show a message in stderr? (probably a short message, indicating the number of
uncorrected delayed typos in stderr is enough)
Also second the concerns that it's not very useful since no-one is actually
looking at these.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64799/new/
https://reviews.llvm.org/D64799
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
