lebedev.ri added inline comments.
================ Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4657 + Builder.GetInsertBlock()->getParent(), PtrTy->getPointerAddressSpace()); + // Check for overflows unless the GEP got constant-folded, + // and only in the default address space ---------------- rsmith wrote: > If we want to split out the "constant folded" case to avoid issuing too many > sanitizer traps on bogus but common patterns, we should have another > sanitizer group to re-enable those diagnostics for the constant-folded cases. > (I'm fine with not doing that in this patch, though.) I'm not sure about this point, i think i'm gonna leave this as-is for now.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67122/new/ https://reviews.llvm.org/D67122 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
