thanks! sent out D68702. On Wed, Oct 9, 2019 at 2:56 PM Nico Weber <tha...@chromium.org> wrote:
> Looks like this breaks three clangd tests on macOS: > > Failing Tests (3): > Clangd :: code-action-request.test > Clangd :: execute-command.test > Clangd :: tweaks-format.test > > libc++abi.dylib: terminating with uncaught exception of type > std::__1::system_error: mutex lock failed: Invalid argument > > http://45.33.8.238/mac/1245/step_7.txt > > On Wed, Oct 9, 2019 at 8:46 AM Kadir Cetinkaya via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: kadircet >> Date: Wed Oct 9 05:48:41 2019 >> New Revision: 374163 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=374163&view=rev >> Log: >> [clangd] Propagate context into reply handlers >> >> Modified: >> clang-tools-extra/trunk/clangd/ClangdLSPServer.h >> >> Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.h >> URL: >> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/ClangdLSPServer.h?rev=374163&r1=374162&r2=374163&view=diff >> >> ============================================================================== >> --- clang-tools-extra/trunk/clangd/ClangdLSPServer.h (original) >> +++ clang-tools-extra/trunk/clangd/ClangdLSPServer.h Wed Oct 9 05:48:41 >> 2019 >> @@ -157,7 +157,7 @@ private: >> void call(StringRef Method, llvm::json::Value Params, >> Callback<Response> CB) { >> // Wrap the callback with LSP conversion and error-handling. >> auto HandleReply = >> - [CB = std::move(CB)]( >> + [CB = std::move(CB), Ctx = Context::current().clone()]( >> llvm::Expected<llvm::json::Value> RawResponse) mutable { >> Response Rsp; >> if (!RawResponse) { >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
