[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added a comment. In D68377#1693490 , @xbolva00 wrote: > It is not very obvious for me what kind of test should be done here. I > would be grateful if you could show me an example in tree. I was thinking of something in CodeGen, like Code

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay added a comment. understood, ok LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. Thanks. Please commit on my behalf when you have a chance. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 ___ cfe-commits mailing list cfe-c

[PATCH] D68255: [X86] Remove AVX/AVX512 check from validateOperandSize, just always accept 512

rnk added subscribers: ahatanak, void. rnk added a comment. I notice that x86 is the only target for which validateInput/OutputSize are implemented. If you are going to disable these checks, perhaps we should get rid of these methods and leave all these errors to the backend? You could add `-S`

[PATCH] D68410: [AttrDocs] document always_inline

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4401 +disabled. Does not guarantee that inline substitution actually occurs. +}]; + let Heading = "always_inline"; It is more than that. This would imply that with optimizations e

r373661 - [OPENMP50]Codegen support for scores in context selectors.

Author: abataev Date: Thu Oct 3 13:49:48 2019 New Revision: 373661 URL: http://llvm.org/viewvc/llvm-project?rev=373661&view=rev Log: [OPENMP50]Codegen support for scores in context selectors. If the context selector has associated score and several contexts selectors matches current context, the

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 marked 7 inline comments as done. boga95 added a comment. Ping Comment at: clang/test/Analysis/taint-generic.c:393-397 +void testConfigurationFilter3() { + int x = mySource1(); + myFilter3(&x); + Buffer[x] = 1; // no-warning +} NoQ wrote: > In this ex

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers updated this revision to Diff 223088. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - add links - remove extra whitespace - rewording, split onto separate lines to ease code review - add spellings to heading Repository: rG LLVM Github Monore

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223090. mibintc added a comment. In the previous review, @rjmccall asked me to redo the existing floating point option documentation before submitting this patch. I got the floating point documentation update committed, and I've worked on this patch more to

[PATCH] D68423: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools

mgorny created this revision. mgorny added reviewers: compnerd, beanz, phosek, tstellar, smeenai, jtsoftware, hokein. Replace add_clang_executable() calls with add_clang_tool() that takes care of creating correct, distribution-friendly install target. While at it, remove redundant install calls.

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:219 + bool VisitDependentNameTypeLoc(DependentNameTypeLoc L) { +addToken(L.getNameLoc(), HighlightingKind::DependentType); +return true; -

Re: r373406 - Use scope qualifiers in Clang's tblgen backends to get useful

(mostly joking) any interest in seeing what it'd take to make Clang/LLVM -Wmissing-prototype clean? (which would also catch the same sort of issues, I think?) On Tue, Oct 1, 2019 at 4:10 PM John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rjmccall > Date: Tue Oct 1 16:1

r373665 - OverloadCandidate::getNumParams - silence static analyzer getAs null dereference warning. NFCI.

Author: rksimon Date: Thu Oct 3 14:27:02 2019 New Revision: 373665 URL: http://llvm.org/viewvc/llvm-project?rev=373665&view=rev Log: OverloadCandidate::getNumParams - silence static analyzer getAs null dereference warning. NFCI. The static analyzer is warning about a potential null dereference,

Re: r373406 - Use scope qualifiers in Clang's tblgen backends to get useful

On 3 Oct 2019, at 17:22, David Blaikie wrote: (mostly joking) any interest in seeing what it'd take to make Clang/LLVM -Wmissing-prototype clean? (which would also catch the same sort of issues, I think?) Sounds like a nice project for someone else. :) John. On Tue, Oct 1, 2019 at 4:10 PM

r373667 - ASTContext - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Thu Oct 3 14:47:42 2019 New Revision: 373667 URL: http://llvm.org/viewvc/llvm-project?rev=373667&view=rev Log: ASTContext - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but we should be a

Re: r373661 - [OPENMP50]Codegen support for scores in context selectors.

Looks like this fails on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11207/steps/stage%201%20check/logs/stdio On Thu, Oct 3, 2019 at 4:47 PM Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: abataev > Date: Thu Oct 3 13:49:48 2019 > New Rev

Re: r373661 - [OPENMP50]Codegen support for scores in context selectors.

Yep, I see. Will fix in couple minutes Best regards, Alexey Bataev 3 окт. 2019 г., в 17:48, Nico Weber написал(а):  Looks like this fails on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11207/steps/stage%201%20check/logs/stdio On Thu, Oct 3, 2019 at 4:47 PM Alexey

Re: r373661 - [OPENMP50]Codegen support for scores in context selectors.

Yep, I see. Will fix in couple minutes Best regards, Alexey Bataev 3 окт. 2019 г., в 17:48, Nico Weber написал(а):  Looks like this fails on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11207/steps/stage%201%20check/logs/stdio On Thu, Oct 3, 2019 at 4:47 PM Alexe

[PATCH] D68413: [clang] [cmake] Add distribution install targets for remaining components

mgorny updated this revision to Diff 223109. mgorny added a comment. Include hmaptool as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68413/new/ https://reviews.llvm.org/D68413 Files: clang/CMakeLists.txt clang/tools/scan-build/CMakeLists.txt clang/tools/scan-view/CMakeLis

[PATCH] D68429: [clang] [cmake] Use add_clang_tool() to install all tools

mgorny created this revision. mgorny added reviewers: compnerd, phosek, smeenai, beanz, tstellar. Switch clang-check, clang-extdef-mapping and clang-offload-bundler to use add_clang_tool() rather than add_clang_executable() with a custom install rule. This makes them LLVM_DISTRIBUTION_COMPONENTS-

r373672 - [OPENMP]Fix the test on Windows, NFC.

Author: abataev Date: Thu Oct 3 15:10:33 2019 New Revision: 373672 URL: http://llvm.org/viewvc/llvm-project?rev=373672&view=rev Log: [OPENMP]Fix the test on Windows, NFC. Modified: cfe/trunk/test/OpenMP/declare_variant_implementation_vendor_codegen.cpp Modified: cfe/trunk/test/OpenMP/decla

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") a

Re: r373661 - [OPENMP50]Codegen support for scores in context selectors.

Committed the fix for the test. Best regards, Alexey Bataev 3 окт. 2019 г., в 17:48, Nico Weber написал(а):  Looks like this fails on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11207/steps/stage%201%20check/logs/stdio On Thu, Oct 3, 2019 at 4:47 PM Alexey Bataev

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose created this revision. jordan_rose added a reviewer: beanz. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Undoes some of the effects of D61909 when using the Xcode CMake generator—it doesn't handle object libraries corr

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

rnk added inline comments. Comment at: clang/include/clang/Driver/Options.td:1943 +def gno_inline_line_tables : Flag<["-"], "gno-inline-line-tables">, + Flags<[CC1Option, CoreOption]>, HelpText<"Don't emit inline line tables">; aprantl wrote: > As a DWARF pers

[PATCH] D68321: Fix clang Visual Studio build instructions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68321/new/ https://reviews.llvm.org/D68321 ___ cfe-commits mailing

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4399-4400 + let Content = [{ +Hint that inline substitution should be attempted when optimizations are +disabled. Does not guarantee that in

[PATCH] D68423: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68423/new/ https://reviews.llvm.org/D68423 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

thakis added a comment. This broke the sphinx bot: http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/48207 Warning, treated as error: /home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/ClangFormatStyleOptions.rst:2295: WARNING: Explicit markup ends without a

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Nice, the solution was right in front of us the whole time. :) lgtm, but please share the TokenCollector class. Comment at: clang/lib/Lex/Pragma.cpp:169 struct TokenCollector

[PATCH] D68413: [clang] [cmake] Add distribution install targets for remaining components

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68413/new/ https://reviews.llvm.org/D68413 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D68430: Don't use object libraries with Xcode

beanz added a comment. This has the side-effect of making `libclang_cpp` effectively empty when you build with Xcode. What exactly does Xcode do with `OBJECT` libraries? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68430/new/ https://reviews.llv

[PATCH] D68429: [clang] [cmake] Use add_clang_tool() to install all tools

beanz added a comment. Are these tools intended to be installed? I thought they were developer focused tools. I don't think we should make install targets for things that the project doesn't want to support publicly. This also changes the behavior of the `install` target to include these extra

Buildbot numbers for the week of 09/15/2019 - 09/21/2019

Hello everyone, Below are some buildbot numbers for the week of 09/15/2019 - 09/21/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 09/22/2019 - 09/28/2019

Hello everyone, Below are some buildbot numbers for the last week of 09/22/2019 - 09/28/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese, aganea, kousikk. Herald added subscribers: ributzka, tschuett, jkorous. Herald added a project: clang. The existing string/character literal skipping code in the dependency directives source minimizer has two issues:

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk updated this revision to Diff 223128. rnk added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. - Fix PGO build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 F

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose added a comment. I'm not quite sure //what// it's doing. The executable targets end up trying to link against the static libraries anyway, which of course haven't been built. It's possible that this is because the LIBTYPE is both STATIC and OBJECT and if it were just OBJECT we might

r373685 - Properly handle instantiation-dependent array bounds.

Author: rsmith Date: Thu Oct 3 18:25:59 2019 New Revision: 373685 URL: http://llvm.org/viewvc/llvm-project?rev=373685&view=rev Log: Properly handle instantiation-dependent array bounds. We previously failed to treat an array with an instantiation-dependent but not value-dependent bound as being

[PATCH] D68430: Don't use object libraries with Xcode

beanz added a comment. In D68430#1693964 , @jordan_rose wrote: > I'm not quite sure //what// it's doing. The executable targets end up trying > to link against the static libraries anyway, which of course haven't been > built. It's possible that this is

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. In D65543#1691819 , @mstorsjo wrote: > Another slightly related thread, regarding libs from the clang resource dir > and how they are specified to the linker (regarding the builtins library): > https://reviews.llvm.org/D51440 I sup

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. One last idea is that we could teach LLD to automatically add this directory to library search path, but then users who link with Visual C++ (not many anymore) will run into this as a corner case issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

kousikk added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:205 + return; +if (*First == '\\') { + if (++First == End) Should you also check if the character right after a backslash is equal to Terminator and if

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge marked an inline comment as done. nridge added a comment. In D67536#1691107 , @hokein wrote: > Could you add tests for this? Certainly, I just wanted to discuss the general approach first, as it will affect what the tests look like. ==

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:631 + MachineBasicBlock::iterator NewMI = + BuildMI(MBB, MI, DL, TII.get(RISCV::PseudoCALL)) + .add(MI->getOperand(0)); apazos wrote: > Where are we

[PATCH] D68410: [AttrDocs] document always_inline

kristina added a comment. Just linking relevant bug for the record: https://bugs.llvm.org/show_bug.cgi?id=43517 Also, I'm fairly certain `__forceinline` and `always_inline`, confusingly enough differ in semantics, with `__forceinline` only being a stronger hint on MSVC. Repository: rG LLVM

[PATCH] D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

erik.pilkington added inline comments. Comment at: clang/test/Sema/format-strings-pedantic.c:1 -// RUN: %clang_cc1 -fsyntax-only -verify -Wformat -Wformat-pedantic -isystem %S/Inputs %s +// RUN: %clang_cc1 -fsyntax-only -verify -Wformat -Wformat-type-confusion %s -

[PATCH] D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

erik.pilkington updated this revision to Diff 223136. erik.pilkington marked 6 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67775/new/ https://reviews.llvm.org/D67775 Files: clang/include/clang/AST/Fo

[clang-tools-extra] r373694 - [clang-tools-extra] [cmake] Use add_clang_tool() to install tools

Author: mgorny Date: Thu Oct 3 22:40:29 2019 New Revision: 373694 URL: http://llvm.org/viewvc/llvm-project?rev=373694&view=rev Log: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools Replace add_clang_executable() calls with add_clang_tool() that takes care of creating correct, di

[PATCH] D68423: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools

This revision was automatically updated to reflect the committed changes. Closed by commit rL373694: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

r373695 - [clang] [cmake] Add distribution install targets for remaining components

Author: mgorny Date: Thu Oct 3 22:43:20 2019 New Revision: 373695 URL: http://llvm.org/viewvc/llvm-project?rev=373695&view=rev Log: [clang] [cmake] Add distribution install targets for remaining components Add install targets as necessary to install bash-autocomplete, scan-build and scan-view vi

[PATCH] D68429: [clang] [cmake] Use add_clang_tool() to install all tools

mgorny added a comment. Well, they were installed for me, and all of them certainly have `install()` command right now. Not sure if there's some high magic making `install()` implicitly not install stuff here ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68429/new/ https://review

[PATCH] D68413: [clang] [cmake] Add distribution install targets for remaining components

This revision was automatically updated to reflect the committed changes. Closed by commit rL373695: [clang] [cmake] Add distribution install targets for remaining components (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

MaskRay added a comment. Why "inactive region", not "skipped ranges"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with a few nitpicks about unnecessary nesting. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:205 + return; +if (*First == '\\') { +

<    1   2