rnk added subscribers: ahatanak, void.
rnk added a comment.
I notice that x86 is the only target for which validateInput/OutputSize are
implemented. If you are going to disable these checks, perhaps we should get
rid of these methods and leave all these errors to the backend? You could add
`-S` to the x86_32-inline-asm.c test and turn it into an integration test that
shows that we no longer crash. It would need `REQUIRES: x86-registered-target`
if you do that.
Adding @void and @ahatanak, who added these long ago.
================
Comment at: clang/lib/Basic/Targets/X86.cpp:1768
// XMM0
if (SSELevel >= SSE1)
return Size <= 128U;
----------------
I think the same issues apply to this SSELevel check. I suspect no one
complains about these checks because everyone enables SSE2 in one way or
another.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68255/new/
https://reviews.llvm.org/D68255
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
