[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

kadircet added a comment. This looks great, thanks! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:745 +bool SymbolCollector::shouldProcessFile(FileID FID) { + assert(ASTCtx); we already have `shouldIndexFile` as an anonymous function inside

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Wawha updated this revision to Diff 216061. Wawha added a comment. Herald added a subscriber: ormris. I update the patch for the last version of clang format, especially since option "AllowShortLambdasOnASingleLine" has been added (which require more change for this patch). Indeed, for AllowShor

[PATCH] D66142: clang: Don't warn on unused momit-leaf-frame-pointer when frame pointers are off.

MaskRay added a comment. LGTM Comment at: cfe/trunk/test/Driver/frame-pointer-elim.c:31 +// fno-omit-frame-pointer -momit-leaf-frame-pointer can be overwritten by +// fomit-frame-pointer later on the command without warning Omitted `-` Repository: rL LLVM

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:389 llvm::sort(References, [](const Reference &L, const Reference &R) { - return std::tie(L.Loc, L.CanonicalTarget, L.Role) < - std::tie(R.L

[PATCH] D66350: Rudimentary support for Doxygen \retval command

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66350/new/ https://reviews.llvm.org/D66350 ___ cfe-c

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:745 +bool SymbolCollector::shouldProcessFile(FileID FID) { + assert(ASTCtx); kadircet wrote: > we already have `

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

ilya-biryukov updated this revision to Diff 216066. ilya-biryukov added a comment. - Expose the existing helper instead of introducing a new one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66226/new/ https://reviews.llvm.org/D66226 Files: clan

r369345 - Rudimentary support for Doxygen \retval command

Author: sberg Date: Tue Aug 20 01:36:21 2019 New Revision: 369345 URL: http://llvm.org/viewvc/llvm-project?rev=369345&view=rev Log: Rudimentary support for Doxygen \retval command ...so that at least a preceding \param etc. that lacks a description gets a -Wdocumentation warning (instead of erron

[PATCH] D66350: Rudimentary support for Doxygen \retval command

This revision was automatically updated to reflect the committed changes. Closed by commit rL369345: Rudimentary support for Doxygen \retval command (authored by sberg, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:194 CI.getDiagnostics().setIgnoreAllWarnings(true); +/// Instruct the parser to ask our ASTConsume

[PATCH] D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛

gribozavr added a comment. LGTM, thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66270/new/ https://reviews.llvm.org/D66270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛

gribozavr added a comment. LGTM, thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66269/new/ https://reviews.llvm.org/D66269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:389 llvm::sort(References, [](const Reference &L, const Reference &R) { - return std::tie(L.Loc, L.CanonicalTarget, L.Role) < - std::tie(R.Loc, R.CanonicalTarget, R.Role); +

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

ilya-biryukov updated this revision to Diff 216073. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Change /// to // Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66226/new/ https://reviews.llvm.org/D66226 Files:

[clang-tools-extra] r369349 - [clangd] Skip function bodies inside processed files while indexing

Author: ibiryukov Date: Tue Aug 20 01:54:30 2019 New Revision: 369349 URL: http://llvm.org/viewvc/llvm-project?rev=369349&view=rev Log: [clangd] Skip function bodies inside processed files while indexing Summary: This significantly improves performance of background indexing. We do not collect r

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

This revision was automatically updated to reflect the committed changes. Closed by commit rL369349: [clangd] Skip function bodies inside processed files while indexing (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

hans accepted this revision. hans added a comment. lgtm, and many thanks for writing release notes! Go ahead and commit to the branch directly with SVN or let me know if you'd like me to do it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66294/new/ https://reviews.llvm.org/D66294

[PATCH] D66394: clang-cl: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer

hans accepted this revision. hans added a comment. Nice! Please include a mention in docs/ReleaseNotes.rst :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66394/new/ https://reviews.llvm.org/D66394 ___ cfe-commits mailing list cfe-commits

[PATCH] D66462: Removed the 'id' AST matcher, which is superseded by '.bind()'

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The 'id' matcher is not even included in the AST Matchers Reference document, so I don't expect there to be a significant number of users. There's no reason to provide two ways to do the exact

[PATCH] D66462: Removed the 'id' AST matcher, which is superseded by '.bind()'

gribozavr updated this revision to Diff 216082. gribozavr added a comment. Fixed a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66462/new/ https://reviews.llvm.org/D66462 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/unitte

[PATCH] D66462: Removed the 'id' AST matcher, which is superseded by '.bind()'

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Yay, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66462/new/ https://reviews.llvm.org/D66462 ___

Re: r369043 - [Sema] Implement DR2386 for C++17 structured binding

Merged to release_90 in r369361. On Thu, Aug 15, 2019 at 9:44 PM Reid Kleckner via cfe-commits wrote: > > Author: rnk > Date: Thu Aug 15 12:45:28 2019 > New Revision: 369043 > > URL: http://llvm.org/viewvc/llvm-project?rev=369043&view=rev > Log: > [Sema] Implement DR2386 for C++17 structured bind

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:68 + bool hasOnlyRootStmtChildren(); + // We only support extraction of RootStmts. A RootStmt as a statement that is + // fully selected including all of it's children. ---

[PATCH] D64718: [clangd] Triggering indexing on each translation unit with an error

kadircet planned changes to this revision. kadircet added a comment. this requires keeping an inverted dependency graph, which can be quite expensive memory-wise. In a project like chromium there are ~40k translation units, and it is safe to assume there are ~1k core headers just coming from std

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:389 llvm::sort(References, [](const Reference &L, const Reference &R) { - return std::tie(L.Loc, L.CanonicalTarget, L.Role) < - std::tie(R.L

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

sammccall added a comment. Main themes are: - there are a few places we can reduce scope for the first patch: e.g. template support - internally, it'd be clearer to pass data around in structs and avoid complex classes unless the abstraction is important - high-level documentation would aid in

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:389 llvm::sort(References, [](const Reference &L, const Reference &R) { - return std::tie(L.Loc, L.CanonicalTarget, L.Role) < - std::tie(R.Loc, R.CanonicalTarget, R.Role); +

[PATCH] D66470: [Syntax] Added function to get macro expansion tokens to TokenBuffer.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet. Herald added a project: clang. Returns the first token in every mapping where the token is an identifier. This API is required to be able to highlight macro expansion

[PATCH] D66470: [Syntax] Added function to get macro expansion tokens to TokenBuffer.

jvikstrom updated this revision to Diff 216103. jvikstrom added a comment. Readded dissapeared newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66470/new/ https://reviews.llvm.org/D66470 Files: clang/include/clang/Tooling/Syntax/Tokens.h

r369373 - [OpenCL] Add const, volatile and pointer builtin handling

Author: svenvh Date: Tue Aug 20 05:21:03 2019 New Revision: 369373 URL: http://llvm.org/viewvc/llvm-project?rev=369373&view=rev Log: [OpenCL] Add const, volatile and pointer builtin handling Const, volatile, and pointer types were previously available, but not working. This patch adds handling f

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:200 CXXRecordDecl *Canonical = Record->getCanonicalDecl(); if (Canonical->hasAttr() || Canonical->hasAttr()) return; mgehre wrote: > gribozavr wrote: > > mgehre wrote: > > >

r369380 - Removed the 'id' AST matcher, which is superseded by '.bind()'

Author: gribozavr Date: Tue Aug 20 06:02:28 2019 New Revision: 369380 URL: http://llvm.org/viewvc/llvm-project?rev=369380&view=rev Log: Removed the 'id' AST matcher, which is superseded by '.bind()' Summary: The 'id' matcher is not even included in the AST Matchers Reference document, so I don't

[PATCH] D66462: Removed the 'id' AST matcher, which is superseded by '.bind()'

This revision was automatically updated to reflect the committed changes. Closed by commit rL369380: Removed the 'id' AST matcher, which is superseded by '.bind()' (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D66470: [Syntax] Added function to get macro expansion tokens to TokenBuffer.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:239 + /// Get all tokens that expand a macro in FID. For the following input + /// #define

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. This seems ok (not sure why stalled) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57659/new/ https://reviews.llvm.org/D57659 __

[PATCH] D65182: [analyzer] Add fix-it hint support.

gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:347 + + virtual llvm::ArrayRef getFixits() const { return Fixits; } + Why is it virtual? In fact, why is BugReporter subclassable at all? ==

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

xbolva00 added a comment. Added some reviewers Patch improves suboptimal diagnostic, which misses bugs like: https://bugs.llvm.org/show_bug.cgi?id=43052 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 _

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. In D57660#1637220 , @xbolva00 wrote: > Added some reviewers > > Patch improves suboptimal diagnostic, which misses bugs like: > https://bugs.llvm.org/show_bug.cgi?id=43052 Thanks for taking a look ! Repository: rC Clang

r369385 - [Syntax] Added function to get macro expansion tokens to TokenBuffer.

Author: jvikstrom Date: Tue Aug 20 06:34:01 2019 New Revision: 369385 URL: http://llvm.org/viewvc/llvm-project?rev=369385&view=rev Log: [Syntax] Added function to get macro expansion tokens to TokenBuffer. Summary: Returns the first token in every mapping where the token is an identifier. This AP

[PATCH] D66470: [Syntax] Added function to get macro expansion tokens to TokenBuffer.

This revision was automatically updated to reflect the committed changes. jvikstrom marked 2 inline comments as done. Closed by commit rL369385: [Syntax] Added function to get macro expansion tokens to TokenBuffer. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added

Re: r369251 - [OpenCL] Fix addr space deduction for pointers/references to arrays.

Hi Hans, Is it still possible to port this fix to the release branch? Thanks, Anastasia From: cfe-commits on behalf of Anastasia Stulova via cfe-commits Sent: 19 August 2019 12:43 To: cfe-commits@lists.llvm.org Subject: r369251 - [OpenCL] Fix addr space dedu

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

hokein updated this revision to Diff 216136. hokein marked 2 inline comments as done. hokein added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66349/new/ https://reviews.llvm.org/D66349 Files: clang-tools-ex

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66349/new/ https://reviews.llvm.org/D66349 _

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

alexfh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/bugprone-dynamic-static-initializers.hpp:1 +// RUN: %check_clang_tidy %s bugprone-dynamic-static-initializers %t + aaron.ballman wrote: > I'm a bit confused. > > 1) Why is this file a .

[PATCH] D66473: Removed some dead code in BugReporter and related files

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr added a reviewer: NoQ. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66473 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h clang/includ

[clang-tools-extra] r369387 - [clangd] Fix one testcase in XRefsTests.

Author: hokein Date: Tue Aug 20 07:07:27 2019 New Revision: 369387 URL: http://llvm.org/viewvc/llvm-project?rev=369387&view=rev Log: [clangd] Fix one testcase in XRefsTests. Summary: The test didn't test anything actually -- it used "[]" as annotation which should be "[[]]". This patch also fix

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369387: [clangd] Fix one testcase in XRefsTests. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D66473: Removed some dead code in BugReporter and related files

NoQ added a comment. Yay, that'll make my life a lot easier! I heard you have an automatic tool for this sort of stuff, right? Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:408 -public: - enum Kind { BasicBRKind, PathSensitiveBRKind }; - -

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:347 + + virtual llvm::ArrayRef getFixits() const { return Fixits; } + gribozavr wrote: > Why is it virtual? In fact, w

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/test/clang-tidy/bugprone-dynamic-static-initializers.hpp:1 +// RUN: %check_clang_tidy %s bugprone-dynamic-static-initialize

[PATCH] D66478: [clangd] Ignore implicit conversion-operator nodes in find refs.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66478 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-ext

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

riccibruno updated this revision to Diff 216152. riccibruno added a comment. Rebased. Thanks for the review @xbolva00 ! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57659/new/ https://reviews.llvm.org/D57659 Files: clang/lib/Sema/SemaChecking.cpp Index: clan

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno updated this revision to Diff 216153. riccibruno added a comment. Rebased Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sem

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

probinson added inline comments. Comment at: test/CodeGenCXX/debug-info-atexit-stub.cpp:14 + +// CHECK: define internal void @"??__Ff@?1??d@@YAPEAU?$c@UBXZ@YAXXZ"() +// CHECK-SAME: !dbg ![[SUBPROGRAM:[0-9]+]] { Do these Windows-mangled names work on Linux?

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno updated this revision to Diff 216156. riccibruno added a comment. Rebased Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D57747 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-unsequenced.c clang/te

[PATCH] D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

riccibruno updated this revision to Diff 216157. riccibruno added a comment. Rebased Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58297/new/ https://reviews.llvm.org/D58297 Files: clang/lib/Sema/SemaChecking.cpp clang/test/CXX/drs/dr2xx.cpp clang/test/CXX

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno updated this revision to Diff 216158. riccibruno retitled this revision from "[Sema] SequenceChecker: C++17 sequencing rule for call expression." to "[Sema] SequenceChecker: C++17 sequencing rule for call expressions.". riccibruno added a comment. Rebased Repository: rC Clang CHA

[PATCH] D66481: [C++20] Support for lambdas in unevaluated context

krzysztof-jusiak created this revision. krzysztof-jusiak added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Problem: - Lambdas in unevaluated context aren't supported in the newest clang yet but are required for our usage of jit. Solution: - Add su

[PATCH] D66481: [C++20] Support for lambdas in unevaluated context

riccibruno added a comment. Can you submit the patch with the full context (ie: git diff -U999) ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66481/new/ https://reviews.llvm.org/D66481 ___ cfe-commits mailing l

[PATCH] D66481: [C++20] Support for lambdas in unevaluated context

lebedev.ri added a comment. Doesn't this inadvertently allow them in every standard? That seems wrong. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66481/new/ https://reviews.llvm.org/D66481 ___ cfe-commits mailing

r369397 - [clang] Use the new Regex::isValid() with no parameter

Author: jankratochvil Date: Tue Aug 20 09:07:31 2019 New Revision: 369397 URL: http://llvm.org/viewvc/llvm-project?rev=369397&view=rev Log: [clang] Use the new Regex::isValid() with no parameter Differential Revision: https://reviews.llvm.org/D66463 Modified: cfe/trunk/lib/Analysis/CloneDete

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

aaron.ballman added a comment. In D66364#1635863 , @ldionne wrote: > In D66364#1635814 , @aaron.ballman > wrote: > > > [ ...] > > > > Adding some libc++ maintainers to see if they have opinions. > > > > `__extensio

[PATCH] D66481: [C++20] Support for lambdas in unevaluated context

krzysztof-jusiak added a comment. In D66481#1637525 , @riccibruno wrote: > Can you submit the patch with the full context (ie: git diff -U999) ? Sure, will do it Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66481/ne

[PATCH] D66481: [C++20] Support for lambdas in unevaluated context

krzysztof-jusiak added a comment. In D66481#1637530 , @lebedev.ri wrote: > Doesn't this inadvertently allow them in every standard? That seems wrong. Good point, you are right, will fix it and resubmit 👍 Repository: rC Clang CHANGES SINCE LAST ACTIO

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

kmclaughlin updated this revision to Diff 216178. kmclaughlin added a comment. - Added a new test file, aarch64-sve-asm-negative.ll - Updated description of the 'y' constraint in LangRef.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66302/new/ https://reviews.llvm.org/D66302 File

r369402 - win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer

Author: nico Date: Tue Aug 20 09:28:11 2019 New Revision: 369402 URL: http://llvm.org/viewvc/llvm-project?rev=369402&view=rev Log: win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer MSVC 2017 update 3 (_MSC_VER 1911) enables /Zc:twoPhase by default, and so should clang-c

[PATCH] D66394: clang-cl: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer

This revision was automatically updated to reflect the committed changes. Closed by commit rL369402: win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

ldionne added a comment. In D66364#1637570 , @aaron.ballman wrote: > In D66364#1635863 , @ldionne wrote: > > > In D66364#1635814 , @aaron.ballman > > wrote: > > > > > [ ...

r369408 - [LifetimeAnalysis] Add support for free functions

Author: xazax Date: Tue Aug 20 09:45:06 2019 New Revision: 369408 URL: http://llvm.org/viewvc/llvm-project?rev=369408&view=rev Log: [LifetimeAnalysis] Add support for free functions Differential Revision: https://reviews.llvm.org/D66303 Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/trunk

[PATCH] D66303: [LifetimeAnalysis] Add support for free functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL369408: [LifetimeAnalysis] Add support for free functions (authored by xazax, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

r369414 - [Attr] Support _attribute__ ((fallthrough))

Author: nathan-huckleberry Date: Tue Aug 20 10:16:49 2019 New Revision: 369414 URL: http://llvm.org/viewvc/llvm-project?rev=369414&view=rev Log: [Attr] Support _attribute__ ((fallthrough)) Summary: Fixed extraneous matches of non-NullStmt Reviewers: aaron.ballman, rsmith, efriedma, xbolva00 Rev

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added subscribers: cfe-commits, abrachet, mgorny. Herald added a reviewer: alexshap. Herald added a reviewer: jdoerfert. Herald added a project: clang. clang-offload-bundler currently uses partial linking for creating fat

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

This revision was automatically updated to reflect the committed changes. Closed by commit rL369414: [Attr] Support _attribute__ ((fallthrough)) (authored by Nathan-Huckleberry, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, mgehre. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs. This patch relaxes some of the checks so we can detect more cases where local variable escapes. Repository

[PATCH] D66303: [LifetimeAnalysis] Add support for free functions

xazax.hun marked 2 inline comments as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6622 +return false; + const auto *RD = FD->getParamDecl(0)->getType()->getPointeeCXXRecordDecl(); + if (!FD->isInStdNamespace() || !RD || !RD->isInStdNamespa

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r369418 - Fix name of the error message, NFC.

Author: abataev Date: Tue Aug 20 10:50:13 2019 New Revision: 369418 URL: http://llvm.org/viewvc/llvm-project?rev=369418&view=rev Log: Fix name of the error message, NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/i

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:94 - Canonical->addAttr(::new (Context) Attribute(SourceRange{}, Context, - /*DerefType*/ nullptr, - /*Spelling=

[PATCH] D66488: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new pass manager

leonardchan created this revision. leonardchan added reviewers: pcc, tejohnson. leonardchan added a project: clang. Herald added subscribers: dexonsmith, steven_wu, inglorion, mehdi_amini. Match the behavior of D65009 under the new pass manager also. Repository

[PATCH] D66473: Removed some dead code in BugReporter and related files

gribozavr marked 3 inline comments as done. gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:408 -public: - enum Kind { BasicBRKind, PathSensitiveBRKind }; - NoQ wrote: > Hey, i just added that! :D (

[PATCH] D66473: [analyzer] Removed some dead code in BugReporter and related files

Szelethus added a comment. No way the entire `NodeResolver` is dead code! I spent so much time trying to understand it! I mean, now that I think about it, we literally deep copy every `ExplodedNode`, so why would we need the mapping to the original, right? Wow. Thank you so much for clearing th

[PATCH] D66473: [analyzer] Removed some dead code in BugReporter and related files

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2343 InterExplodedGraphMap ForwardMap; - TrimmedGraph = OriginalGraph->trim(Nodes, &ForwardMap, &InverseMap); gribozavr wrote: > NoQ wrote: > > Btw these days we stro

r369427 - [Sema][Typo] Fix assertion failure for expressions with multiple typos

Author: dgoldman Date: Tue Aug 20 12:03:15 2019 New Revision: 369427 URL: http://llvm.org/viewvc/llvm-project?rev=369427&view=rev Log: [Sema][Typo] Fix assertion failure for expressions with multiple typos Summary: As Typo Resolution can create new TypoExprs while resolving typos, it is necessary

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

leonardchan added a comment. It seems that this test leads to an `UNREACHABLE` under the new pass manager (can check this by adding `-fexperimental-new-pass-manager` to the test. I think this is because the passes for lowering the `llvm.coro` intrinsics are not yet ported to the new PM. Would i

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

This revision was automatically updated to reflect the committed changes. Closed by commit rL369427: [Sema][Typo] Fix assertion failure for expressions with multiple typos (authored by dgoldman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: r

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, hfinkel, lattner, rupprecht. leonardchan added a project: clang. Herald added subscribers: dexonsmith, mehdi_amini, mgorny. The new PM serves as a replacement for the legacy PM, and promises better codegen, bette

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

leonardchan added a comment. As of now, from running `check-llvm` and `check-clang` there's 2 failing tests, but I'm trying to get those addressed. - `Clang :: CodeGen/split-lto-unit.c` which should be resolved by D66488 - `Clang :: CodeGenCXX/ubsan-coroutines.

[PATCH] D65481: NFCI: Simplify SourceManager::translateFile by removing code path that should never be taken

arphaman added a comment. Ping. I will commit it this week if there are no objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65481/new/ https://reviews.llvm.org/D65481 ___ cfe-commits mailing l

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

NoQ added a comment. In D65575#1621425 , @Szelethus wrote: > I think it isn't crucial of getting rid of the "The" prefix, if we append ", > which participates in a condition later" (which sounds so much better than > what I added in this patch), so maybe

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

vsk added a comment. In D44672#1637891 , @leonardchan wrote: > It seems that this test leads to an `UNREACHABLE` under the new pass manager > (can check this by adding `-fexperimental-new-pass-manager` to the test. I > think this is because the passes fo

[PATCH] D65209: [analyzer] Fix a SARIF exporter crash with macro expansions

aaron.ballman added a comment. In D65209#1606075 , @aaron.ballman wrote: > This LGTM, but I'd appreciate a second reviewer chiming in only because Joe > is a coworker. Sufficient time has passed that any concerns other reviewers have can be addressed

[PATCH] D65211: [analyzer] Update the SARIF exporter to SARIF 2.1

aaron.ballman added a comment. In D65211#1606089 , @aaron.ballman wrote: > This LGTM, but I'd appreciate a second reviewer chiming in only because Joe > is a coworker. Sufficient time has passed that any concerns other reviewers have can be addressed

[PATCH] D65206: [analyzer] Fix text range end columns in SARIF to be exclusive

aaron.ballman added a comment. In D65206#1606072 , @aaron.ballman wrote: > This LGTM, but I'd appreciate a second reviewer chiming in only because Joe > is a coworker. Sufficient time has passed that any concerns other reviewers have can be addressed

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

nickdesaulniers created this revision. nickdesaulniers added a reviewer: rsmith. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. It seems that CodeGen was always using ExternalLinkage when emitting a GlobalDecl with __attribute__((alias)). This lea

r369432 - [OPENMP]Fix delayed diagnostics for standalone declare target directive.

Author: abataev Date: Tue Aug 20 12:50:13 2019 New Revision: 369432 URL: http://llvm.org/viewvc/llvm-project?rev=369432&view=rev Log: [OPENMP]Fix delayed diagnostics for standalone declare target directive. If the function is marked as declare target in a standalone directive, the delayed diagnos

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

aaron.ballman added a comment. @rsmith are you fine with implementing the diagnostic for these keywords piecemeal based on the pattern from this patch, or do you want to see an omnibus patch that adds all of them at once? In D66364#1637635 , @ldionne wro

[PATCH] D66493: [NewPM] Run ubsan-coroutines test under the legacy pass manager only

leonardchan created this revision. leonardchan added reviewers: vsk, modocache. leonardchan added a project: clang. Herald added a subscriber: EricWF. The passes that lower the `llvm.coro.*` instrinsics have not yet been ported, so only run under the legacy PM for now. See https://bugs.llvm.org/

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

leonardchan added a comment. In D44672#1637984 , @vsk wrote: > In D44672#1637891 , @leonardchan > wrote: > > > It seems that this test leads to an `UNREACHABLE` under the new pass > > manager (can check this by ad

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CommonBugCategories.cpp:14-20 const char * const CoreFoundationObjectiveC = "Core Foundation/Objective-C"; const char * const LogicError = "Logic error"; const char * con

[PATCH] D62899: [analyzer][UninitializedObjectChecker] Mark uninitialized regions as interesting.

NoQ added a comment. In D62899#1634657 , @Szelethus wrote: > In D62899#1551312 , @NoQ wrote: > > > In D62899#1549715 , @Szelethus > > wrote: > > > > > Added a proper testfil

  1   2   >