ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:745
+bool SymbolCollector::shouldProcessFile(FileID FID) {
+ assert(ASTCtx);
----------------
kadircet wrote:
> we already have `shouldIndexFile` as an anonymous function inside this file,
> which performs a similar operation with a cache (since `FileFilter` performs
> symlink resolution and a disk read).
>
> Could you make that one a member instead and use it?
Thanks, did not notice it on the first go. Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66226/new/
https://reviews.llvm.org/D66226
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
