kadircet planned changes to this revision.
kadircet added a comment.

this requires keeping an inverted dependency graph, which can be quite 
expensive memory-wise.
In a project like chromium there are ~40k translation units, and it is safe to 
assume there are ~1k core headers just coming from std library,
that are most likely included by all of the translation units directly or 
transatively. This results in ~320MB of memory usage even if we just
store a pointer.

It is quite likely that there would be a lot more "base" headers like that, 
which could easily drive up the memory usage.

We might need some tradeoffs to limit that usage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64718/new/

https://reviews.llvm.org/D64718



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to