ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:239
+ /// Get all tokens that expand a macro in FID. For the following input
+ /// #define FOO B
----------------
NIT: add the doxygen tag for parameter `in \p FID`
================
Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:245
+ /// FOO;
+ /// macroExpansions() returns {"FOO2", "FOO"}.
+ std::vector<const syntax::Token *> macroExpansions(FileID FID) const;
----------------
NIT: `FOO` and `FOO2` are also mentioned in the `#define` lines. Maybe clarify
that the results are at lines 3 and 5, not 1 and 2?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66470/new/
https://reviews.llvm.org/D66470
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
